Kaliop\eZMigrationBundle\Core\Executor\ContentManager::generateMigration()

Complexity

Conditions	10
Paths	10

Size

Total Lines	101
Code Lines	69

Duplication

Lines	21
Ratio	20.79 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes

0

<?php
    public function generateMigration(array $matchCondition, $mode)
    {
        $previousUserId = $this->loginUser(self::ADMIN_USER_ID);
        $contentCollection = $this->contentMatcher->match($matchCondition);
        $data = array();

        /** @var \eZ\Publish\API\Repository\Values\Content\Content $content */
        foreach ($contentCollection as $content) {

The expression $contentCollection of type object<Kaliop\eZMigrationBundle\API\Collection\ContentCollection>|null is not guaranteed to be traversable. How about adding an additional type check?

            $location = $this->repository->getLocationService()->loadLocation($content->contentInfo->mainLocationId);
            $contentType = $this->repository->getContentTypeService()->loadContentType(
                $content->contentInfo->contentTypeId
            );

            $contentData = array(
                'type' => reset($this->supportedStepTypes),
                'mode' => $mode
            );

            switch ($mode) {
                case 'create':
                    $contentData = array_merge(
                        $contentData,
                        array(
                            'content_type' => $contentType->identifier,
                            'parent_location' => $location->parentLocationId,
                            'priority' => $location->priority,
                            'is_hidden' => $location->invisible,
                            'sort_field' => $this->sortConverter->sortField2Hash($location->sortField),
                            'sort_order' => $this->sortConverter->sortOrder2Hash($location->sortOrder),
                            'remote_id' => $content->contentInfo->remoteId,
                            'location_remote_id' => $location->remoteId
                        )
                    );
                    $locationService = $this->repository->getLocationService();
                    $locations = $locationService->loadLocations($content->contentInfo);
                    if (count($locations) > 1) {
                        $otherParentLocations = array();
                        foreach($locations as $otherLocation) {
                            if ($otherLocation->id != $location->id) {
                                $otherParentLocations[] = $otherLocation->parentLocationId;
                            }
                        }
                        $contentData['other_parent_locations'] = $otherParentLocations;
                    }
                    break;
                case 'update':

This code seems to be duplicated across your project.

                    $contentData = array_merge(
                        $contentData,
                        array(
                            'match' => array(
                                ContentMatcher::MATCH_CONTENT_REMOTE_ID => $content->contentInfo->remoteId
                            ),
                            'new_remote_id' => $content->contentInfo->remoteId,
                        )
                    );
                    break;
                case 'delete':

This code seems to be duplicated across your project.

                    $contentData = array_merge(
                        $contentData,
                        array(
                            'match' => array(
                                ContentMatcher::MATCH_CONTENT_REMOTE_ID => $content->contentInfo->remoteId
                            )
                        )
                    );
                    break;
                default:
                    throw new \Exception("Executor 'content' doesn't support mode '$mode'");
            }

            if ($mode != 'delete') {

                $attributes = array();
                foreach ($content->getFieldsByLanguage($this->getLanguageCode()) as $fieldIdentifier => $field) {
                    $fieldDefinition = $contentType->getFieldDefinition($fieldIdentifier);
                    $attributes[$field->fieldDefIdentifier] = $this->complexFieldManager->fieldValueToHash(
                        $fieldDefinition->fieldTypeIdentifier, $contentType->identifier, $field->value
                    );
                }

                $contentData = array_merge(
                    $contentData,
                    array(
                        'lang' => $this->getLanguageCode(),
                        'section' => $content->contentInfo->sectionId,
                        'owner' => $content->contentInfo->ownerId,
                        'modification_date' => $content->contentInfo->modificationDate->getTimestamp(),
                        'publication_date' => $content->contentInfo->publishedDate->getTimestamp(),
                        'always_available' => (bool)$content->contentInfo->alwaysAvailable,
                        'attributes' => $attributes
                    )
                );
            }

            $data[] = $contentData;
        }

        $this->loginUser($previousUserId);
        return $data;
    }
}