kaliop-uk / ezmigrationbundle

Core/Executor/ReferenceExecutor.php

Spacing +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
             throw new \Exception("Invalid step definition: file '$fileName' for saving references already exists");
         }
 
-        if (! $this->referenceResolver instanceof EnumerableReferenceResolverInterface) {
+        if (!$this->referenceResolver instanceof EnumerableReferenceResolverInterface) {
             throw new \Exception("Can not save references as resolver is not enumerable");
         }
 

Core/ReferenceResolver/ChainResolver.php

Spacing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
         $refs = array();
 
         foreach ($this->resolvers as $resolver) {
-            if (! $resolver instanceof EnumerableReferenceResolverInterface) {
+            if (!$resolver instanceof EnumerableReferenceResolverInterface) {
                 throw new \Exception("Could not enumerate references because of chained resolver of type: " . get_class($resolver));
             }
 

Core/Matcher/ReferenceMatcher.php

Spacing +2 added lines, -2 removed lines

@@ -81,7 +81,7 @@ 
 
             switch ($key) {
                 case self::MATCH_AND:
-                    foreach($values as $subCriterion) {
+                    foreach ($values as $subCriterion) {
                         $value = $this->match($subCriterion);
                         if (!reset($value)) {
                             return $value;
@@ -90,7 +90,7 @@ 
                     return array(true);
 
                 case self::MATCH_OR:
-                    foreach($values as $subCriterion) {
+                    foreach ($values as $subCriterion) {
                         $value = $this->match($subCriterion);
                         if (reset($value)) {
                             return $value;

Core/Matcher/QueryBasedMatcher.php

Spacing +6 added lines, -6 removed lines

@@ -128,7 +128,7 @@ 
                 return new Query\Criterion\DateMetadata(Query\Criterion\DateMetadata::CREATED, self::$operatorsMap[$operator], $match);
 
             case self::MATCH_GROUP:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->groupMatcher->matchOneByKey($value)->id;
                     }
@@ -144,7 +144,7 @@ 
                 return new Query\Criterion\DateMetadata(Query\Criterion\DateMetadata::MODIFIED, self::$operatorsMap[$operator], $match);
 
             case self::MATCH_OBJECT_STATE:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->stateMatcher->matchOneByKey($value)->id;
                     }
@@ -152,7 +152,7 @@ 
                 return new Query\Criterion\ObjectStateId($values);
 
             case self::MATCH_OWNER:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->userMatcher->matchOneByKey($value)->id;
                     }
@@ -172,7 +172,7 @@ 
                 return new Query\Criterion\ParentLocationId($locationIds);
 
             case self::MATCH_SECTION:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->sectionMatcher->matchOneByKey($value)->id;
                     }
@@ -193,7 +193,7 @@ 
 
             case self::MATCH_AND:
                 $subCriteria = array();
-                foreach($values as $subCriterion) {
+                foreach ($values as $subCriterion) {
                     $value = reset($subCriterion);
                     $subCriteria[] = $this->getQueryCriterion(key($subCriterion), $value);
                 }
@@ -201,7 +201,7 @@ 
 
             case self::MATCH_OR:
                 $subCriteria = array();
-                foreach($values as $subCriterion) {
+                foreach ($values as $subCriterion) {
                     $value = reset($subCriterion);
                     $subCriteria[] = $this->getQueryCriterion(key($subCriterion), $value);
                 }

Core/ContextHandler.php

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
     public function storeCurrentContext($migrationName)
     {
         $context = array();
-        foreach($this->providers as $label => $provider) {
+        foreach ($this->providers as $label => $provider) {
             $context[$label] = $provider->getCurrentContext($migrationName);
         }
 
@@ -52,7 +52,7 @@ 
         if (!is_array($context)) {
             throw new \Exception("No execution context found associated with migration '$migrationName'");
         }
-        foreach($this->providers as $label => $provider) {
+        foreach ($this->providers as $label => $provider) {
             if (isset($context[$label])) {
                 $provider->restoreContext($migrationName, $context[$label]);
             }

Command/MigrationCommand.php

Spacing +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
 
             $output->writeln('<info>Migration: ' . $migration->name . '</info>');
             $output->writeln('Status: ' . $status);
-            $output->writeln('Executed on: <info>' . ($migration->executionDate != null ? date("Y-m-d H:i:s", $migration->executionDate) : '--'). '</info>');
+            $output->writeln('Executed on: <info>' . ($migration->executionDate != null ? date("Y-m-d H:i:s", $migration->executionDate) : '--') . '</info>');
             $output->writeln('Execution notes: <info>' . $migration->executionError . '</info>');
 
             if ($migration->status == Migration::STATUS_SUSPENDED) {

Core/Executor/MailExecutor.php

Doc Comments +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     /**
      * @param array $dsl
      * @param array $context
-     * @return true
+     * @return boolean
      * @throws \Exception
      */
     protected function send($dsl, $context)

Core/Executor/HTTPExecutor.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
         $body = isset($dsl['body']) ? $this->resolveReferencesInText($dsl['body']) : null;
 
         if (isset($dsl['client'])) {
-            $client = $this->container->get('httplug.client.'.$dsl['client']);
+            $client = $this->container->get('httplug.client.' . $dsl['client']);
         } else {
             $client = $this->container->get('httplug.client');
         }

Core/StorageHandler/Database/Migration.php

Doc Comments +3 added lines

@@ -447,6 +447,9 @@
         );
     }
 
+    /**
+     * @param APIMigration $migration
+     */
     protected function getEntityName($migration)
     {
         return end(explode('\\', get_class($migration)));

Spacing +5 added lines, -5 removed lines

@@ -171,7 +171,7 @@ 
     public function endMigration(APIMigration $migration, $force = false)
     {
         if ($migration->status == APIMigration::STATUS_STARTED) {
-            throw new \Exception($this->getEntityName($migration)." '{$migration->name}' can not be ended as its status is 'started'...");
+            throw new \Exception($this->getEntityName($migration) . " '{$migration->name}' can not be ended as its status is 'started'...");
         }
 
         $this->createTableIfNeeded();
@@ -198,13 +198,13 @@ 
         if (!is_array($existingMigrationData)) {
             // commit to release the lock
             $conn->commit();
-            throw new \Exception($this->getEntityName($migration)." '{$migration->name}' can not be ended as it is not found");
+            throw new \Exception($this->getEntityName($migration) . " '{$migration->name}' can not be ended as it is not found");
         }
 
         if (($existingMigrationData['status'] != APIMigration::STATUS_STARTED) && !$force) {
             // commit to release the lock
             $conn->commit();
-            throw new \Exception($this->getEntityName($migration)." '{$migration->name}' can not be ended as it is not executing");
+            throw new \Exception($this->getEntityName($migration) . " '{$migration->name}' can not be ended as it is not executing");
         }
 
         $conn->update(
@@ -355,7 +355,7 @@ 
         if (!is_array($existingMigrationData)) {
             // commit immediately, to release the lock and avoid deadlocks
             $conn->commit();
-            throw new \Exception($this->getEntityName($migration)." '{$migration->name}' can not be resumed as it is not found");
+            throw new \Exception($this->getEntityName($migration) . " '{$migration->name}' can not be resumed as it is not found");
         }
 
         // migration exists
@@ -364,7 +364,7 @@ 
         if ($existingMigrationData['status'] != APIMigration::STATUS_SUSPENDED) {
             // commit to release the lock
             $conn->commit();
-            throw new \Exception($this->getEntityName($migration)." '{$migration->name}' can not be resumed as it is not suspended");
+            throw new \Exception($this->getEntityName($migration) . " '{$migration->name}' can not be resumed as it is not suspended");
         }
 
         $migration = new APIMigration(

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use Kaliop\eZMigrationBundle\API\Collection\MigrationCollection;
 use Kaliop\eZMigrationBundle\API\Value\Migration as APIMigration;
 use Kaliop\eZMigrationBundle\API\Value\MigrationDefinition;
-
 use Kaliop\eZMigrationBundle\API\ConfigResolverInterface;
 
 /**