Kaliop\eZMigrationBundle\Core\Executor\ContentVersionManager

Complexity

Total Complexity

25

Size/Duplication

Total Lines	149
Duplicated Lines	35.57 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	22	22	1
A	load()	0	8	1
A	delete()	19	19	3
C	matchVersions()	12	38	13
A	getReferencesValues()	0	22	4
A	versionStatusToHash()	0	11	3

<?php

namespace Kaliop\eZMigrationBundle\Core\Executor;

use eZ\Publish\API\Repository\Values\Content\VersionInfo;
use eZ\Publish\Core\Base\Exceptions\NotFoundException;
use Kaliop\eZMigrationBundle\Core\Matcher\ContentVersionMatcher;

/**
 * Handles content-version migrations.
 * @todo disallow calling (throw): create, update, generateMigration
 */
class ContentVersionManager extends ContentManager
{
    protected $supportedStepTypes = array('content_version');
    protected $supportedActions = array('delete', 'load');

    protected $versionMatcher;

    public function __construct(

This method seems to be duplicated in your project.

        ContentMatcher $contentMatcher,
        SectionMatcher $sectionMatcher,
        UserMatcher $userMatcher,
        ObjectStateMatcher $objectStateMatcher,
        ObjectStateGroupMatcher $objectStateGroupMatcher,
        FieldHandlerManager $fieldHandlerManager,
        LocationManager $locationManager,
        SortConverter $sortConverter,
        ContentVersionMatcher $versionMatcher
    )
    {
        $this->contentMatcher = $contentMatcher;
        $this->sectionMatcher = $sectionMatcher;
        $this->userMatcher = $userMatcher;
        $this->objectStateMatcher = $objectStateMatcher;
        $this->objectStateGroupMatcher = $objectStateGroupMatcher;
        $this->fieldHandlerManager = $fieldHandlerManager;
        $this->locationManager = $locationManager;
        $this->sortConverter = $sortConverter;
        $this->versionMatcher = $versionMatcher;
    }

    protected function load($step)
    {
        $versionCollection = $this->matchVersions('load', $step);

The expression $this->matchVersions('load', $step); of type array|ArrayObject adds the type array to the return on line 49 which is incompatible with the return type of the parent method Kaliop\eZMigrationBundle\Core\Executor\ContentManager::load of type Kaliop\eZMigrationBundle\API\Collection\ContentCollection.

        $this->setReferences($versionCollection, $step);

$versionCollection is of type array|object<ArrayObject>, but the function expects a object<Object>|object<Kaliop\eZMigrationBundle\API\Collection\AbstractCollection>.

        return $versionCollection;
    }

    /**
     * Handles the content delete migration action type
     */
    protected function delete($step)

This method seems to be duplicated in your project.

    {
        $versionCollection = $this->matchVersions('delete', $step);

The expression $this->matchVersions('delete', $step); of type array|ArrayObject adds the type array to the return on line 72 which is incompatible with the return type of the parent method Kaliop\eZMigrationBundle\Core\Executor\ContentManager::delete of type Kaliop\eZMigrationBundle\API\Collection\ContentCollection.

        $this->setReferences($versionCollection, $step);

$versionCollection is of type array|object<ArrayObject>, but the function expects a object<Object>|object<Kaliop\eZMigrationBundle\API\Collection\AbstractCollection>.

        $contentService = $this->repository->getContentService();

        foreach ($versionCollection as $versionInfo) {
            try {
                $contentService->deleteVersion($versionInfo);
            } catch (NotFoundException $e) {
                // Someone else (or even us, by virtue of location tree?) removed the content which we found just a
                // second ago. We can safely ignore this
            }
        }

        return $versionCollection;
    }

    /**
     * @param string $action
     * @return ContentCollection
     * @throws \Exception
     */
    protected function matchVersions($action, $step)
    {
        if (!isset($step->dsl['object_id']) && !isset($step->dsl['remote_id']) && !isset($step->dsl['match'])) {

This code seems to be duplicated across your project.

            throw new \Exception("The id or remote id of an object or a match condition is required to $action a content version");
        }

        if (!isset($step->dsl['match_versions']) && !isset($step->dsl['versions'])) {
            throw new \Exception("A verision match condition is required to $action a content version");
        }

        // Backwards compat

        if (isset($step->dsl['match'])) {

This code seems to be duplicated across your project.

            $match = $step->dsl['match'];
        } else {
            if (isset($step->dsl['object_id'])) {
                $match = array('content_id' => $step->dsl['object_id']);
            } elseif (isset($step->dsl['remote_id'])) {
                $match = array('content_remote_id' => $step->dsl['remote_id']);
            }
        }

        if (isset($step->dsl['match_versions'])) {
            $matchVersions = $step->dsl['match_versions'];
        } else {
            $matchVersions = array(ContentVersionMatcher::MATCH_VERSION => $step->dsl['versions']);
        }

        // convert the references passed in the match
        $match = $this->resolveReferencesRecursively($match);

The variable $match does not seem to be defined for all execution paths leading up to this point.

        $matchVersions = $this->resolveReferencesRecursively($matchVersions);

        $sort = isset($step->dsl['match_sort']) ? $this->referenceResolver->resolveReference($step->dsl['match_sort']) : array();
        $offset = isset($step->dsl['match_offset']) ? $this->referenceResolver->resolveReference($step->dsl['match_offset']) : 0;
        $limit = isset($step->dsl['match_limit']) ? $this->referenceResolver->resolveReference($step->dsl['match_limit']) : 0;

        return $this->versionMatcher->match($match, $matchVersions, $sort, $offset, $limit);
    }

    /**
     * @param VersionInfo $versionInfo
     * @param array $references
     * @param $step
     * @return array
     *
     * @todo allow setting more refs: creation date, modification date, creator id, langauge codes
     */
    protected function getReferencesValues($versionInfo, array $references, $step)
    {
        $refs = array();

        foreach ($references as $reference) {
            switch ($reference['attribute']) {
                case 'version_no':
                    $value = $versionInfo->versionNo;
                    break;
                case 'version_status':
                    $value = $this->versionStatusToHash($versionInfo->status);
                    break;
                default:
                    // NB: this will generate an error if the user tries to seta  ref to a field value
                    $value = reset(parent::getReferencesValues($versionInfo, array($references), $step));

parent::getReferencesValues($versionInfo, array($references), $step) cannot be passed to reset() as the parameter $array expects a reference.

$versionInfo is of type object<eZ\Publish\API\Repository\Values\Content\VersionInfo>, but the function expects a object<eZ\Publish\API\Repository\Values\Content\Content>.

            }

            $refs[$reference['identifier']] = $value;
        }

        return $refs;
    }

    protected function versionStatusToHash($status)
    {
        foreach(ContentVersionMatcher::STATUS_MAP as $own => $ez) {
            if ($status == $ez) {
                return $own;
            }
        }

        /// @todo log warning?
        return $status;
    }
}