Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | View Code Duplication | class YamlDefinitionParser extends AbstractDefinitionParser implements DefinitionParserInterface |
|
|
|||
13 | { |
||
14 | /** |
||
15 | * Tells whether the given file can be handled by this handler, by checking e.g. the suffix |
||
16 | * |
||
17 | * @param string $migrationName typically a filename |
||
18 | * @return bool |
||
19 | */ |
||
20 | public function supports($migrationName) |
||
25 | |||
26 | /** |
||
27 | * Parses a migration definition file, and returns the list of actions to take |
||
28 | * |
||
29 | * @param MigrationDefinition $definition |
||
30 | * @return MigrationDefinition |
||
31 | */ |
||
32 | public function parseMigrationDefinition(MigrationDefinition $definition) |
||
49 | } |
||
50 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.