Passed
Push — master ( bca814...405448 )
by Gaetano
09:09 queued 17s
created
Core/Executor/RoleManager.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
     protected function sortPolicyLimitationsDefinitions(array &$limitations)
445 445
     {
446 446
         usort($limitations, function($l1, $l2) {
447
-            if (($iComp = strcmp($l1['identifier'], $l2['identifier'])) != 0 ) {
447
+            if (($iComp = strcmp($l1['identifier'], $l2['identifier'])) != 0) {
448 448
                 return $iComp;
449 449
             }
450 450
             if (is_int($l1['values']) || is_float($l1['values'])) {
@@ -473,10 +473,10 @@  discard block
 block discarded – undo
473 473
             return $this->compareArraysForSorting($p1['limitations'], $p2['limitations']);
474 474
             $p1LimIds = array();
475 475
             $p2LimIds = array();
476
-            foreach($p1['limitations'] as $lim) {
476
+            foreach ($p1['limitations'] as $lim) {
477 477
                 $p1LimIds = $lim['identifier'];
478 478
             }
479
-            foreach($p2['limitations'] as $lim) {
479
+            foreach ($p2['limitations'] as $lim) {
480 480
                 $p2LimIds = $lim['identifier'];
481 481
             }
482 482
             /// @todo if limitations identifier are the same, sort by lim. values...
Please login to merge, or discard this patch.
Core/Executor/MigrationDefinitionExecutor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 
169 169
         foreach ($dsl['references'] as $key => $reference) {
170 170
             // BC
171
-            if (is_array($reference) && isset($reference['json_path']) && !isset($reference['attribute'] )) {
171
+            if (is_array($reference) && isset($reference['json_path']) && !isset($reference['attribute'])) {
172 172
                 $reference['attribute'] = $reference['json_path'];
173 173
             }
174 174
             $reference = $this->parseReferenceDefinition($key, $reference);
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     {
198 198
         $migrationService = $this->migrationService;
199 199
         $executors = $migrationService->listExecutors();
200
-        foreach($executors as $key => $name) {
200
+        foreach ($executors as $key => $name) {
201 201
             $executor = $migrationService->getExecutor($name);
202 202
             if (!$executor instanceof MigrationGeneratorInterface) {
203 203
                 unset($executors[$key]);
Please login to merge, or discard this patch.
Core/Executor/RepositoryExecutor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 
217 217
         $multivalued = ($this->expectedResultsType($step) == self::$RESULT_TYPE_MULTIPLE);
218 218
 
219
-        if ($item instanceof AbstractCollection  || is_array($item)) {
219
+        if ($item instanceof AbstractCollection || is_array($item)) {
220 220
             $items = $item;
221 221
         } else {
222 222
             $items = array($item);
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         // allow setting *some* refs even when we have 0 or N matches
262 262
         foreach ($referencesDefinition as $key => $reference) {
263 263
             $reference = $this->parseReferenceDefinition($key, $reference);
264
-            switch($reference['attribute']) {
264
+            switch ($reference['attribute']) {
265 265
 
266 266
                 case 'count':
267 267
                     $value = count($entity);
Please login to merge, or discard this patch.
Command/MassMigrateCommand.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 
133 133
         $processes = array();
134 134
         /** @var MigrationDefinition $migrationDefinition */
135
-        foreach($paths as $path => $count) {
135
+        foreach ($paths as $path => $count) {
136 136
             $this->writeln("<info>Queueing processing of: $path ($count migrations)</info>", OutputInterface::VERBOSITY_VERBOSE);
137 137
 
138 138
             $process = $builder
@@ -179,14 +179,14 @@  discard block
 block discarded – undo
179 179
         }
180 180
 
181 181
         $missed = $total - $this->migrationsDone[Migration::STATUS_DONE] - $this->migrationsDone[Migration::STATUS_FAILED] - $this->migrationsDone[Migration::STATUS_SKIPPED];
182
-        $this->writeln("\nExecuted ".$this->migrationsDone[Migration::STATUS_DONE].' migrations'.
183
-            ', failed '.$this->migrationsDone[Migration::STATUS_FAILED].
184
-            ', skipped '.$this->migrationsDone[Migration::STATUS_SKIPPED].
182
+        $this->writeln("\nExecuted " . $this->migrationsDone[Migration::STATUS_DONE] . ' migrations' .
183
+            ', failed ' . $this->migrationsDone[Migration::STATUS_FAILED] .
184
+            ', skipped ' . $this->migrationsDone[Migration::STATUS_SKIPPED] .
185 185
             ($missed ? ", missed $missed" : ''));
186 186
 
187 187
         $time = microtime(true) - $start;
188 188
         // since we use subprocesses, we can not measure max memory used
189
-        $this->writeln("<info>Time taken: ".sprintf('%.3f', $time)." secs</info>");
189
+        $this->writeln("<info>Time taken: " . sprintf('%.3f', $time) . " secs</info>");
190 190
 
191 191
         return $subprocessesFailed + $this->migrationsDone[Migration::STATUS_FAILED] + $missed;
192 192
     }
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
         foreach ($toExecute as  $name => $migrationDefinition) {
229 229
             // let's skip migrations that we know are invalid - user was warned and he decided to proceed anyway
230 230
             if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
231
-                $this->writeln("<comment>Skipping migration (invalid definition?) Path: ".$migrationDefinition->path."</comment>", self::VERBOSITY_CHILD);
231
+                $this->writeln("<comment>Skipping migration (invalid definition?) Path: " . $migrationDefinition->path . "</comment>", self::VERBOSITY_CHILD);
232 232
                 $skipped++;
233 233
                 continue;
234 234
             }
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
                     $this->executeMigrationInProcess($migrationDefinition, $force, $migrationService, $input);
269 269
 
270 270
                     $executed++;
271
-                } catch(\Exception $e) {
271
+                } catch (\Exception $e) {
272 272
                     $failed++;
273 273
 
274 274
                     $errorMessage = $e->getMessage();
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
      * @param string $buffer
302 302
      * @param null|\Symfony\Component\Process\Process $process
303 303
      */
304
-    public function onChildProcessOutput($type, $buffer, $process=null)
304
+    public function onChildProcessOutput($type, $buffer, $process = null)
305 305
     {
306 306
         $lines = explode("\n", trim($buffer));
307 307
 
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
 
320 320
             // we tag the output with the id of the child process
321 321
             if (trim($line) !== '') {
322
-                $msg = '[' . ($process ? $process->getPid() : ''). '] ' . trim($line);
322
+                $msg = '[' . ($process ? $process->getPid() : '') . '] ' . trim($line);
323 323
                 if ($type == 'err') {
324 324
                     $this->writeErrorln($msg, OutputInterface::VERBOSITY_QUIET, OutputInterface::OUTPUT_RAW);
325 325
                 } else {
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
 
354 354
         // filter away all migrations except 'to do' ones
355 355
         $toExecute = array();
356
-        foreach($migrationDefinitions as $name => $migrationDefinition) {
356
+        foreach ($migrationDefinitions as $name => $migrationDefinition) {
357 357
             if (!isset($migrations[$name]) || (($migration = $migrations[$name]) && in_array($migration->status, $allowedStatuses))) {
358 358
                 $toExecute[$name] = $isChild ? $migrationService->parseMigrationDefinition($migrationDefinition) : $migrationDefinition;
359 359
             }
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
     {
396 396
         $output->writeln('Found ' . count($toExecute) . ' migrations in ' . count($paths) . ' directories');
397 397
         $output->writeln('In the same directories, migrations previously executed: ' . $this->migrationsAlreadyDone[Migration::STATUS_DONE] .
398
-            ', failed: ' . $this->migrationsAlreadyDone[Migration::STATUS_FAILED] . ', skipped: '. $this->migrationsAlreadyDone[Migration::STATUS_SKIPPED]);
398
+            ', failed: ' . $this->migrationsAlreadyDone[Migration::STATUS_FAILED] . ', skipped: ' . $this->migrationsAlreadyDone[Migration::STATUS_SKIPPED]);
399 399
         if ($this->migrationsAlreadyDone[Migration::STATUS_STARTED]) {
400 400
             $output->writeln('<info>In the same directories, migrations currently executing: ' . $this->migrationsAlreadyDone[Migration::STATUS_STARTED] . '</info>');
401 401
         }
@@ -408,7 +408,7 @@  discard block
 block discarded – undo
408 408
     protected function groupMigrationsByPath($toExecute)
409 409
     {
410 410
         $paths = array();
411
-        foreach($toExecute as $name => $migrationDefinition) {
411
+        foreach ($toExecute as $name => $migrationDefinition) {
412 412
             $path = dirname($migrationDefinition->path);
413 413
             if (!isset($paths[$path])) {
414 414
                 $paths[$path] = 1;
@@ -485,7 +485,7 @@  discard block
 block discarded – undo
485 485
             $builderArgs[] = '--separate-process';
486 486
         }
487 487
         if ($input->getOption('set-reference')) {
488
-            foreach($input->getOption('set-reference') as $refSpec) {
488
+            foreach ($input->getOption('set-reference') as $refSpec) {
489 489
                 $builderArgs[] = '--set-reference=' . $refSpec;
490 490
             }
491 491
         }
Please login to merge, or discard this patch.
Core/EventListener/TracingStepExecutedListener.php 1 patch
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@
 block discarded – undo
157 157
         }
158 158
 
159 159
         if ($this->output && $this->output->isVeryVerbose()) {
160
-           $out .= sprintf(". <info>Time taken: %.3f secs, memory delta: %d bytes</info>", $stepTime, $stepMemory);
160
+            $out .= sprintf(". <info>Time taken: %.3f secs, memory delta: %d bytes</info>", $stepTime, $stepMemory);
161 161
         }
162 162
 
163 163
         $this->echoMessage($out);
Please login to merge, or discard this patch.
Core/MigrationService.php 2 patches
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -599,8 +599,9 @@
 block discarded – undo
599 599
      */
600 600
     public function getCurrentContext($migrationName)
601 601
     {
602
-        if (!isset($this->migrationContext[$migrationName]))
603
-            return null;
602
+        if (!isset($this->migrationContext[$migrationName])) {
603
+                    return null;
604
+        }
604 605
         $context = $this->migrationContext[$migrationName];
605 606
         // avoid attempting to store the current outputInterface when saving the context
606 607
         if (isset($context['output'])) {
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
         }
284 284
 
285 285
         if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
286
-            throw new \Exception("Can not execute " . $this->getEntityName($migrationDefinition). " '{$migrationDefinition->name}': {$migrationDefinition->parsingError}");
286
+            throw new \Exception("Can not execute " . $this->getEntityName($migrationDefinition) . " '{$migrationDefinition->name}': {$migrationDefinition->parsingError}");
287 287
         }
288 288
 
289 289
         /// @todo add support for setting in $migrationContext a userContentType, userGroupContentType ?
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
 
318 318
         try {
319 319
 
320
-            $i = $stepOffset+1;
320
+            $i = $stepOffset + 1;
321 321
             $finalStatus = Migration::STATUS_DONE;
322 322
             $finalMessage = null;
323 323
 
@@ -454,12 +454,12 @@  discard block
 block discarded – undo
454 454
     public function resumeMigration(Migration $migration, $useTransaction = true, array $forcedReferences = array())
455 455
     {
456 456
         if ($migration->status != Migration::STATUS_SUSPENDED) {
457
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': it is not in suspended status");
457
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': it is not in suspended status");
458 458
         }
459 459
 
460 460
         $migrationDefinitions = $this->getMigrationsDefinitions(array($migration->path));
461 461
         if (!count($migrationDefinitions)) {
462
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': its definition is missing");
462
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': its definition is missing");
463 463
         }
464 464
 
465 465
         $defs = $migrationDefinitions->getArrayCopy();
@@ -467,24 +467,24 @@  discard block
 block discarded – undo
467 467
 
468 468
         $migrationDefinition = $this->parseMigrationDefinition($migrationDefinition);
469 469
         if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
470
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': {$migrationDefinition->parsingError}");
470
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': {$migrationDefinition->parsingError}");
471 471
         }
472 472
 
473 473
         // restore context
474 474
         $this->contextHandler->restoreCurrentContext($migration->name);
475 475
 
476 476
         if ($forcedReferences) {
477
-            foreach($forcedReferences as $name => $value) {
477
+            foreach ($forcedReferences as $name => $value) {
478 478
                 $this->referenceResolver->addReference($name, $value, true);
479 479
             }
480 480
         }
481 481
 
482 482
         if (!isset($this->migrationContext[$migration->name])) {
483
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': the stored context is missing");
483
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': the stored context is missing");
484 484
         }
485 485
         $restoredContext = $this->migrationContext[$migration->name];
486
-        if (!is_array($restoredContext) || !isset($restoredContext['context']) || !isset($restoredContext['step'] )) {
487
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': the stored context is invalid");
486
+        if (!is_array($restoredContext) || !isset($restoredContext['context']) || !isset($restoredContext['step'])) {
487
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': the stored context is invalid");
488 488
         }
489 489
 
490 490
         // update migration status
@@ -505,7 +505,7 @@  discard block
 block discarded – undo
505 505
      * @param bool|null $forceSigchildEnabled
506 506
      * @return array
507 507
      */
508
-    protected function migrationContextFromParameters($defaultLanguageCode = null, $adminLogin = null, $forceSigchildEnabled = null )
508
+    protected function migrationContextFromParameters($defaultLanguageCode = null, $adminLogin = null, $forceSigchildEnabled = null)
509 509
     {
510 510
         $properties = array();
511 511
 
Please login to merge, or discard this patch.
Command/StatusCommand.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 
198 198
         if ($input->getOption('todo')) {
199 199
             foreach ($data as $migrationData) {
200
-                $output->writeln("$migrationData", OutputInterface::OUTPUT_RAW|OutputInterface::VERBOSITY_QUIET);
200
+                $output->writeln("$migrationData", OutputInterface::OUTPUT_RAW | OutputInterface::VERBOSITY_QUIET);
201 201
             }
202 202
             return 0;
203 203
         }
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
226 226
      */
227 227
     protected function sortMigrationIndex(array &$index, $sortBy)
228 228
     {
229
-        switch($sortBy) {
229
+        switch ($sortBy) {
230 230
             case 'execution':
231 231
                 uasort($index, function($m1, $m2) {
232 232
                     if (isset($m1['migration']) && $m1['migration']->executionDate !== null) {
Please login to merge, or discard this patch.
Command/ResumeCommand.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         $forcedRefs = array();
98 98
         if ($input->getOption('set-reference') /*&& !$input->getOption('separate-process')*/) {
99 99
             $refResolver = $this->getContainer()->get('ez_migration_bundle.reference_resolver.customreference');
100
-            foreach($input->getOption('set-reference') as $refSpec) {
100
+            foreach ($input->getOption('set-reference') as $refSpec) {
101 101
                 $ref = explode(':', $refSpec, 2);
102 102
                 if (count($ref) < 2 || $ref[0] === '') {
103 103
                     throw new \Exception("Invalid reference specification: '$refSpec'");
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
         $executed = 0;
110 110
         $failed = 0;
111 111
 
112
-        foreach($suspendedMigrations as $suspendedMigration) {
112
+        foreach ($suspendedMigrations as $suspendedMigration) {
113 113
             $output->writeln("<info>Resuming {$suspendedMigration->name}</info>");
114 114
 
115 115
             try {
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
 
130 130
         $time = microtime(true) - $start;
131 131
         $output->writeln("Resumed $executed migrations, failed $failed");
132
-        $output->writeln("Time taken: ".sprintf('%.3f', $time)." secs, memory: ".sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)). ' MB');
132
+        $output->writeln("Time taken: " . sprintf('%.3f', $time) . " secs, memory: " . sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)) . ' MB');
133 133
 
134 134
         if ($failed) {
135 135
             return 2;
Please login to merge, or discard this patch.
Command/MigrateCommand.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 
133 133
         if ($input->getOption('set-reference') && !$input->getOption('separate-process')) {
134 134
             $refResolver = $this->getContainer()->get('ez_migration_bundle.reference_resolver.customreference');
135
-            foreach($input->getOption('set-reference') as $refSpec) {
135
+            foreach ($input->getOption('set-reference') as $refSpec) {
136 136
                 $ref = explode(':', $refSpec, 2);
137 137
                 if (count($ref) < 2 || $ref[0] === '') {
138 138
                     throw new \Exception("Invalid reference specification: '$refSpec'");
@@ -232,9 +232,9 @@  discard block
 block discarded – undo
232 232
         $time = microtime(true) - $start;
233 233
         if ($input->getOption('separate-process')) {
234 234
             // in case of using subprocesses, we can not measure max memory used
235
-            $this->writeln("<info>Time taken: ".sprintf('%.3f', $time)." secs</info>");
235
+            $this->writeln("<info>Time taken: " . sprintf('%.3f', $time) . " secs</info>");
236 236
         } else {
237
-            $this->writeln("<info>Time taken: ".sprintf('%.3f', $time)." secs, memory: ".sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)). ' MB</info>');
237
+            $this->writeln("<info>Time taken: " . sprintf('%.3f', $time) . " secs, memory: " . sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)) . ' MB</info>');
238 238
         }
239 239
 
240 240
         return $failed;
@@ -466,7 +466,7 @@  discard block
 block discarded – undo
466 466
             $builderArgs[] = '--no-debug';
467 467
         }
468 468
         if ($input->getOption('siteaccess')) {
469
-            $builderArgs[] = '--siteaccess='.$input->getOption('siteaccess');
469
+            $builderArgs[] = '--siteaccess=' . $input->getOption('siteaccess');
470 470
         }
471 471
         switch ($this->verbosity) {
472 472
             case OutputInterface::VERBOSITY_VERBOSE:
@@ -498,7 +498,7 @@  discard block
 block discarded – undo
498 498
             $builderArgs[] = '--no-transactions';
499 499
         }
500 500
         if ($input->getOption('set-reference')) {
501
-            foreach($input->getOption('set-reference') as $refSpec) {
501
+            foreach ($input->getOption('set-reference') as $refSpec) {
502 502
                 $builderArgs[] = '--set-reference=' . $refSpec;
503 503
             }
504 504
         }
Please login to merge, or discard this patch.