kaliop-uk / ezmigrationbundle

Core/Executor/ContentManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -648,7 +648,7 @@
      * @param string $contentTypeIdentifier
      * @param array $context
      * @throws \InvalidArgumentException
-     * @return mixed
+     * @return \Kaliop\eZMigrationBundle\API\Value\MigrationStep
      */
     protected function getFieldValue($value, FieldDefinition $fieldDefinition, $contentTypeIdentifier, array $context = array())
     {

Spacing +2 added lines, -2 removed lines

@@ -439,7 +439,7 @@ 
                         $hashValue = $this->fieldHandlerManager->fieldValueToHash(
                             $fieldDefinition->fieldTypeIdentifier, $contentType->identifier, $field->value
                         );
-                        if (is_array($hashValue) ) {
+                        if (is_array($hashValue)) {
                             if (count($parts) == 2 && $fieldIdentifier === $parts[1]) {
                                 throw new \InvalidArgumentException('Content Manager does not support setting references for attribute ' . $reference['attribute'] . ': the given attribute has an array value');
                             }
@@ -515,7 +515,7 @@ 
                     $locations = $locationService->loadLocations($content->contentInfo);
                     if (count($locations) > 1) {
                         $otherParentLocations = array();
-                        foreach($locations as $otherLocation) {
+                        foreach ($locations as $otherLocation) {
                             if ($otherLocation->id != $location->id) {
                                 $otherParentLocations[] = $otherLocation->parentLocationId;
                             }

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use eZ\Publish\API\Repository\Values\ContentType\ContentType;
 use eZ\Publish\API\Repository\Values\ContentType\FieldDefinition;
-use eZ\Publish\API\Repository\Values\Content\Location;
 use eZ\Publish\API\Repository\Values\Content\Content;
 use eZ\Publish\API\Repository\Values\Content\ContentCreateStruct;
 use eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct;

Core/Executor/MigrationExecutor.php

Doc Comments +2 added lines, -2 removed lines

@@ -50,7 +50,7 @@ 
     /**
      * @param array $dsl
      * @param array $context
-     * @return true
+     * @return boolean
      * @throws \Exception
      */
     protected function cancel($dsl, $context)
@@ -70,7 +70,7 @@ 
     /**
      * @param array $dsl
      * @param array $context
-     * @return true
+     * @return boolean
      * @throws \Exception
      */
     protected function suspend($dsl, $context)

Spacing +3 added lines, -3 removed lines

@@ -105,13 +105,13 @@ 
         $dsl['mode'] = 'load';
         // be kind to users and allow them not to specify this explicitly
         if (isset($dsl['references'])) {
-            foreach($dsl['references'] as &$refDef) {
+            foreach ($dsl['references'] as &$refDef) {
                 $refDef['overwrite'] = true;
             }
         }
         $step = new MigrationStep($dsl['type'], $dsl, $context);
 
-        switch($dsl['type']) {
+        switch ($dsl['type']) {
             case 'content':
                 return $this->contentManager->execute($step);
             case 'location':
@@ -139,7 +139,7 @@ 
                     return $this->matchConditions($values);
 
                 default:
-                    throw new \Exception("Unknown until condition: '$key' when suspending a migration ".var_export($conditions, true));
+                    throw new \Exception("Unknown until condition: '$key' when suspending a migration " . var_export($conditions, true));
             }
         }
     }

Core/FieldHandler/EzSelection.php

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
 
         // allow user to pass in selection values by name
         $fieldSettings = null;
-        foreach($fieldValue as $key => $val) {
+        foreach ($fieldValue as $key => $val) {
             if (is_string($val)) {
                 if (ctype_digit($val)) {
                     $fieldValue[$key] = (int)$val;
@@ -43,7 +43,7 @@ 
                     if ($fieldSettings === null) {
                         $fieldSettings = $this->loadFieldSettings($context['contentTypeIdentifier'], $context['fieldIdentifier']);
                     }
-                    foreach($fieldSettings['options'] as $pos => $name) {
+                    foreach ($fieldSettings['options'] as $pos => $name) {
                         if ($name === $val) {
                             $fieldValue[$key] = $pos;
                             break;

Core/FieldHandler/FileFieldHandler.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
     protected $ioRootDir;
     protected $ioDecorator;
 
-    public function __construct($ioRootDir, UrlDecorator $ioDecorator=null)
+    public function __construct($ioRootDir, UrlDecorator $ioDecorator = null)
     {
         $this->ioRootDir = $ioRootDir;
         $this->ioDecorator = $ioDecorator;

Core/Executor/ReferenceExecutor.php

Spacing +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
             throw new \Exception("Invalid step definition: file '$fileName' for saving references already exists");
         }
 
-        if (! $this->referenceResolver instanceof EnumerableReferenceResolverInterface) {
+        if (!$this->referenceResolver instanceof EnumerableReferenceResolverInterface) {
             throw new \Exception("Can not save references as resolver is not enumerable");
         }
 

Core/ReferenceResolver/ChainResolver.php

Spacing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
         $refs = array();
 
         foreach ($this->resolvers as $resolver) {
-            if (! $resolver instanceof EnumerableReferenceResolverInterface) {
+            if (!$resolver instanceof EnumerableReferenceResolverInterface) {
                 throw new \Exception("Could not enumerate references because of chained resolver of type: " . get_class($resolver));
             }
 

Core/Matcher/ReferenceMatcher.php

Spacing +2 added lines, -2 removed lines

@@ -81,7 +81,7 @@ 
 
             switch ($key) {
                 case self::MATCH_AND:
-                    foreach($values as $subCriterion) {
+                    foreach ($values as $subCriterion) {
                         $value = $this->match($subCriterion);
                         if (!reset($value)) {
                             return $value;
@@ -90,7 +90,7 @@ 
                     return array(true);
 
                 case self::MATCH_OR:
-                    foreach($values as $subCriterion) {
+                    foreach ($values as $subCriterion) {
                         $value = $this->match($subCriterion);
                         if (reset($value)) {
                             return $value;

Core/Matcher/QueryBasedMatcher.php

Spacing +6 added lines, -6 removed lines

@@ -128,7 +128,7 @@ 
                 return new Query\Criterion\DateMetadata(Query\Criterion\DateMetadata::CREATED, self::$operatorsMap[$operator], $match);
 
             case self::MATCH_GROUP:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->groupMatcher->matchOneByKey($value)->id;
                     }
@@ -144,7 +144,7 @@ 
                 return new Query\Criterion\DateMetadata(Query\Criterion\DateMetadata::MODIFIED, self::$operatorsMap[$operator], $match);
 
             case self::MATCH_OBJECT_STATE:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->stateMatcher->matchOneByKey($value)->id;
                     }
@@ -152,7 +152,7 @@ 
                 return new Query\Criterion\ObjectStateId($values);
 
             case self::MATCH_OWNER:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->userMatcher->matchOneByKey($value)->id;
                     }
@@ -172,7 +172,7 @@ 
                 return new Query\Criterion\ParentLocationId($locationIds);
 
             case self::MATCH_SECTION:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->sectionMatcher->matchOneByKey($value)->id;
                     }
@@ -193,7 +193,7 @@ 
 
             case self::MATCH_AND:
                 $subCriteria = array();
-                foreach($values as $subCriterion) {
+                foreach ($values as $subCriterion) {
                     $value = reset($subCriterion);
                     $subCriteria[] = $this->getQueryCriterion(key($subCriterion), $value);
                 }
@@ -201,7 +201,7 @@ 
 
             case self::MATCH_OR:
                 $subCriteria = array();
-                foreach($values as $subCriterion) {
+                foreach ($values as $subCriterion) {
                     $value = reset($subCriterion);
                     $subCriteria[] = $this->getQueryCriterion(key($subCriterion), $value);
                 }

Core/ContextHandler.php

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
     public function storeCurrentContext($migrationName)
     {
         $context = array();
-        foreach($this->providers as $label => $provider) {
+        foreach ($this->providers as $label => $provider) {
             $context[$label] = $provider->getCurrentContext($migrationName);
         }
 
@@ -52,7 +52,7 @@ 
         if (!is_array($context)) {
             throw new \Exception("No execution context found associated with migration '$migrationName'");
         }
-        foreach($this->providers as $label => $provider) {
+        foreach ($this->providers as $label => $provider) {
             if (isset($context[$label])) {
                 $provider->restoreContext($migrationName, $context[$label]);
             }