Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 7 | class LocationMatcherDirectLoad extends LocationMatcher |
||
| 8 | { |
||
| 9 | /** |
||
| 10 | * Override the parent's implementation to use the repository instead of the Search Service to load Locations when |
||
| 11 | * specified by Id or RemoteId. |
||
| 12 | * This has the advantage of not going through Solr, and hence having less problems with transactions and indexation delay. |
||
| 13 | * |
||
| 14 | * @param array $conditions |
||
| 15 | * @return LocationCollection |
||
| 16 | */ |
||
| 17 | View Code Duplication | public function matchLocation(array $conditions) |
|
| 40 | } |
||
| 41 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.