Passed
Push — master ( 2c5004...a710dc )
by Gaetano
07:33
created
Core/StorageHandler/Database/TableStorage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
      */
54 54
     protected function injectTableCreationOptions(Table $table)
55 55
     {
56
-        foreach($this->tableCreationOptions as $key => $value) {
56
+        foreach ($this->tableCreationOptions as $key => $value) {
57 57
             $table->addOption($key, $value);
58 58
         }
59 59
     }
Please login to merge, or discard this patch.
Core/Executor/AbstractExecutor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
         if (is_string($key) && is_string($value)) {
47 47
             return array('identifier' => $key, 'attribute' => $value);
48 48
         }
49
-        if (!is_array($value) || !isset($value['identifier']) || ! isset($value['attribute'])) {
49
+        if (!is_array($value) || !isset($value['identifier']) || !isset($value['attribute'])) {
50 50
             throw new InvalidStepDefinitionException("Invalid reference definition for reference number $key");
51 51
         }
52 52
         return $value;
Please login to merge, or discard this patch.
Core/Executor/NonScalarReferenceSetterTrait.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
         // q2: why not just check for Countable interface instead of AbstractCollection? Or at least allow ArrayIterators and ObjectIterators
38 38
         if (is_array($results) || $results instanceof AbstractCollection) {
39 39
             $expectedResultsCount = $this->expectedResultsCount($step);
40
-            switch($expectedResultsCount) {
40
+            switch ($expectedResultsCount) {
41 41
                 case self::$EXPECT_UNSPECIFIED:
42 42
                 case self::$EXPECT_ANY:
43 43
                     break;
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
      */
63 63
     protected function expectedResultsType($step)
64 64
     {
65
-        switch($this->expectedResultsCount($step)) {
65
+        switch ($this->expectedResultsCount($step)) {
66 66
             case 1:
67 67
                 return self::$RESULT_TYPE_SINGLE;
68 68
             case 0:
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
 
105 105
         // BC
106 106
         if (isset($step->dsl['references_type'])) {
107
-            switch($step->dsl['references_type']) {
107
+            switch ($step->dsl['references_type']) {
108 108
                 case 'array':
109 109
                     return self::$EXPECT_ANY;
110 110
                 case 'scalar':
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
      */
131 131
     protected function hasNonScalarReferences($referencesDefinition)
132 132
     {
133
-        foreach($referencesDefinition as $key => $referenceDefinition) {
133
+        foreach ($referencesDefinition as $key => $referenceDefinition) {
134 134
             $referenceDefinition = $this->parseReferenceDefinition($key, $referenceDefinition);
135 135
             if (!$this->isScalarReference($referenceDefinition))
136 136
             {
Please login to merge, or discard this patch.
Core/Executor/RoleManager.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
     protected function sortPolicyLimitationsDefinitions(array &$limitations)
445 445
     {
446 446
         usort($limitations, function($l1, $l2) {
447
-            if (($iComp = strcmp($l1['identifier'], $l2['identifier'])) != 0 ) {
447
+            if (($iComp = strcmp($l1['identifier'], $l2['identifier'])) != 0) {
448 448
                 return $iComp;
449 449
             }
450 450
             if (is_int($l1['values']) || is_float($l1['values'])) {
@@ -473,10 +473,10 @@  discard block
 block discarded – undo
473 473
             return $this->compareArraysForSorting($p1['limitations'], $p2['limitations']);
474 474
             $p1LimIds = array();
475 475
             $p2LimIds = array();
476
-            foreach($p1['limitations'] as $lim) {
476
+            foreach ($p1['limitations'] as $lim) {
477 477
                 $p1LimIds = $lim['identifier'];
478 478
             }
479
-            foreach($p2['limitations'] as $lim) {
479
+            foreach ($p2['limitations'] as $lim) {
480 480
                 $p2LimIds = $lim['identifier'];
481 481
             }
482 482
             /// @todo if limitations identifier are the same, sort by lim. values...
Please login to merge, or discard this patch.
Core/Executor/MigrationDefinitionExecutor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
 
169 169
         foreach ($dsl['references'] as $key => $reference) {
170 170
             // BC
171
-            if (is_array($reference) && isset($reference['json_path']) && !isset($reference['attribute'] )) {
171
+            if (is_array($reference) && isset($reference['json_path']) && !isset($reference['attribute'])) {
172 172
                 $reference['attribute'] = $reference['json_path'];
173 173
             }
174 174
             $reference = $this->parseReferenceDefinition($key, $reference);
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
     {
198 198
         $migrationService = $this->migrationService;
199 199
         $executors = $migrationService->listExecutors();
200
-        foreach($executors as $key => $name) {
200
+        foreach ($executors as $key => $name) {
201 201
             $executor = $migrationService->getExecutor($name);
202 202
             if (!$executor instanceof MigrationGeneratorInterface) {
203 203
                 unset($executors[$key]);
Please login to merge, or discard this patch.
Core/Executor/RepositoryExecutor.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 
217 217
         $multivalued = ($this->expectedResultsType($step) == self::$RESULT_TYPE_MULTIPLE);
218 218
 
219
-        if ($item instanceof AbstractCollection  || is_array($item)) {
219
+        if ($item instanceof AbstractCollection || is_array($item)) {
220 220
             $items = $item;
221 221
         } else {
222 222
             $items = array($item);
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         // allow setting *some* refs even when we have 0 or N matches
262 262
         foreach ($referencesDefinition as $key => $reference) {
263 263
             $reference = $this->parseReferenceDefinition($key, $reference);
264
-            switch($reference['attribute']) {
264
+            switch ($reference['attribute']) {
265 265
 
266 266
                 case 'count':
267 267
                     $value = count($entity);
Please login to merge, or discard this patch.
Command/MigrateCommand.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 
133 133
         if ($input->getOption('set-reference') && !$input->getOption('separate-process')) {
134 134
             $refResolver = $this->getContainer()->get('ez_migration_bundle.reference_resolver.customreference');
135
-            foreach($input->getOption('set-reference') as $refSpec) {
135
+            foreach ($input->getOption('set-reference') as $refSpec) {
136 136
                 $ref = explode(':', $refSpec, 2);
137 137
                 if (count($ref) < 2) {
138 138
                     throw new \Exception("Invalid reference specification: '$refSpec'");
@@ -232,9 +232,9 @@  discard block
 block discarded – undo
232 232
         $time = microtime(true) - $start;
233 233
         if ($input->getOption('separate-process')) {
234 234
             // in case of using subprocesses, we can not measure max memory used
235
-            $this->writeln("<info>Time taken: ".sprintf('%.3f', $time)." secs</info>");
235
+            $this->writeln("<info>Time taken: " . sprintf('%.3f', $time) . " secs</info>");
236 236
         } else {
237
-            $this->writeln("<info>Time taken: ".sprintf('%.3f', $time)." secs, memory: ".sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)). ' MB</info>');
237
+            $this->writeln("<info>Time taken: " . sprintf('%.3f', $time) . " secs, memory: " . sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)) . ' MB</info>');
238 238
         }
239 239
 
240 240
         return $failed;
@@ -466,7 +466,7 @@  discard block
 block discarded – undo
466 466
             $builderArgs[] = '--no-debug';
467 467
         }
468 468
         if ($input->getOption('siteaccess')) {
469
-            $builderArgs[] = '--siteaccess='.$input->getOption('siteaccess');
469
+            $builderArgs[] = '--siteaccess=' . $input->getOption('siteaccess');
470 470
         }
471 471
         switch ($this->verbosity) {
472 472
             case OutputInterface::VERBOSITY_VERBOSE:
@@ -498,7 +498,7 @@  discard block
 block discarded – undo
498 498
             $builderArgs[] = '--no-transactions';
499 499
         }
500 500
         if ($input->getOption('set-reference')) {
501
-            foreach($input->getOption('set-reference') as $refSpec) {
501
+            foreach ($input->getOption('set-reference') as $refSpec) {
502 502
                 $builderArgs[] = '--set-reference=' . $refSpec;
503 503
             }
504 504
         }
Please login to merge, or discard this patch.
Command/ResumeCommand.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
         $executed = 0;
97 97
         $failed = 0;
98 98
 
99
-        foreach($suspendedMigrations as $suspendedMigration) {
99
+        foreach ($suspendedMigrations as $suspendedMigration) {
100 100
             $output->writeln("<info>Resuming {$suspendedMigration->name}</info>");
101 101
 
102 102
             try {
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
 
117 117
         $time = microtime(true) - $start;
118 118
         $output->writeln("Resumed $executed migrations, failed $failed");
119
-        $output->writeln("Time taken: ".sprintf('%.3f', $time)." secs, memory: ".sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)). ' MB');
119
+        $output->writeln("Time taken: " . sprintf('%.3f', $time) . " secs, memory: " . sprintf('%.2f', (memory_get_peak_usage(true) / 1000000)) . ' MB');
120 120
 
121 121
         if ($failed) {
122 122
             return 2;
Please login to merge, or discard this patch.
Command/MassMigrateCommand.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 
133 133
         $processes = array();
134 134
         /** @var MigrationDefinition $migrationDefinition */
135
-        foreach($paths as $path => $count) {
135
+        foreach ($paths as $path => $count) {
136 136
             $this->writeln("<info>Queueing processing of: $path ($count migrations)</info>", OutputInterface::VERBOSITY_VERBOSE);
137 137
 
138 138
             $process = $builder
@@ -179,14 +179,14 @@  discard block
 block discarded – undo
179 179
         }
180 180
 
181 181
         $missed = $total - $this->migrationsDone[Migration::STATUS_DONE] - $this->migrationsDone[Migration::STATUS_FAILED] - $this->migrationsDone[Migration::STATUS_SKIPPED];
182
-        $this->writeln("\nExecuted ".$this->migrationsDone[Migration::STATUS_DONE].' migrations'.
183
-            ', failed '.$this->migrationsDone[Migration::STATUS_FAILED].
184
-            ', skipped '.$this->migrationsDone[Migration::STATUS_SKIPPED].
182
+        $this->writeln("\nExecuted " . $this->migrationsDone[Migration::STATUS_DONE] . ' migrations' .
183
+            ', failed ' . $this->migrationsDone[Migration::STATUS_FAILED] .
184
+            ', skipped ' . $this->migrationsDone[Migration::STATUS_SKIPPED] .
185 185
             ($missed ? ", missed $missed" : ''));
186 186
 
187 187
         $time = microtime(true) - $start;
188 188
         // since we use subprocesses, we can not measure max memory used
189
-        $this->writeln("<info>Time taken: ".sprintf('%.3f', $time)." secs</info>");
189
+        $this->writeln("<info>Time taken: " . sprintf('%.3f', $time) . " secs</info>");
190 190
 
191 191
         return $subprocessesFailed + $this->migrationsDone[Migration::STATUS_FAILED] + $missed;
192 192
     }
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
         foreach ($toExecute as  $name => $migrationDefinition) {
229 229
             // let's skip migrations that we know are invalid - user was warned and he decided to proceed anyway
230 230
             if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
231
-                $this->writeln("<comment>Skipping migration (invalid definition?) Path: ".$migrationDefinition->path."</comment>", self::VERBOSITY_CHILD);
231
+                $this->writeln("<comment>Skipping migration (invalid definition?) Path: " . $migrationDefinition->path . "</comment>", self::VERBOSITY_CHILD);
232 232
                 $skipped++;
233 233
                 continue;
234 234
             }
@@ -268,7 +268,7 @@  discard block
 block discarded – undo
268 268
                     $this->executeMigrationInProcess($migrationDefinition, $force, $migrationService, $input);
269 269
 
270 270
                     $executed++;
271
-                } catch(\Exception $e) {
271
+                } catch (\Exception $e) {
272 272
                     $failed++;
273 273
 
274 274
                     $errorMessage = $e->getMessage();
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
      * @param string $buffer
302 302
      * @param null|\Symfony\Component\Process\Process $process
303 303
      */
304
-    public function onChildProcessOutput($type, $buffer, $process=null)
304
+    public function onChildProcessOutput($type, $buffer, $process = null)
305 305
     {
306 306
         $lines = explode("\n", trim($buffer));
307 307
 
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
 
320 320
             // we tag the output with the id of the child process
321 321
             if (trim($line) !== '') {
322
-                $msg = '[' . ($process ? $process->getPid() : ''). '] ' . trim($line);
322
+                $msg = '[' . ($process ? $process->getPid() : '') . '] ' . trim($line);
323 323
                 if ($type == 'err') {
324 324
                     $this->writeErrorln($msg, OutputInterface::VERBOSITY_QUIET, OutputInterface::OUTPUT_RAW);
325 325
                 } else {
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
 
354 354
         // filter away all migrations except 'to do' ones
355 355
         $toExecute = array();
356
-        foreach($migrationDefinitions as $name => $migrationDefinition) {
356
+        foreach ($migrationDefinitions as $name => $migrationDefinition) {
357 357
             if (!isset($migrations[$name]) || (($migration = $migrations[$name]) && in_array($migration->status, $allowedStatuses))) {
358 358
                 $toExecute[$name] = $isChild ? $migrationService->parseMigrationDefinition($migrationDefinition) : $migrationDefinition;
359 359
             }
@@ -395,7 +395,7 @@  discard block
 block discarded – undo
395 395
     {
396 396
         $output->writeln('Found ' . count($toExecute) . ' migrations in ' . count($paths) . ' directories');
397 397
         $output->writeln('In the same directories, migrations previously executed: ' . $this->migrationsAlreadyDone[Migration::STATUS_DONE] .
398
-            ', failed: ' . $this->migrationsAlreadyDone[Migration::STATUS_FAILED] . ', skipped: '. $this->migrationsAlreadyDone[Migration::STATUS_SKIPPED]);
398
+            ', failed: ' . $this->migrationsAlreadyDone[Migration::STATUS_FAILED] . ', skipped: ' . $this->migrationsAlreadyDone[Migration::STATUS_SKIPPED]);
399 399
         if ($this->migrationsAlreadyDone[Migration::STATUS_STARTED]) {
400 400
             $output->writeln('<info>In the same directories, migrations currently executing: ' . $this->migrationsAlreadyDone[Migration::STATUS_STARTED] . '</info>');
401 401
         }
@@ -408,7 +408,7 @@  discard block
 block discarded – undo
408 408
     protected function groupMigrationsByPath($toExecute)
409 409
     {
410 410
         $paths = array();
411
-        foreach($toExecute as $name => $migrationDefinition) {
411
+        foreach ($toExecute as $name => $migrationDefinition) {
412 412
             $path = dirname($migrationDefinition->path);
413 413
             if (!isset($paths[$path])) {
414 414
                 $paths[$path] = 1;
@@ -485,7 +485,7 @@  discard block
 block discarded – undo
485 485
             $builderArgs[] = '--separate-process';
486 486
         }
487 487
         if ($input->getOption('set-reference')) {
488
-            foreach($input->getOption('set-reference') as $refSpec) {
488
+            foreach ($input->getOption('set-reference') as $refSpec) {
489 489
                 $builderArgs[] = '--set-reference=' . $refSpec;
490 490
             }
491 491
         }
Please login to merge, or discard this patch.