Passed
Push — master ( 2c5004...a710dc )
by Gaetano
07:33
created
Core/MigrationService.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -264,7 +264,7 @@  discard block
 block discarded – undo
264 264
         }
265 265
 
266 266
         if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
267
-            throw new \Exception("Can not execute " . $this->getEntityName($migrationDefinition). " '{$migrationDefinition->name}': {$migrationDefinition->parsingError}");
267
+            throw new \Exception("Can not execute " . $this->getEntityName($migrationDefinition) . " '{$migrationDefinition->name}': {$migrationDefinition->parsingError}");
268 268
         }
269 269
 
270 270
         /// @todo add support for setting in $migrationContext a userContentType, userGroupContentType ?
@@ -298,7 +298,7 @@  discard block
 block discarded – undo
298 298
 
299 299
         try {
300 300
 
301
-            $i = $stepOffset+1;
301
+            $i = $stepOffset + 1;
302 302
             $finalStatus = Migration::STATUS_DONE;
303 303
             $finalMessage = null;
304 304
 
@@ -433,12 +433,12 @@  discard block
 block discarded – undo
433 433
     public function resumeMigration(Migration $migration, $useTransaction = true)
434 434
     {
435 435
         if ($migration->status != Migration::STATUS_SUSPENDED) {
436
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': it is not in suspended status");
436
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': it is not in suspended status");
437 437
         }
438 438
 
439 439
         $migrationDefinitions = $this->getMigrationsDefinitions(array($migration->path));
440 440
         if (!count($migrationDefinitions)) {
441
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': its definition is missing");
441
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': its definition is missing");
442 442
         }
443 443
 
444 444
         $defs = $migrationDefinitions->getArrayCopy();
@@ -446,18 +446,18 @@  discard block
 block discarded – undo
446 446
 
447 447
         $migrationDefinition = $this->parseMigrationDefinition($migrationDefinition);
448 448
         if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
449
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': {$migrationDefinition->parsingError}");
449
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': {$migrationDefinition->parsingError}");
450 450
         }
451 451
 
452 452
         // restore context
453 453
         $this->contextHandler->restoreCurrentContext($migration->name);
454 454
 
455 455
         if (!isset($this->migrationContext[$migration->name])) {
456
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': the stored context is missing");
456
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': the stored context is missing");
457 457
         }
458 458
         $restoredContext = $this->migrationContext[$migration->name];
459
-        if (!is_array($restoredContext) || !isset($restoredContext['context']) || !isset($restoredContext['step'] )) {
460
-            throw new \Exception("Can not resume ".$this->getEntityName($migration)." '{$migration->name}': the stored context is invalid");
459
+        if (!is_array($restoredContext) || !isset($restoredContext['context']) || !isset($restoredContext['step'])) {
460
+            throw new \Exception("Can not resume " . $this->getEntityName($migration) . " '{$migration->name}': the stored context is invalid");
461 461
         }
462 462
 
463 463
         // update migration status
@@ -478,7 +478,7 @@  discard block
 block discarded – undo
478 478
      * @param bool|null $forceSigchildEnabled
479 479
      * @return array
480 480
      */
481
-    protected function migrationContextFromParameters($defaultLanguageCode = null, $adminLogin = null, $forceSigchildEnabled = null )
481
+    protected function migrationContextFromParameters($defaultLanguageCode = null, $adminLogin = null, $forceSigchildEnabled = null)
482 482
     {
483 483
         $properties = array();
484 484
 
Please login to merge, or discard this patch.
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -599,8 +599,9 @@
 block discarded – undo
599 599
      */
600 600
     public function getCurrentContext($migrationName)
601 601
     {
602
-        if (!isset($this->migrationContext[$migrationName]))
603
-            return null;
602
+        if (!isset($this->migrationContext[$migrationName])) {
603
+                    return null;
604
+        }
604 605
         $context = $this->migrationContext[$migrationName];
605 606
         // avoid attempting to store the current outputInterface when saving the context
606 607
         if (isset($context['output'])) {
Please login to merge, or discard this patch.
Core/Matcher/LocationMatcher.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -87,7 +87,9 @@  discard block
 block discarded – undo
87 87
             if (!empty($sort)) {
88 88
                 $query->sortClauses = $this->getSortClauses($sort);
89 89
             }
90
-            if (isset($query->performCount)) $query->performCount = false;
90
+            if (isset($query->performCount)) {
91
+                $query->performCount = false;
92
+            }
91 93
             $query->filter = $this->getQueryCriterion($key, $values);
92 94
             $results = $this->getSearchService()->findLocations($query);
93 95
 
@@ -234,7 +236,9 @@  discard block
 block discarded – undo
234 236
     {
235 237
         $query = new LocationQuery();
236 238
         $query->limit = self::INT_MAX_16BIT;
237
-        if (isset($query->performCount)) $query->performCount = false;
239
+        if (isset($query->performCount)) {
240
+            $query->performCount = false;
241
+        }
238 242
         $query->filter = new Query\Criterion\ParentLocationId($parentLocationIds);
239 243
 
240 244
         $results = $this->getSearchService()->findLocations($query);
Please login to merge, or discard this patch.
Core/Matcher/ContentMatcher.php 1 patch
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -120,7 +120,9 @@  discard block
 block discarded – undo
120 120
                     $query = new Query();
121 121
                     $query->limit = $limit != 0 ? $limit : $this->queryLimit;
122 122
                     $query->offset = $offset;
123
-                    if (isset($query->performCount)) $query->performCount = false;
123
+                    if (isset($query->performCount)) {
124
+                        $query->performCount = false;
125
+                    }
124 126
                     $query->filter = $this->getQueryCriterion($key, $values);
125 127
                     if (!empty($sort)) {
126 128
                         $query->sortClauses = $this->getSortClauses($sort);
@@ -246,7 +248,9 @@  discard block
 block discarded – undo
246 248
     {
247 249
         $query = new Query();
248 250
         $query->limit = $this->queryLimit;
249
-        if (isset($query->performCount)) $query->performCount = false;
251
+        if (isset($query->performCount)) {
252
+            $query->performCount = false;
253
+        }
250 254
         $query->filter = new Query\Criterion\ParentLocationId($parentLocationIds);
251 255
         $results = $this->getSearchService()->findContent($query);
252 256
 
@@ -286,7 +290,9 @@  discard block
 block discarded – undo
286 290
     {
287 291
         $query = new Query();
288 292
         $query->limit = $this->queryLimit;
289
-        if (isset($query->performCount)) $query->performCount = false;
293
+        if (isset($query->performCount)) {
294
+            $query->performCount = false;
295
+        }
290 296
         $query->filter = new Query\Criterion\ContentTypeIdentifier($contentTypeIdentifiers);
291 297
         // sort objects by depth, lower to higher, so that deleting them has less chances of failure
292 298
         // NB: we only do this in eZP versions that allow depth sorting on content queries
@@ -314,7 +320,9 @@  discard block
 block discarded – undo
314 320
     {
315 321
         $query = new Query();
316 322
         $query->limit = $this->queryLimit;
317
-        if (isset($query->performCount)) $query->performCount = false;
323
+        if (isset($query->performCount)) {
324
+            $query->performCount = false;
325
+        }
318 326
         $query->filter = new Query\Criterion\ContentTypeId($contentTypeIds);
319 327
         // sort objects by depth, lower to higher, so that deleting them has less chances of failure
320 328
         // NB: we only do this in eZP versions that allow depth sorting on content queries
Please login to merge, or discard this patch.
Core/FieldHandler/EzCountry.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
             $fieldValue = array($fieldValue);
42 42
         }
43 43
         if (!$refsResolved) {
44
-            foreach($fieldValue as $key => $countryValue) {
44
+            foreach ($fieldValue as $key => $countryValue) {
45 45
                 $fieldValue[$key] = $this->referenceResolver->resolveReference($countryValue);
46 46
             }
47 47
         }
Please login to merge, or discard this patch.
Core/Matcher/RoleMatcher.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
                 $role = $this->repository->getRoleService()->loadRole($roleId);
104 104
                 $roles[$role->id] = $role;
105 105
             /// @todo should we survive as well UnauthorizedException ? It seems to be a different kind of error than non-existing roles...
106
-            } catch(NotFoundException $e) {
106
+            } catch (NotFoundException $e) {
107 107
                 if (!$tolerateMisses) {
108 108
                     throw $e;
109 109
                 }
@@ -130,7 +130,7 @@  discard block
 block discarded – undo
130 130
                 $role = $this->repository->getRoleService()->loadRoleByIdentifier($roleIdentifier);
131 131
                 $roles[$role->id] = $role;
132 132
             /// @todo should we survive as well UnauthorizedException ? It seems to be a different kind of error than non-existing roles...
133
-            } catch(NotFoundException $e) {
133
+            } catch (NotFoundException $e) {
134 134
                 if (!$tolerateMisses) {
135 135
                     throw $e;
136 136
                 }
Please login to merge, or discard this patch.
Core/Matcher/TagMatcher.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
                 // return unique contents
132 132
                 $tag = $this->tagService->loadTag($tagId);
133 133
                 $tags[$tag->id] = $tag;
134
-            } catch(NotFoundException $e) {
134
+            } catch (NotFoundException $e) {
135 135
                 if (!$tolerateMisses) {
136 136
                     throw $e;
137 137
                 }
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
                 foreach ($this->tagService->loadTagChildren($tag) as $childTag) {
161 161
                     $tags[$childTag->id] = $childTag;
162 162
                 }
163
-            } catch(NotFoundException $e) {
163
+            } catch (NotFoundException $e) {
164 164
                 if (!$tolerateMisses) {
165 165
                     throw $e;
166 166
                 }
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
             $childTags = $this->findTagsByParentTagIds(array_keys($parentTags));
189 189
             $tags = array_merge($tags, $childTags);
190 190
             $parentTags = $childTags;
191
-        } while (count( $childTags ) > 0);
191
+        } while (count($childTags) > 0);
192 192
 
193 193
         return $tags;
194 194
     }
@@ -221,7 +221,7 @@  discard block
 block discarded – undo
221 221
                 // return unique contents
222 222
                 $tag = $this->tagService->loadTagByRemoteId($tagRemoteId);
223 223
                 $tags[$tag->id] = $tag;
224
-            } catch(NotFoundException $e) {
224
+            } catch (NotFoundException $e) {
225 225
                 if (!$tolerateMisses) {
226 226
                     throw $e;
227 227
                 }
Please login to merge, or discard this patch.
Core/Matcher/UserMatcher.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -108,12 +108,12 @@  discard block
 block discarded – undo
108 108
         $users = [];
109 109
 
110 110
         foreach ($userIds as $userId) {
111
-            try{
111
+            try {
112 112
                 // return unique contents
113 113
                 $user = $this->repository->getUserService()->loadUser($userId);
114 114
 
115 115
                 $users[$user->id] = $user;
116
-            } catch(NotFoundException $e) {
116
+            } catch (NotFoundException $e) {
117 117
                 if (!$tolerateMisses) {
118 118
                     throw $e;
119 119
                 }
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
                 $user = $this->repository->getUserService()->loadUserByLogin($login);
140 140
 
141 141
                 $users[$user->id] = $user;
142
-            } catch(NotFoundException $e) {
142
+            } catch (NotFoundException $e) {
143 143
                 if (!$tolerateMisses) {
144 144
                     throw $e;
145 145
                 }
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
 
189 189
             try {
190 190
                 $group = $this->repository->getUserService()->loadUserGroup($groupId);
191
-            } catch(NotFoundException $e) {
191
+            } catch (NotFoundException $e) {
192 192
                 if ($tolerateMisses) {
193 193
                     continue;
194 194
                 } else {
Please login to merge, or discard this patch.
Core/Matcher/ObjectStateGroupMatcher.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@
 block discarded – undo
100 100
                 // return unique contents
101 101
                 $objectStateGroup = $this->repository->getObjectStateService()->loadObjectStateGroup($objectStateGroupId);
102 102
                 $objectStateGroups[$objectStateGroup->id] = $objectStateGroup;
103
-            } catch(NotFoundException $e) {
103
+            } catch (NotFoundException $e) {
104 104
                 if (!$tolerateMisses) {
105 105
                     throw $e;
106 106
                 }
Please login to merge, or discard this patch.
Core/Matcher/LocationMatcherDirectLoad.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -36,11 +36,11 @@  discard block
 block discarded – undo
36 36
             $locations = array();
37 37
             switch ($key) {
38 38
                 case self::MATCH_LOCATION_ID:
39
-                    foreach($match as $locationId) {
39
+                    foreach ($match as $locationId) {
40 40
                         try {
41 41
                             $location = $this->repository->getLocationService()->loadLocation($locationId);
42 42
                             $locations[$location->id] = $location;
43
-                        } catch(NotFoundException $e) {
43
+                        } catch (NotFoundException $e) {
44 44
                             if (!$tolerateMisses) {
45 45
                                 throw $e;
46 46
                             }
@@ -48,11 +48,11 @@  discard block
 block discarded – undo
48 48
                     }
49 49
                     break;
50 50
                 case self::MATCH_LOCATION_REMOTE_ID:
51
-                    foreach($match as $locationRemoteId) {
51
+                    foreach ($match as $locationRemoteId) {
52 52
                         try {
53 53
                             $location = $this->repository->getLocationService()->loadLocationByRemoteId($locationRemoteId);
54 54
                             $locations[$location->id] = $location;
55
-                        } catch(NotFoundException $e) {
55
+                        } catch (NotFoundException $e) {
56 56
                             if (!$tolerateMisses) {
57 57
                                 throw $e;
58 58
                             }
Please login to merge, or discard this patch.