kaliop-uk / ezmigrationbundle

Core/Matcher/QueryBasedMatcher.php

Doc Comments +3 added lines

@@ -308,6 +308,9 @@
         return $out;
     }
 
+    /**
+     * @return string
+     */
     protected function hash2SortOrder($value)
     {
         $sortOrder = null;

Spacing +7 added lines, -7 removed lines

@@ -146,7 +146,7 @@ 
                 return new Query\Criterion\DateMetadata(Query\Criterion\DateMetadata::CREATED, self::$operatorsMap[$operator], $match);
 
             case self::MATCH_GROUP:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->groupMatcher->matchOneByKey($value)->id;
                     }
@@ -165,7 +165,7 @@ 
                 return new Query\Criterion\DateMetadata(Query\Criterion\DateMetadata::MODIFIED, self::$operatorsMap[$operator], $match);
 
             case self::MATCH_OBJECT_STATE:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->stateMatcher->matchOneByKey($value)->id;
                     }
@@ -173,7 +173,7 @@ 
                 return new Query\Criterion\ObjectStateId($values);
 
             case self::MATCH_OWNER:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->userMatcher->matchOneByKey($value)->id;
                     }
@@ -193,7 +193,7 @@ 
                 return new Query\Criterion\ParentLocationId($locationIds);
 
             case self::MATCH_SECTION:
-                foreach($values as &$value) {
+                foreach ($values as &$value) {
                     if (!ctype_digit($value)) {
                         $value = $this->sectionMatcher->matchOneByKey($value)->id;
                     }
@@ -214,7 +214,7 @@ 
 
             case self::MATCH_AND:
                 $subCriteria = array();
-                foreach($values as $subCriterion) {
+                foreach ($values as $subCriterion) {
                     $value = reset($subCriterion);
                     $subCriteria[] = $this->getQueryCriterion(key($subCriterion), $value);
                 }
@@ -222,7 +222,7 @@ 
 
             case self::MATCH_OR:
                 $subCriteria = array();
-                foreach($values as $subCriterion) {
+                foreach ($values as $subCriterion) {
                     $value = reset($subCriterion);
                     $subCriteria[] = $this->getQueryCriterion(key($subCriterion), $value);
                 }
@@ -259,7 +259,7 @@ 
 
             $direction = $this->hash2SortOrder($sortItem['sort_order']);
 
-            switch($sortItem['sort_field']) {
+            switch ($sortItem['sort_field']) {
                 case SELF::SORT_CONTENT_ID:
                     $out[] = new SortClause\ContentId($direction);
                     break;

Core/Helper/SortConverter.php

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
     public function sortField2Hash($value)
     {
         $ref = new \ReflectionClass('eZ\Publish\API\Repository\Values\Content\Location');
-        foreach($ref->getConstants() as $key => $val) {
+        foreach ($ref->getConstants() as $key => $val) {
             if (strpos($key, 'SORT_FIELD_') === 0 && $val == $value) {
                 $out = strtolower(substr($key, 11));
                 if ($out == 'contentobject_id') {

Core/Executor/ContentVersionManager.php

Doc Comments +3 added lines

@@ -147,6 +147,9 @@
         return $refs;
     }
 
+    /**
+     * @param integer $status
+     */
     protected function versionStatusToHash($status)
     {
         foreach(ContentVersionMatcher::STATUS_MAP as $own => $ez) {

Spacing +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
 
     protected function versionStatusToHash($status)
     {
-        foreach(ContentVersionMatcher::STATUS_MAP as $own => $ez) {
+        foreach (ContentVersionMatcher::STATUS_MAP as $own => $ez) {
             if ($status == $ez) {
                 return $own;
             }

Core/Matcher/ContentVersionMatcher.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use eZ\Publish\API\Repository\Repository;
 use eZ\Publish\API\Repository\Values\Content\Content;
 use \eZ\Publish\API\Repository\Values\Content\VersionInfo;
-use eZ\Publish\Core\Base\Exceptions\NotFoundException;
 use Kaliop\eZMigrationBundle\API\MatcherInterface;
 use Kaliop\eZMigrationBundle\API\Collection\VersionInfoCollection;
 

Spacing +6 added lines, -6 removed lines

@@ -45,7 +45,7 @@ 
         $versions = array();
 
         $contentCollection = $this->contentMatcher->match($contentConditions, $sort, $offset, $limit);
-        foreach($contentCollection as $content) {
+        foreach ($contentCollection as $content) {
             $versions = array_merge($versions, $this->matchContentVersions($versionConditions, $content));
         }
 
@@ -151,7 +151,7 @@ 
     {
         $versions = array();
         foreach ($this->findAllContentVersions($content) as $versionKey => $versionInfo) {
-            foreach($values as $acceptedStatus) {
+            foreach ($values as $acceptedStatus) {
                 if ($versionInfo->status == self::STATUS_MAP[$acceptedStatus]) {
                     $versions[$versionKey] = $versionInfo;
                     break;
@@ -173,15 +173,15 @@ 
         $contentVersionsCount = count($contentVersions);
         $i = 0;
         foreach ($contentVersions as $versionKey => $versionInfo) {
-            foreach($values as $acceptedVersionNo) {
-                if ($acceptedVersionNo > 0 ) {
+            foreach ($values as $acceptedVersionNo) {
+                if ($acceptedVersionNo > 0) {
                     if ($acceptedVersionNo == $versionInfo->versionNo) {
                         $versions[$versionKey] = $versionInfo;
                         break;
                     }
                 } else {
                     // negative $acceptedVersionNo means 'leave the last X versions', eg: -1 = leave the last version
-                    if ($i < $contentVersionsCount + $acceptedVersionNo)  {
+                    if ($i < $contentVersionsCount + $acceptedVersionNo) {
                         $versions[$versionKey] = $versionInfo;
                         break;
 
@@ -202,7 +202,7 @@ 
         $contentVersions = $this->repository->getContentService()->loadVersions($content->contentInfo);
         // different eZ kernels apparently sort versions in different order...
         $sortedVersions = array();
-        foreach($contentVersions as $versionInfo) {
+        foreach ($contentVersions as $versionInfo) {
             $sortedVersions[$content->contentInfo->id . '/' . $versionInfo->versionNo] = $versionInfo;
         }
         ksort($sortedVersions);

Doc Comments +7 added lines, -1 removed lines

@@ -55,7 +55,7 @@ 
     /**
      * Like match, but will throw an exception if there are 0 or more than 1 items matching
      *
-     * @param array $conditions
+     * @param array $contentConditions
      * @return mixed
      * @throws \Exception
      */
@@ -107,6 +107,9 @@ 
         }
     }
 
+    /**
+     * @param Content $content
+     */
     protected function matchAnd(array $conditionsArray, $content = null)
     {
         /// @todo introduce proper re-validation of all child conditions
@@ -130,6 +133,9 @@ 
         return $results;
     }
 
+    /**
+     * @param Content $content
+     */
     protected function matchOr(array $conditionsArray, $content = null)
     {
         /// @todo introduce proper re-validation of all child conditions