MassMigrateCommand::configure() - Code Metrics - Inspection of "fix travis" - kaliop-uk/ezmigrationbundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 2b894b...836484 )

by Gaetano
created 2018-05-04 10:56 UTC
MassMigrateCommand::configure() A

↳ Parent: MassMigrateCommand
Complexity

Conditions	1
Paths	1
Size

Total Lines	20
Code Lines	10
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	2
Importance

Changes
Metric	Value
dl	0
loc	20
ccs	0
cts	19
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	0
crap	2
<?php

namespace Kaliop\eZMigrationBundle\Command;

use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\Output;
use Symfony\Component\Console\Output\OutputInterface;
use Kaliop\eZMigrationBundle\API\Value\Migration;
use Kaliop\eZMigrationBundle\API\Value\MigrationDefinition;
use Symfony\Component\Process\ProcessBuilder;
use Symfony\Component\Process\PhpExecutableFinder;
use Kaliop\eZMigrationBundle\Core\Helper\ProcessManager;
use Symfony\Component\Console\Question\ConfirmationQuestion;

class MassMigrateCommand extends MigrateCommand
{
    const COMMAND_NAME = 'kaliop:migration:mass_migrate';

    protected $migrationsDone = array(0, 0, 0);
    protected $migrationsAlreadyDone = array();

    /**
     * @todo (!important) can we rename the option --separate-process ?
     */
    protected function configure()
    {
        parent::configure();

        $this
            ->setName(self::COMMAND_NAME)
            ->setAliases(array())
            ->setDescription('Executes available migration definitions, using parallelism.')
            ->addOption('concurrency', 'r', InputOption::VALUE_REQUIRED, "The number of executors to run in parallel", 2)
            ->setHelp(<<<EOT
This command is designed to scan recursively a directory for migration files and execute them all in parallel.
One child process will be spawned for each subdirectory found.
The maximum number of processes to run in parallel is specified via the 'concurrency' option.
<info>NB: this command does not guarantee that any given migration will be executed before another. Take care about dependencies.</info>
<info>NB: the rule that each migration filename has to be unique still applies, even if migrations are spread across different directories.</info>
Unlike for the 'normal' migration command, it is not recommended to use the <info>--separate-process</info> option, as it will make execution much slower
EOT
            )
        ;
    }

    /**
     * Execute the command.
     *
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return null|int null or 0 if everything went fine, or an error code
     */
    protected function execute(InputInterface $input, OutputInterface $output)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $start = microtime(true);

        $this->setOutput($output);
        $this->setVerbosity($output->getVerbosity());

        $isChild = $input->getOption('child');

        if ($isChild) {
            $this->setVerbosity(self::VERBOSITY_CHILD);
        }

        $this->getContainer()->get('ez_migration_bundle.step_executed_listener.tracing')->setOutput($output);

        // q: is it worth declaring a new, dedicated migration service ?
        $migrationService = $this->getMigrationService();
        $migrationService->setLoader($this->getContainer()->get('ez_migration_bundle.loader.filesystem_recursive'));

        $toExecute = $this->buildMigrationsList($input->getOption('path'), $migrationService, $isChild);

        if (!count($toExecute)) {
            $this->writeln('<info>No migrations to execute</info>');
            return 0;
        }

        if (!$isChild) {

            $paths = $this->groupMigrationsByPath($toExecute);
            $this->printMigrationsList($toExecute, $input, $output, $paths);

            // ask user for confirmation to make changes
            if (!$this->askForConfirmation($input, $output)) {
                return 0;
            }

            $concurrency = $input->getOption('concurrency');
            $this->writeln("Executing migrations using ".count($paths)." processes with a concurrency of $concurrency");

            $kernel = $this->getContainer()->get('kernel');
            $builder = new ProcessBuilder();
            $executableFinder = new PhpExecutableFinder();
            if (false !== ($php = $executableFinder->find())) {
                $builder->setPrefix($php);
            }
            // mandatory args and options
            $builderArgs = array(
                $_SERVER['argv'][0], // sf console
                self::COMMAND_NAME, // name of sf command. Can we get it from the Application instead of hardcoding?
                '--env=' . $kernel-> getEnvironment(), // sf env
                '--child'
            );
            // 'optional' options
            // note: options 'clear-cache' we never propagate
            if (!$kernel->isDebug()) {
                $builderArgs[] = '--no-debug';
            }
            if ($input->getOption('default-language')) {
                $builderArgs[]='--default-language='.$input->getOption('default-language');
            }
            if ($input->getOption('no-transactions')) {
                $builderArgs[]='--no-transactions';
            }
            if ($input->getOption('siteaccess')) {
                $builderArgs[]='--siteaccess='.$input->getOption('siteaccess');
            }
            if ($input->getOption('ignore-failures')) {
                $builderArgs[]='--ignore-failures';
            }
            if ($input->getOption('separate-process')) {
                $builderArgs[]='--separate-process';
            }
            $processes = array();
            /** @var MigrationDefinition $migrationDefinition */
            foreach($paths as $path => $count) {
                $this->writeln("<info>Queueing processing of: $path ($count migrations)</info>", OutputInterface::VERBOSITY_VERBOSE);

                $process = $builder
                    ->setArguments(array_merge($builderArgs, array('--path=' . $path)))
                    ->getProcess();

                $this->writeln('<info>Command: ' . $process->getCommandLine() . '</info>', OutputInterface::VERBOSITY_VERBOSE);

                // allow long migrations processes by default
                $process->setTimeout(86400);
                $processes[] = $process;
            }

            $this->writeln("Starting queued processes...");

            $this->migrationsDone = array(0, 0, 0);

            $processManager = new ProcessManager();
            $processManager->runParallel($processes, $concurrency, 500, array($this, 'onSubProcessOutput'));

            $failed = 0;
            foreach ($processes as $i => $process) {
                if (!$process->isSuccessful()) {
                    $output->writeln("\n<error>Subprocess $i failed! Reason: " . $process->getErrorOutput() . "</error>\n");
                    $failed++;
                }
            }

            if ($input->getOption('clear-cache')) {

                $command = $this->getApplication()->find('cache:clear');
                $inputArray = new ArrayInput(array('command' => 'cache:clear'));
                $command->run($inputArray, $output);
            }

            $time = microtime(true) - $start;

            $this->writeln('<info>'.$this->migrationsDone[0].' migrations executed, '.$this->migrationsDone[1].' failed, '.$this->migrationsDone[2].' skipped</info>');
            $this->writeln("<info>Import finished</info>\n");

            // since we use subprocesses, we can not measure max memory used
            $this->writeln("Time taken: ".sprintf('%.2f', $time)." secs");

            return $failed;

        } else {

            // @todo disable signal slots that are harmful during migrations, if any

            if ($input->getOption('separate-process')) {
                $builder = new ProcessBuilder();
                $executableFinder = new PhpExecutableFinder();
                if (false !== $php = $executableFinder->find()) {
                    $builder->setPrefix($php);
                }
                // mandatory args and options
                $builderArgs = array(
                    $_SERVER['argv'][0], // sf console
                    MigrateCommand::COMMAND_NAME, // name of sf command
                    '--env=' . $this->getContainer()->get('kernel')->getEnvironment(), // sf env
                    '--child'
                );
                // 'optional' options
                // note: options 'clear-cache', 'ignore-failures' and 'no-transactions' we never propagate
                if ($input->getOption('default-language')) {
                    $builderArgs[] = '--default-language=' . $input->getOption('default-language');
                }
                if ($input->getOption('no-transactions')) {
                    $builderArgs[] = '--no-transactions';
                }
            }

            $failed = 0;
            $executed = 0;
            $skipped = 0;
            $total = count($toExecute);

            foreach ($toExecute as  $name => $migrationDefinition) {
                // let's skip migrations that we know are invalid - user was warned and he decided to proceed anyway
                if ($migrationDefinition->status == MigrationDefinition::STATUS_INVALID) {
                    $this->writeln("<comment>Skipping migration (invalid definition?) Path: ".$migrationDefinition->path."</comment>", self::VERBOSITY_CHILD);
                    $skipped++;
                    continue;
                }

                if ($input->getOption('separate-process')) {

                    $process = $builder
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                        ->setArguments(array_merge($builderArgs, array('--path=' . $migrationDefinition->path)))
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                        ->getProcess();

                    // allow long migrations processes by default
                    $process->setTimeout(86400);
                    // and give no feedback to the user
                    $process->run(
                        function($type, $buffer) {

                            //echo $buffer;
                        }
                    );

                    try {

                        if (!$process->isSuccessful()) {
                            throw new \Exception($process->getErrorOutput());
                        }

                        // There are cases where the separate process dies halfway but does not return a non-zero code.
                        // That's why we should double-check here if the migration is still tagged as 'started'...
                        /** @var Migration $migration */
                        $migration = $migrationService->getMigration($migrationDefinition->name);

                        if (!$migration) {

                            // q: shall we add the migration to the db as failed? In doubt, we let it become a ghost, disappeared without a trace...
                            throw new \Exception("After the separate process charged to execute the migration finished, the migration can not be found in the database any more.");
                        } else if ($migration->status == Migration::STATUS_STARTED) {
                            $errorMsg = "The separate process charged to execute the migration left it in 'started' state. Most likely it died halfway through execution.";
                            $migrationService->endMigration(New Migration(
                                $migration->name,
                                $migration->md5,
                                $migration->path,
                                $migration->executionDate,
                                Migration::STATUS_FAILED,
                                ($migration->executionError != '' ? ($errorMsg . ' ' . $migration->executionError) : $errorMsg)
                            ));
                            throw new \Exception($errorMsg);
                        }

                        $executed++;

                    } catch (\Exception $e) {
                        if ($input->getOption('ignore-failures')) {
                            $output->writeln("\n<error>Migration failed! Reason: " . $e->getMessage() . "</error>\n");
                            $failed++;
                            continue;
                        }
                        $output->writeln("\n<error>Migration aborted! Path: " . $migrationDefinition->path . ", Reason: " . $e->getMessage() . "</error>");

                        $missed = $total - $executed - $failed - $skipped;
                        $this->writeln("Migrations executed: $executed, failed: $failed, skipped: $skipped, to do: $missed");

                        return 1;
                    }

                } else {

                    try {

                        $migrationService->executeMigration(
                            $migrationDefinition,
                            !$input->getOption('no-transactions'),
                            $input->getOption('default-language')
                        );

                        $executed++;
                    } catch(\Exception $e) {
                        $failed++;
                        if ($input->getOption('ignore-failures')) {
                            $this->writeln("<error>Migration failed! Path: " . $migrationDefinition->path . ", Reason: " . $e->getMessage() . "</error>", self::VERBOSITY_CHILD);
                            continue;
                        }

                        $this->writeln("<error>Migration aborted! Path: " . $migrationDefinition->path . ", Reason: " . $e->getMessage() . "</error>", self::VERBOSITY_CHILD);

                        $missed = $total - $executed - $failed - $skipped;
                        $this->writeln("Migrations executed: $executed, failed: $failed, skipped: $skipped, to do: $missed");

                        return 1;
                    }

                }
            }

            $this->writeln("Migrations executed: $executed, failed: $failed, skipped: $skipped", self::VERBOSITY_CHILD);

            // We do not return an error code > 0 if migrations fail, but only on proper fatals.
            // The parent will analyze the output of the child process to gather the number of executed/failed migrations anyway
            //return $failed;
        }
    }

    public function onSubProcessOutput($type, $buffer, $process=null)
    {
        $lines = explode("\n", trim($buffer));

        foreach ($lines as $line) {
            if (preg_match('/Migrations executed: ([0-9]+), failed: ([0-9]+), skipped: ([0-9]+)/', $line, $matches)) {
                $this->migrationsDone[0] += $matches[1];
                $this->migrationsDone[1] += $matches[2];
                $this->migrationsDone[2] += $matches[3];

                // swallow these lines unless we are in verbose mode
                if ($this->verbosity <= Output::VERBOSITY_NORMAL) {
                    return;
                }
            }

            // we tag the output from the different processes
            if (trim($line) !== '') {
                echo '[' . ($process ? $process->getPid() : ''). '] ' . trim($line) . "\n";
            }
        }
    }

    /**
     * @param string $paths
     * @param $migrationService
     * @param bool $isChild when not in child mode, do not waste time parsing migrations
     * @return MigrationDefinition[] parsed or unparsed, depending on
     *
     * @todo this does not scale well with many definitions or migrations
     */
    protected function buildMigrationsList($paths, $migrationService, $isChild = false)
    {
        $migrationDefinitions = $migrationService->getMigrationsDefinitions($paths);
        $migrations = $migrationService->getMigrations();

        $this->migrationsAlreadyDone = array(Migration::STATUS_DONE => 0, Migration::STATUS_FAILED => 0, Migration::STATUS_SKIPPED => 0, Migration::STATUS_STARTED => 0);

        // filter away all migrations except 'to do' ones
        $toExecute = array();
        foreach($migrationDefinitions as $name => $migrationDefinition) {
            if (!isset($migrations[$name]) || (($migration = $migrations[$name]) && $migration->status == Migration::STATUS_TODO)) {

                $toExecute[$name] = $isChild ? $migrationService->parseMigrationDefinition($migrationDefinition) : $migrationDefinition;
            }
            // save the list of non-executable migrations as well
            if (!$isChild && isset($migrations[$name]) && (($migration = $migrations[$name]) && $migration->status != Migration::STATUS_TODO)) {
                $this->migrationsAlreadyDone[$migration->status]++;
            }
        }

        // if user wants to execute 'all' migrations: look for some which are registered in the database even if not
        // found by the loader
        if (empty($paths)) {

            foreach ($migrations as $migration) {
                if ($migration->status == Migration::STATUS_TODO && !isset($toExecute[$migration->name])) {
                    $migrationDefinitions = $migrationService->getMigrationsDefinitions(array($migration->path));
                    if (count($migrationDefinitions)) {
                        $migrationDefinition = reset($migrationDefinitions);
                        $toExecute[$migration->name] = $isChild ? $migrationService->parseMigrationDefinition($migrationDefinition) : $migrationDefinition;
                    } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
                        // q: shall we raise a warning here ?
                    }
                }
            }
        }

        ksort($toExecute);

        return $toExecute;
    }

    /**
     * We use a more compact output when there are *many* migrations
     * @param MigrationDefinition[] $toExecute
     * @param array $paths
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function printMigrationsList($toExecute, InputInterface $input, OutputInterface $output, $paths = array())
    {
        $output->writeln('Found ' . count($toExecute) . ' migrations in ' . count($paths) . ' directories');
        $output->writeln('In the same directories, migrations previously executed: ' . $this->migrationsAlreadyDone[Migration::STATUS_DONE] .
            ', failed: ' . $this->migrationsAlreadyDone[Migration::STATUS_FAILED] . ', skipped: '. $this->migrationsAlreadyDone[Migration::STATUS_SKIPPED]);
    }

    protected function askForConfirmation(InputInterface $input, OutputInterface $output)

    {
        if ($input->isInteractive() && !$input->getOption('no-interaction')) {
            $dialog = $this->getHelperSet()->get('question');
            if (!$dialog->ask(
                $input,
                $output,
                new ConfirmationQuestion('<question>Careful, the database will be modified. Do you want to continue Y/N ?</question>', false)
            )
            ) {
                $output->writeln('<error>Migration execution cancelled!</error>');
                return 0;
            }
        } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
            // this line is not that nice in the automated scenarios used by the parallel migration
            //$this->writeln("=============================================");

        }

        return 1;
    }

    /**
     * @param MigrationDefinition[] $toExecute
     * @return array key: folder name, value: number of migrations found
     */
    protected function groupMigrationsByPath($toExecute)
    {
        $paths = array();
        foreach($toExecute as $name => $migrationDefinition) {
            $path = dirname($migrationDefinition->path);
            if (!isset($paths[$path])) {
                $paths[$path] = 1;
            } else {
                $paths[$path]++;
            }
        }

        ksort($paths);

        return $paths;
    }

}

Push — master ( 2b894b...836484 )

MassMigrateCommand::configure() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

kaliop-uk / ezmigrationbundle

Push — master ( 2b894b...836484 )

MassMigrateCommand::configure() A

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
