Kaliop\eZMigrationBundle\Core\Matcher\ReferenceMatcher

Complexity

Total Complexity

16

Size/Duplication

Total Lines	128
Duplicated Lines	12.5 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

62.5%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	validateConditions()	0	10	3
B	match()	16	42	10
A	getConstraint()	0	11	2

<?php

namespace Kaliop\eZMigrationBundle\Core\Matcher;

use eZ\Publish\API\Repository\Values\Content\Query\Criterion\Operator;
use Symfony\Component\Validator\Validator\ValidatorInterface;
use Kaliop\eZMigrationBundle\API\ReferenceResolverInterface;

/**
 * We abuse a bit the 'matcher' framework to set up a 'constraint' matcher which is used to tell whether a reference
 * matches a given condition
 */
class ReferenceMatcher extends AbstractMatcher
{
    //const MATCH_REFERENCE = 'reference';

    protected $allowedConditions = array(
        self::MATCH_AND, self::MATCH_OR, self::MATCH_NOT,
        //self::MATCH_REFERENCE
    );

    // since this is used for recursive calls as well, we have to unlock it for now
    /// @todo allow this to be set in a more flexible way
    protected $maxConditions = 0;

    protected $validator;
    /** @var ReferenceResolverInterface $referenceResolver */
    protected $referenceResolver;

    /// @todo add more operators
    static protected $operatorsMap = array(
        'eq' => '\Symfony\Component\Validator\Constraints\EqualTo',
        'gt' => '\Symfony\Component\Validator\Constraints\GreaterThan',
        'gte' => '\Symfony\Component\Validator\Constraints\GreaterThanOrEqual',
        'lt' => '\Symfony\Component\Validator\Constraints\LessThan',
        'lte' => '\Symfony\Component\Validator\Constraints\LessThanOrEqual',
        'ne' => '\Symfony\Component\Validator\Constraints\NotEqualTo',

        'count' => '\Symfony\Component\Validator\Constraints\Count',
        'length' => '\Symfony\Component\Validator\Constraints\Length',
        'regex' => '\Symfony\Component\Validator\Constraints\Regex',
        'satisfies' => '\Symfony\Component\Validator\Constraints\Expression',
        //'in' => Operator::IN,
        //'between' => Operator::BETWEEN, => use count/length with min & max sub-members
        //'like' => Operator::LIKE, => use regex
        //'contains' => Operator::CONTAINS,

        Operator::EQ => '\Symfony\Component\Validator\Constraints\EqualTo',
        Operator::GT => '\Symfony\Component\Validator\Constraints\GreaterThan',
        Operator::GTE => '\Symfony\Component\Validator\Constraints\GreaterThanOrEqual',
        Operator::LT => '\Symfony\Component\Validator\Constraints\LessThan',
        Operator::LTE => '\Symfony\Component\Validator\Constraints\LessThanOrEqual',
        '!=' => '\Symfony\Component\Validator\Constraints\NotEqualTo',
        '<>' => '\Symfony\Component\Validator\Constraints\NotEqualTo',
    );

    public function __construct(ReferenceResolverInterface $referenceResolver, ValidatorInterface $validator)
    {
        $this->referenceResolver = $referenceResolver;
        $this->validator = $validator;
    }

    // q: what if we receive an array of conditions? it seems that it might be validated here, even though only the 1st
    //    condition would be taken into account...
    protected function validateConditions(array $conditions)
    {
        foreach ($conditions as $key => $val) {
            if ($this->referenceResolver->isReference($key)) {
                return true;
            }
        }

        return parent::validateConditions($conditions);
    }

    /**
     * @param array $conditions key: condition, value: int / string / int[] / string[]
     * @return array 1 element with the value true/false
     */
    public function match(array $conditions)
    {
        $this->validateConditions($conditions);

        foreach ($conditions as $key => $values) {

            switch ($key) {
                case self::MATCH_AND:

This code seems to be duplicated across your project.

                    foreach($values as $subCriterion) {
                        $value = $this->match($subCriterion);
                        if (!reset($value)) {
                            return $value;
                        }
                    }
                    return array(true);

                case self::MATCH_OR:

This code seems to be duplicated across your project.

                    foreach($values as $subCriterion) {
                        $value = $this->match($subCriterion);
                        if (reset($value)) {
                            return $value;
                        }
                    }
                    return array(false);

                case self::MATCH_NOT:
                    return array(!reset($this->match($values)));

$this->match($values) cannot be passed to reset() as the parameter $array expects a reference.

                default:
                    // we assume that all are refs because of the call to validate()
                    $currentValue = $this->referenceResolver->resolveReference($key);
                    $targetValue = reset($values);
                    // q: what about resolving refs in teh target value, too ?
                    $constraint = key($values);
                    $errorList = $this->validator->validate($currentValue, $this->getConstraint($constraint, $targetValue));
                    if (0 === count($errorList)) {
                        return array(true);
                    }
                    return array(false);
            }
        }
    }

    /**
     * @param string $constraint
     * @param $targetValue
     * @return mixed
     * @throws \Exception for unsupported keys
     */
    protected function getConstraint($constraint, $targetValue)
    {
        if (!isset(self::$operatorsMap[$constraint])) {
            throw new \Exception("Matching condition '$constraint' is not supported. Supported conditions are: " .
                implode(', ', array_keys(self::$operatorsMap))
            );
        }

        $class = self::$operatorsMap[$constraint];
        return new $class($targetValue);
    }
}