Kaliop\eZMigrationBundle\Core\Executor\ContentVersionManager

Complexity

Total Complexity

8

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

95.45%

Importance

Changes	2
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
C	delete()	0	40	8

<?php

namespace Kaliop\eZMigrationBundle\Core\Executor;

use eZ\Publish\Core\Base\Exceptions\NotFoundException;

/**
 * Handles content-version migrations.
 */
class ContentVersionManager extends ContentManager
{
    protected $supportedStepTypes = array('content_version');
    protected $supportedActions = array('delete');

    /**
     * Handles the content delete migration action type
     */
    protected function delete($step)
    {
        if (!isset($step->dsl['versions'])) {
            throw new \Exception("The 'versions' tag is required to delete content versions");
        }

        $contentCollection = $this->matchContents('delete', $step);

        $this->setReferences($contentCollection, $step);

It seems like $contentCollection defined by $this->matchContents('delete', $step) on line 24 can be null; however, Kaliop\eZMigrationBundle\Core\Executor\ContentManager::setReferences() does not accept null, maybe add an additional type check?

        $contentService = $this->repository->getContentService();
        $versions = (array)$step->dsl['versions'];

        foreach ($contentCollection as $content) {

The expression $contentCollection of type object<Kaliop\eZMigrationBundle\API\Collection\ContentCollection>|null is not guaranteed to be traversable. How about adding an additional type check?

            foreach($versions as $versionId) {
                try {
                    if ($versionId < 0) {
                        $contentVersions = $contentService->loadVersions($content->contentInfo);
                        // different eZ kernels apparently sort versions in different order...
                        $sortedVersions = array();
                        foreach($contentVersions as $versionInfo) {
                            $sortedVersions[$versionInfo->versionNo] = $versionInfo;
                        }
                        ksort($sortedVersions);
                        $sortedVersions = array_slice($sortedVersions, 0, $versionId);
                        foreach($sortedVersions as $versionInfo) {
                            $contentService->deleteVersion($versionInfo);
                        }
                    } else {
                        $versionInfo = $contentService->loadVersionInfo($content->contentInfo, $versionId);
                        $contentService->deleteVersion($versionInfo);
                    }
                } catch (NotFoundException $e) {
                    // Someone else removed the content version. We can safely ignore this
                }
            }
        }

        return $contentCollection;
    }
}