kaliop-uk / ezmigrationbundle

Core/Executor/ContentTypeManager.php

Doc Comments +4 added lines, -1 removed lines

@@ -652,6 +652,9 @@ 
         return $fieldDefinitionUpdateStruct;
     }
 
+    /**
+     * @param string $contentTypeIdentifier
+     */
     protected function getFieldSettings($value, $fieldTypeIdentifier, $contentTypeIdentifier)
     {
         // 1st update any references in the value array
@@ -704,7 +707,7 @@ 
      *
      * @param string|array $newValue if passed a string, we will use $lang as its language. If passed an array, it will be used as is - expected format [ "eng-GB": "Name", "fre-FR": "Nom", ... ]
      * @param string $lang ex: eng-GB. Not used when $newValue is an array
-     * @param array $currentValue current set of values in all known languages. Will be merged with $newValue, $newValue taking precedence
+     * @param string[] $currentValue current set of values in all known languages. Will be merged with $newValue, $newValue taking precedence
      * @return array in the format [ "eng-GB": "Name", "fre-FR": "Nom", ... ]
      */
     protected function getMultilingualValue($newValue, $lang, $currentValue = array())

Spacing +4 added lines, -4 removed lines

@@ -249,7 +249,7 @@ 
                 }
 
                 // Add new attributes
-                foreach($newFieldDefinitions as $newFieldDefinition) {
+                foreach ($newFieldDefinitions as $newFieldDefinition) {
                     if ($newFieldDefinition->position == 0) {
                         $newFieldDefinition->position = ++$maxFieldDefinitionPos;
                     }
@@ -370,7 +370,7 @@ 
                     break;
                 case 'content_type_groups_ids':
                     $value = [];
-                    foreach($contentType->contentTypeGroups as $existingGroup) {
+                    foreach ($contentType->contentTypeGroups as $existingGroup) {
                         $value[] = $existingGroup->id;
                     }
                     break;
@@ -766,7 +766,7 @@ 
         $contentTypeGroup = $this->contentTypeGroupMatcher->matchOneByKey($contentTypeGroupId);
         $contentTypeGroupId = $contentTypeGroup->id;
 
-        foreach($contentType->contentTypeGroups as $existingGroup) {
+        foreach ($contentType->contentTypeGroups as $existingGroup) {
             if ($existingGroup->id === $contentTypeGroupId) {
                 return;
             }
@@ -782,7 +782,7 @@ 
         $contentTypeGroup = $this->contentTypeGroupMatcher->matchOneByKey($contentTypeGroupId);
         $contentTypeGroupId = $contentTypeGroup->id;
 
-        foreach($contentType->contentTypeGroups as $existingGroup) {
+        foreach ($contentType->contentTypeGroups as $existingGroup) {
             if ($existingGroup->id === $contentTypeGroupId) {
                 $contentTypeService = $this->repository->getContentTypeService();
                 $contentTypeService->unassignContentTypeGroup($contentType, $contentTypeGroup);

Core/Executor/ContentManager.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use eZ\Publish\API\Repository\Values\ContentType\ContentType;
 use eZ\Publish\API\Repository\Values\ContentType\FieldDefinition;
-use eZ\Publish\API\Repository\Values\Content\Location;
 use eZ\Publish\API\Repository\Values\Content\Content;
 use eZ\Publish\API\Repository\Values\Content\ContentCreateStruct;
 use eZ\Publish\API\Repository\Values\Content\ContentUpdateStruct;

Spacing +2 added lines, -2 removed lines

@@ -520,7 +520,7 @@ 
                     $locations = $locationService->loadLocations($content->contentInfo);
                     if (count($locations) > 1) {
                         $otherParentLocations = array();
-                        foreach($locations as $otherLocation) {
+                        foreach ($locations as $otherLocation) {
                             if ($otherLocation->id != $location->id) {
                                 $otherParentLocations[] = $otherLocation->parentLocationId;
                             }
@@ -696,7 +696,7 @@ 
             },
             array_filter(
                 $this->repository->getContentLanguageService()->loadLanguages(),
-                function ($language) {
+                function($language) {
                     return $language->enabled;
                 }
             )

Core/Matcher/TrashMatcher.php

Braces +3 added lines, -1 removed lines

@@ -36,7 +36,9 @@
 
             $query = new Query();
             $query->limit = self::INT_MAX_16BIT;
-            if (isset($query->performCount)) $query->performCount = false;
+            if (isset($query->performCount)) {
+                $query->performCount = false;
+            }
             $query->filter = $this->getQueryCriterion($key, $values);
             $results = $this->repository->getTrashService()->findTrashItems($query);
 

Core/Matcher/ContentMatcherDirectLoad.php

Spacing +2 added lines, -2 removed lines

@@ -22,13 +22,13 @@
             $contents = array();
             switch ($key) {
                 case self::MATCH_CONTENT_ID:
-                    foreach($match as $contentId) {
+                    foreach ($match as $contentId) {
                         $content = $this->repository->getContentService()->loadContent($contentId);
                         $contents[$content->id] = $content;
                     }
                     break;
                 case self::MATCH_CONTENT_REMOTE_ID:
-                    foreach($match as $contentRemoteId) {
+                    foreach ($match as $contentRemoteId) {
                         $content = $this->repository->getContentService()->loadContentByRemoteId($contentRemoteId);
                         $contents[$content->id] = $content;
                     }

Core/Matcher/LocationMatcherDirectLoad.php

Spacing +2 added lines, -2 removed lines

@@ -24,13 +24,13 @@
             $locations = array();
             switch ($key) {
                 case self::MATCH_LOCATION_ID:
-                    foreach($match as $locationId) {
+                    foreach ($match as $locationId) {
                         $location = $this->repository->getLocationService()->loadLocation($locationId);
                         $locations[$location->id] = $location;
                     }
                     break;
                 case self::MATCH_LOCATION_REMOTE_ID:
-                    foreach($match as $locationRemoteId) {
+                    foreach ($match as $locationRemoteId) {
                         $location = $this->repository->getLocationService()->loadLocationByRemoteId($locationRemoteId);
                         $locations[$location->id] = $location;
                     }

Indentation -1 removed lines

@@ -15,7 +15,6 @@
      * @param array $sort
      * @param int $offset
      * @param int $limit
-
      * @return LocationCollection
      */
     public function matchLocation(array $conditions, array $sort = array(), $offset = 0, $limit = 0)

Core/Loader/FilesystemRecursive.php

Spacing +2 added lines, -2 removed lines

@@ -57,7 +57,7 @@ 
         if (empty($paths)) {
             $paths = array();
             /** @var $bundle \Symfony\Component\HttpKernel\Bundle\BundleInterface */
-            foreach($this->kernel->getBundles() as $bundle)
+            foreach ($this->kernel->getBundles() as $bundle)
             {
                 $path = $bundle->getPath() . "/" . $this->versionDirectory;
                 if (is_dir($path)) {
@@ -67,7 +67,7 @@ 
         }
 
         $definitions = array();
-        foreach($paths as $path) {
+        foreach ($paths as $path) {
             if (is_file($path)) {
                 $definitions[basename($path)] = $returnFilename ? $path : new MigrationDefinition(
                     basename($path),

Braces +1 added lines, -2 removed lines

@@ -60,8 +60,7 @@
                         }
                     }
                 }
-            }
-            else {
+            } else {
                 throw new \Exception("Path '$path' is neither a file nor directory");
             }
         }

Core/Helper/ProcessManager.php

Spacing +2 added lines, -2 removed lines

@@ -28,7 +28,7 @@ 
         $currentProcesses = array_splice($processesQueue, 0, $maxParallel);
         // start the initial stack of processes
         foreach ($currentProcesses as $process) {
-            $process->start(function ($type, $buffer) use ($callback, $process) {
+            $process->start(function($type, $buffer) use ($callback, $process) {
                 if ($callback) {
                     $callback($type, $buffer, $process);
                 }
@@ -44,7 +44,7 @@ 
                     // directly add and start new process after the previous finished
                     if (count($processesQueue) > 0) {
                         $nextProcess = array_shift($processesQueue);
-                        $nextProcess->start(function ($type, $buffer) use ($callback, $nextProcess) {
+                        $nextProcess->start(function($type, $buffer) use ($callback, $nextProcess) {
                             if ($callback) {
                                 $callback($type, $buffer, $nextProcess);
                             }

Core/Executor/ServiceExecutor.php

Spacing +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
         } else {
             $args = array();
         }
-        foreach($args as &$val) {
+        foreach ($args as &$val) {
             $val = $this->resolveReferencesRecursively($val);
         }
 

Core/Executor/FileExecutor.php

Doc Comments +4 added lines, -4 removed lines

@@ -68,7 +68,7 @@ 
     /**
      * @param array $dsl
      * @param array $context
-     * @return string
+     * @return boolean
      * @throws \Exception
      */
     protected function exists($dsl, $context)
@@ -196,7 +196,7 @@ 
     /**
      * @param array $dsl
      * @param array $context
-     * @return true
+     * @return boolean
      * @throws \Exception
      */
     protected function copy($dsl, $context)
@@ -228,7 +228,7 @@ 
     /**
      * @param array $dsl
      * @param array $context
-     * @return true
+     * @return boolean
      * @throws \Exception
      */
     protected function move($dsl, $context)
@@ -260,7 +260,7 @@ 
     /**
      * @param array $dsl
      * @param array $context
-     * @return true
+     * @return boolean
      * @throws \Exception
      */
     protected function delete($dsl, $context)