LocationManager::update() - Code Metrics - Inspection of "implements #61: Allow update remote_id for locatio..." - kaliop-uk/ezmigrationbundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#62)

unknown

created 2016-08-29 08:32 UTC

LocationManager::update() F

↳ Parent: LocationManager

Complexity

Conditions	19
Paths	512

Size

Total Lines	76
Code Lines	42

Duplication

Lines	10
Ratio	13.16 %

Importance

Changes	7
Bugs	2	Features	2

Metric	Value
cc	19
eloc	42
c	7
b	2
f	2
nc	512
nop	0
dl	10
loc	76
rs	3.2815

How to fix Long Method Complexity

<?php

namespace Kaliop\eZMigrationBundle\Core\Executor;

use eZ\Publish\API\Repository\Values\Content\Location;
use Kaliop\eZMigrationBundle\API\Collection\ContentCollection;
use Kaliop\eZMigrationBundle\API\Collection\LocationCollection;
use Kaliop\eZMigrationBundle\Core\Matcher\ContentMatcher;

class LocationManager extends RepositoryExecutor
{
    protected $supportedStepTypes = array('location');

    protected $contentMatcher;

    public function __construct(ContentMatcher $contentMatcher)
    {
        $this->contentMatcher = $contentMatcher;
    }

    /**
     * Method to handle the create operation of the migration instructions
     */
    protected function create()
    {
        $locationService = $this->repository->getLocationService();

        if (!isset($this->dsl['parent_location_id'])) {
            throw new \Exception('Missing parent location id. This is required to create the new location.');
        }
        if (!is_array($this->dsl['parent_location_id'])) {
            $this->dsl['parent_location_id'] = array($this->dsl['parent_location_id']);
        }
        foreach ($this->dsl['parent_location_id'] as $id => $parentLocationId) {
            if ($this->referenceResolver->isReference($parentLocationId)) {
                $this->dsl['parent_location_id'][$id] = $this->referenceResolver->getReferenceValue($parentLocationId);
            }
        }

        $contentCollection = $this->matchContents('create');

        $locations = null;
        foreach ($contentCollection as $content) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $contentInfo = $content->contentInfo;

            foreach ($this->dsl['parent_location_id'] as $parentLocationId) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $locationCreateStruct = $locationService->newLocationCreateStruct($parentLocationId);

                $locationCreateStruct->hidden = isset($this->dsl['is_hidden']) ?: false;

                if (isset($this->dsl['priority'])) {
                    $locationCreateStruct->priority = $this->dsl['priority'];

                }

                $locationCreateStruct->sortOrder = $this->getSortOrder();
                $locationCreateStruct->sortField = $this->getSortField();

                $locations[] = $locationService->createLocation($contentInfo, $locationCreateStruct);
            }
        }

        $this->setReferences(new LocationCollection($locations));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Updates basic information for a location like priority, sort field and sort order.
     * Updates the visibility of the location when needed.
     * Can move a location and its children to a new parent location or swap two locations.
     *
     * @todo add support for flexible matchers
     */
    protected function update()
    {
        $locationService = $this->repository->getLocationService();

        if (!isset($this->dsl['location_id'])) {
            throw new \Exception('No location set for update.');
        }

        if (isset($this->dsl['swap_with_location']) && isset($this->dsl['patent_location_id'])) {
            throw new \Exception('Cannot move location to a new parent and swap location with another location at the same time.');
        }

        $locationId = $this->dsl['location_id'];
        if ($this->referenceResolver->isReference($locationId)) {
            $locationId = $this->referenceResolver->getReferenceValue($locationId);
        }

        $location = $locationService->loadLocation($locationId);

        if (array_key_exists('priority', $this->dsl)
            || array_key_exists('sort_field', $this->dsl)
            || array_key_exists('sort_order', $this->dsl)
            || array_key_exists('remote_id', $this->dsl)
        ) {
            $locationUpdateStruct = $locationService->newLocationUpdateStruct();

            if (isset($this->dsl['priority'])) {
                $locationUpdateStruct->priority = $this->dsl['priority'];
            }

            if (isset($this->dsl['sort_field'])) {
                $locationUpdateStruct->sortField = $this->getSortField($location->sortField);
            }

            if (isset($this->dsl['sort_order'])) {
                $locationUpdateStruct->sortOrder = $this->getSortOrder($location->sortOrder);
            }

            if (isset($this->dsl['remote_id'])) {
                $locationUpdateStruct->remoteId = $this->dsl['remote_id'];
            }

            $locationService->updateLocation($location, $locationUpdateStruct);
        }

        // Check if visibility needs to be updated
        if (isset($this->dsl['is_hidden'])) {
            if ($this->dsl['is_hidden']) {
                $locationService->hideLocation($location);
            } else {
                $locationService->unhideLocation($location);
            }
        }

        // Move or swap location
        if (isset($this->dsl['parent_location_id'])) {
            // Move the location and all it's children to a new parent
            $parentLocationId = $this->dsl['parent_location_id'];
            if ($this->referenceResolver->isReference($parentLocationId)) {
                $parentLocationId = $this->referenceResolver->getReferenceValue($parentLocationId);
            }
            $newParentLocation = $locationService->loadLocation($parentLocationId);
            $locationService->moveSubtree($location, $newParentLocation);
        } elseif (isset($this->dsl['swap_with_location'])) {

            //Swap locations
            $swapLocationId = $this->dsl['swap_with_location'];
            if ($this->referenceResolver->isReference($swapLocationId)) {
                $swapLocationId = $this->referenceResolver->getReferenceValue($swapLocationId);
            }
            $locationToSwap = $locationService->loadLocation($swapLocationId);

            $locationService->swapLocation($location, $locationToSwap);
        }

        $this->setReferences($location);
    }

    /**
     * Delete locations identified by their ids.
     *
     * @todo add support for flexible matchers
     */
    protected function delete()
    {
        $locationService = $this->repository->getLocationService();

        if (!isset($this->dsl['location_id'])) {
            throw new \Exception('No location provided for deletion');
        }

        if (!is_array($this->dsl['location_id'])) {
            $this->dsl['location_id'] = array($this->dsl['location_id']);
        }

        foreach ($this->dsl['location_id'] as $locationId) {
            $location = $locationService->loadLocation($locationId);
            $locationService->deleteLocation($location);
        }
    }

    /**
     * NB: weirdly enough, it returns contents, not locations
     *
     * @param string $action
     * @return ContentCollection
     * @throws \Exception
     */
    protected function matchContents($action)

    {
        if (!isset($this->dsl['object_id']) && !isset($this->dsl['remote_id']) && !isset($this->dsl['match'])) {
            throw new \Exception("The ID or remote ID of an object or a Match Condition is required to $action a new location.");
        }

        // Backwards compat
        if (!isset($this->dsl['match'])) {
            if (isset($this->dsl['object_id'])) {
                $this->dsl['match'] = array('content_id' => $this->dsl['object_id']);
            } elseif (isset($this->dsl['remote_id'])) {
                $this->dsl['match'] = array('content_remote_id' => $this->dsl['remote_id']);
            }
        }

        $match = $this->dsl['match'];

        // convert the references passed in the match
        foreach ($match as $condition => $values) {
            if (is_array($values)) {
                foreach ($values as $position => $value) {
                    if ($this->referenceResolver->isReference($value)) {
                        $match[$condition][$position] = $this->referenceResolver->getReferenceValue($value);
                    }
                }
            } else {
                if ($this->referenceResolver->isReference($values)) {
                    $match[$condition] = $this->referenceResolver->getReferenceValue($values);
                }
            }
        }

        return $this->contentMatcher->matchContent($match);
    }

    protected function getSortField($currentValue = null)
    {
        $sortField = Location::SORT_FIELD_PUBLISHED;

        if (!is_null($currentValue)) {
            $sortField = $currentValue;
        }

        if (isset($this->dsl['sort_field'])) {
            $sortFieldId = "SORT_FIELD_" . strtoupper($this->dsl['sort_field']);

            $ref = new \ReflectionClass('eZ\Publish\API\Repository\Values\Content\Location');

            $sortField = $ref->getConstant($sortFieldId);
        }

        return $sortField;
    }

    /**
     * Get the sort order based on the current value and the value in the DSL definition.
     *
     * If no current value is set and there is no value in the DSL it will default to Location::SORT_ORDER_ASC
     *
     * @see \eZ\Publish\API\Repository\Values\Content\Location::SORT_ORDER_*
     *
     * @param int $currentValue
     * @return int
     */
    protected function getSortOrder($currentValue = null)
    {
        $sortOrder = Location::SORT_ORDER_ASC;
        if (!is_null($currentValue)) {
            $sortOrder = $currentValue;
        }

        if (isset($this->dsl['sort_order'])) {
            if (strtoupper($this->dsl['sort_order']) === 'ASC') {
                $sortOrder = Location::SORT_ORDER_ASC;
            } else {
                $sortOrder = Location::SORT_ORDER_DESC;
            }
        }

        return $sortOrder;
    }

    /**
     * Sets references to object attributes
     *
     * The Location Manager currently supports setting references to location id.
     *
     * @throws \InvalidArgumentException When trying to set a reference to an unsupported attribute.
     * @param \eZ\Publish\API\Repository\Values\Content\Location|LocationCollection $location
     * @return boolean
     */
    protected function setReferences($location)
    {
        if (!array_key_exists('references', $this->dsl)) {
            return false;
        }

        if ($location instanceof LocationCollection) {
            if (count($location) > 1) {
                throw new \InvalidArgumentException('Location Manager does not support setting references for creating/updating of multiple locations');
            }
            $location = reset($location);
        }

        foreach ($this->dsl['references'] as $reference) {
            switch ($reference['attribute']) {
                case 'location_id':
                case 'id':
                    $value = $location->id;
                    break;
                default:
                    throw new \InvalidArgumentException('Location Manager does not support setting references for attribute ' . $reference['attribute']);
            }

            $this->referenceResolver->addReference($reference['identifier'], $value);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        return true;
    }
}


1		<?php
2
3		namespace Kaliop\eZMigrationBundle\Core\Executor;
4
5		use eZ\Publish\API\Repository\Values\Content\Location;
6		use Kaliop\eZMigrationBundle\API\Collection\ContentCollection;
7		use Kaliop\eZMigrationBundle\API\Collection\LocationCollection;
8		use Kaliop\eZMigrationBundle\Core\Matcher\ContentMatcher;
9
10		class LocationManager extends RepositoryExecutor
11		{
12		protected $supportedStepTypes = array('location');
13
14		protected $contentMatcher;
15
16		public function __construct(ContentMatcher $contentMatcher)
17		{
18		$this->contentMatcher = $contentMatcher;
19		}
20
21		/**
22		* Method to handle the create operation of the migration instructions
23		*/
24		protected function create()
25		{
26		$locationService = $this->repository->getLocationService();
27
28		if (!isset($this->dsl['parent_location_id'])) {
29		throw new \Exception('Missing parent location id. This is required to create the new location.');
30		}
31		if (!is_array($this->dsl['parent_location_id'])) {
32		$this->dsl['parent_location_id'] = array($this->dsl['parent_location_id']);
33		}
34		foreach ($this->dsl['parent_location_id'] as $id => $parentLocationId) {
35		if ($this->referenceResolver->isReference($parentLocationId)) {
36		$this->dsl['parent_location_id'][$id] = $this->referenceResolver->getReferenceValue($parentLocationId);
37		}
38		}
39
40		$contentCollection = $this->matchContents('create');
41
42		$locations = null;
43		foreach ($contentCollection as $content) {
		0 ignored issues – show Bug introduced 2016-08-05 09:22 UTC by Report Bug Copy Issue Report The expression `$contentCollection` of type `object<Kaliop\eZMigratio...ContentCollection>\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
44		$contentInfo = $content->contentInfo;
45
46		foreach ($this->dsl['parent_location_id'] as $parentLocationId) {
		0 ignored issues – show Bug introduced 2016-08-05 17:20 UTC by Report Bug Copy Issue Report The expression `$this->dsl['parent_location_id']` of type `array\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
47		$locationCreateStruct = $locationService->newLocationCreateStruct($parentLocationId);
48
49		$locationCreateStruct->hidden = isset($this->dsl['is_hidden']) ?: false;
50
51		if (isset($this->dsl['priority'])) {
52		$locationCreateStruct->priority = $this->dsl['priority'];
		0 ignored issues – show Documentation Bug introduced 2016-08-05 17:20 UTC by Report Bug Copy Issue Report It seems like `$this->dsl['priority']` of type `array` is incompatible with the declared type `integer` of property `$priority`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
53		}
54
55		$locationCreateStruct->sortOrder = $this->getSortOrder();
56		$locationCreateStruct->sortField = $this->getSortField();
57
58		$locations[] = $locationService->createLocation($contentInfo, $locationCreateStruct);
59		}
60		}
61
62		$this->setReferences(new LocationCollection($locations));
		0 ignored issues – show Documentation introduced 2016-08-22 12:20 UTC by Report Bug Copy Issue Report `$locations` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63		}
64
65		/**
66		* Updates basic information for a location like priority, sort field and sort order.
67		* Updates the visibility of the location when needed.
68		* Can move a location and its children to a new parent location or swap two locations.
69		*
70		* @todo add support for flexible matchers
71		*/
72		protected function update()
73		{
74		$locationService = $this->repository->getLocationService();
75
76		if (!isset($this->dsl['location_id'])) {
77		throw new \Exception('No location set for update.');
78		}
79
80		if (isset($this->dsl['swap_with_location']) && isset($this->dsl['patent_location_id'])) {
81		throw new \Exception('Cannot move location to a new parent and swap location with another location at the same time.');
82		}
83
84		$locationId = $this->dsl['location_id'];
85		if ($this->referenceResolver->isReference($locationId)) {
86		$locationId = $this->referenceResolver->getReferenceValue($locationId);
87		}
88
89		$location = $locationService->loadLocation($locationId);
90
91		if (array_key_exists('priority', $this->dsl)
92		\|\| array_key_exists('sort_field', $this->dsl)
93		\|\| array_key_exists('sort_order', $this->dsl)
94		\|\| array_key_exists('remote_id', $this->dsl)
95		) {
96		$locationUpdateStruct = $locationService->newLocationUpdateStruct();
97
98		if (isset($this->dsl['priority'])) {
99		$locationUpdateStruct->priority = $this->dsl['priority'];
100		}
101
102		if (isset($this->dsl['sort_field'])) {
103		$locationUpdateStruct->sortField = $this->getSortField($location->sortField);
104		}
105
106		if (isset($this->dsl['sort_order'])) {
107		$locationUpdateStruct->sortOrder = $this->getSortOrder($location->sortOrder);
108		}
109
110		if (isset($this->dsl['remote_id'])) {
111		$locationUpdateStruct->remoteId = $this->dsl['remote_id'];
112		}
113
114		$locationService->updateLocation($location, $locationUpdateStruct);
115		}
116
117		// Check if visibility needs to be updated
118		if (isset($this->dsl['is_hidden'])) {
119		if ($this->dsl['is_hidden']) {
120		$locationService->hideLocation($location);
121		} else {
122		$locationService->unhideLocation($location);
123		}
124		}
125
126		// Move or swap location
127		if (isset($this->dsl['parent_location_id'])) {
128		// Move the location and all it's children to a new parent
129		$parentLocationId = $this->dsl['parent_location_id'];
130		if ($this->referenceResolver->isReference($parentLocationId)) {
131		$parentLocationId = $this->referenceResolver->getReferenceValue($parentLocationId);
132		}
133		$newParentLocation = $locationService->loadLocation($parentLocationId);
134		$locationService->moveSubtree($location, $newParentLocation);
135	View Code Duplication	} elseif (isset($this->dsl['swap_with_location'])) {
		0 ignored issues – show Duplication introduced 2016-08-05 09:22 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
136		//Swap locations
137		$swapLocationId = $this->dsl['swap_with_location'];
138		if ($this->referenceResolver->isReference($swapLocationId)) {
139		$swapLocationId = $this->referenceResolver->getReferenceValue($swapLocationId);
140		}
141		$locationToSwap = $locationService->loadLocation($swapLocationId);
142
143		$locationService->swapLocation($location, $locationToSwap);
144		}
145
146		$this->setReferences($location);
147		}
148
149		/**
150		* Delete locations identified by their ids.
151		*
152		* @todo add support for flexible matchers
153		*/
154		protected function delete()
155		{
156		$locationService = $this->repository->getLocationService();
157
158		if (!isset($this->dsl['location_id'])) {
159		throw new \Exception('No location provided for deletion');
160		}
161
162		if (!is_array($this->dsl['location_id'])) {
163		$this->dsl['location_id'] = array($this->dsl['location_id']);
164		}
165
166		foreach ($this->dsl['location_id'] as $locationId) {
167		$location = $locationService->loadLocation($locationId);
168		$locationService->deleteLocation($location);
169		}
170		}
171
172		/**
173		* NB: weirdly enough, it returns contents, not locations
174		*
175		* @param string $action
176		* @return ContentCollection
177		* @throws \Exception
178		*/
179	View Code Duplication	protected function matchContents($action)
		0 ignored issues – show Duplication introduced 2016-08-05 17:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
180		{
181		if (!isset($this->dsl['object_id']) && !isset($this->dsl['remote_id']) && !isset($this->dsl['match'])) {
182		throw new \Exception("The ID or remote ID of an object or a Match Condition is required to $action a new location.");
183		}
184
185		// Backwards compat
186		if (!isset($this->dsl['match'])) {
187		if (isset($this->dsl['object_id'])) {
188		$this->dsl['match'] = array('content_id' => $this->dsl['object_id']);
189		} elseif (isset($this->dsl['remote_id'])) {
190		$this->dsl['match'] = array('content_remote_id' => $this->dsl['remote_id']);
191		}
192		}
193
194		$match = $this->dsl['match'];
195
196		// convert the references passed in the match
197		foreach ($match as $condition => $values) {
198		if (is_array($values)) {
199		foreach ($values as $position => $value) {
200		if ($this->referenceResolver->isReference($value)) {
201		$match[$condition][$position] = $this->referenceResolver->getReferenceValue($value);
202		}
203		}
204		} else {
205		if ($this->referenceResolver->isReference($values)) {
206		$match[$condition] = $this->referenceResolver->getReferenceValue($values);
207		}
208		}
209		}
210
211		return $this->contentMatcher->matchContent($match);
212		}
213
214		protected function getSortField($currentValue = null)
215		{
216		$sortField = Location::SORT_FIELD_PUBLISHED;
217
218		if (!is_null($currentValue)) {
219		$sortField = $currentValue;
220		}
221
222		if (isset($this->dsl['sort_field'])) {
223		$sortFieldId = "SORT_FIELD_" . strtoupper($this->dsl['sort_field']);
224
225		$ref = new \ReflectionClass('eZ\Publish\API\Repository\Values\Content\Location');
226
227		$sortField = $ref->getConstant($sortFieldId);
228		}
229
230		return $sortField;
231		}
232
233		/**
234		* Get the sort order based on the current value and the value in the DSL definition.
235		*
236		* If no current value is set and there is no value in the DSL it will default to Location::SORT_ORDER_ASC
237		*
238		* @see \eZ\Publish\API\Repository\Values\Content\Location::SORT_ORDER_*
239		*
240		* @param int $currentValue
241		* @return int
242		*/
243		protected function getSortOrder($currentValue = null)
244		{
245		$sortOrder = Location::SORT_ORDER_ASC;
246		if (!is_null($currentValue)) {
247		$sortOrder = $currentValue;
248		}
249
250		if (isset($this->dsl['sort_order'])) {
251		if (strtoupper($this->dsl['sort_order']) === 'ASC') {
252		$sortOrder = Location::SORT_ORDER_ASC;
253		} else {
254		$sortOrder = Location::SORT_ORDER_DESC;
255		}
256		}
257
258		return $sortOrder;
259		}
260
261		/**
262		* Sets references to object attributes
263		*
264		* The Location Manager currently supports setting references to location id.
265		*
266		* @throws \InvalidArgumentException When trying to set a reference to an unsupported attribute.
267		* @param \eZ\Publish\API\Repository\Values\Content\Location\|LocationCollection $location
268		* @return boolean
269		*/
270		protected function setReferences($location)
271		{
272		if (!array_key_exists('references', $this->dsl)) {
273		return false;
274		}
275
276		if ($location instanceof LocationCollection) {
277		if (count($location) > 1) {
278		throw new \InvalidArgumentException('Location Manager does not support setting references for creating/updating of multiple locations');
279		}
280		$location = reset($location);
281		}
282
283		foreach ($this->dsl['references'] as $reference) {
284		switch ($reference['attribute']) {
285		case 'location_id':
286		case 'id':
287		$value = $location->id;
288		break;
289		default:
290		throw new \InvalidArgumentException('Location Manager does not support setting references for attribute ' . $reference['attribute']);
291		}
292
293		$this->referenceResolver->addReference($reference['identifier'], $value);
		0 ignored issues – show Bug introduced 2016-08-05 09:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Kaliop\eZMigrationBundle...erenceResolverInterface` as the method `addReference()` does only exist in the following implementations of said interface: `Kaliop\eZMigrationBundle...CustomReferenceResolver`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
294		}
295
296		return true;
297		}
298		}
299

kaliop-uk / ezmigrationbundle

Pull Request — master (#62)

LocationManager::update() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like