IPListener::handle() - Code Metrics - kaliop-uk/ezidentitymanagementbundle - Measure and Improve Code Quality continuously with Scrutinizer

IPListener::handle() A
last analyzed 2018-06-24 12:46 UTC

↳ Parent: IPListener

Complexity

Conditions	2
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
c	0
b	0
f	0
rs	9.536
cc	2
nc	3
nop	1

<?php

namespace Kaliop\IdentityManagementBundle\Security\Firewall;

use Symfony\Component\Security\Http\Firewall\ListenerInterface;
use Symfony\Component\Security\Core\SecurityContextInterface;
use Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\Security\Core\Exception\AuthenticationException;
use Kaliop\IdentityManagementBundle\Security\Authentication\Token\IPToken;

class IPListener implements ListenerInterface
{
    protected $securityContext;
    protected $authenticationManager;

    public function __construct(SecurityContextInterface $securityContext, AuthenticationManagerInterface $authenticationManager)
    {
        $this->securityContext = $securityContext;
        $this->authenticationManager = $authenticationManager;
    }

    public function handle(GetResponseEvent $event)
    {
        $token = new IPToken();
        $token->setClientIp($event->getRequest()->getClientIp());

        /// @todo check what to return exactly when auth-by-ip is not successful: return, throw, set 403 response?

        try {
            $authToken = $this->authenticationManager->authenticate($token);
            $this->securityContext->setToken($authToken);

            return;
        } catch (AuthenticationException $failed) {

            // ... you might log something here

            // To deny the authentication clear the token. This will redirect to the login page.
            // Make sure to only clear your token, not those of other authentication listeners.
            // $token = $this->securityContext->getToken();

            // if ($token instanceof WsseUserToken && $this->providerKey === $token->getProviderKey()) {

            //     $this->securityContext->setToken(null);

            // }
            // return;
        }
    }
}


1			<?php
2
3			namespace Kaliop\IdentityManagementBundle\Security\Firewall;
4
5			use Symfony\Component\Security\Http\Firewall\ListenerInterface;
6			use Symfony\Component\Security\Core\SecurityContextInterface;
7			use Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface;
8			use Symfony\Component\HttpKernel\Event\GetResponseEvent;
9			use Symfony\Component\Security\Core\Exception\AuthenticationException;
10			use Kaliop\IdentityManagementBundle\Security\Authentication\Token\IPToken;
11
12			class IPListener implements ListenerInterface
13			{
14			protected $securityContext;
15			protected $authenticationManager;
16
17			public function __construct(SecurityContextInterface $securityContext, AuthenticationManagerInterface $authenticationManager)
18			{
19			$this->securityContext = $securityContext;
20			$this->authenticationManager = $authenticationManager;
21			}
22
23			public function handle(GetResponseEvent $event)
24			{
25			$token = new IPToken();
26			$token->setClientIp($event->getRequest()->getClientIp());
27
28			/// @todo check what to return exactly when auth-by-ip is not successful: return, throw, set 403 response?
29
30			try {
31			$authToken = $this->authenticationManager->authenticate($token);
32			$this->securityContext->setToken($authToken);
33
34			return;
35			} catch (AuthenticationException $failed) {
			0 ignored issues – show Bug introduced 2018-06-24 00:13 UTC by Report Bug Copy Issue Report The class `Symfony\Component\Securi...AuthenticationException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
36			// ... you might log something here
37
38			// To deny the authentication clear the token. This will redirect to the login page.
39			// Make sure to only clear your token, not those of other authentication listeners.
40			// $token = $this->securityContext->getToken();
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-06-24 00:13 UTC by Report Bug Copy Issue Report `54%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
41			// if ($token instanceof WsseUserToken && $this->providerKey === $token->getProviderKey()) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-06-24 00:13 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
42			// $this->securityContext->setToken(null);
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-06-24 00:13 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
43			// }
44			// return;
45			}
46			}
47			}
48

kaliop-uk / ezidentitymanagementbundle

IPListener::handle() A last analyzed 2018-06-24 12:46 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

IPListener::handle() A
last analyzed 2018-06-24 12:46 UTC