UserMetadata::handle() - Code Metrics - kaliop-uk/ezfindsearchenginebundle - Measure and Improve Code Quality continuously with Scrutinizer

UserMetadata::handle() B
last analyzed 2018-12-18 19:37 UTC

↳ Parent: UserMetadata

Complexity

Conditions	7
Paths	9

Size

Total Lines

Duplication

Lines	16
Ratio	61.54 %

Importance

Changes

Metric	Value
dl	16
loc	26
c	0
b	0
f	0
rs	8.5706
cc	7
nc	9
nop	2

<?php


namespace Kaliop\EzFindSearchEngineBundle\Core\Persistence\eZFind\Content\Search\Common\Gateway\CriterionHandler;

use eZ\Publish\API\Repository\Values\Content\Query\Criterion;
use Kaliop\EzFindSearchEngineBundle\Core\Persistence\eZFind\Content\Search\Common\Gateway\CriteriaConverter;
use Kaliop\EzFindSearchEngineBundle\Core\Persistence\eZFind\Content\Search\Common\Gateway\CriterionHandler;
use Kaliop\EzFindSearchEngineBundle\Core\Base\Exceptions\NotImplementedException;

class UserMetadata extends CriterionHandler
{
    public function accept(Criterion $criterion)
    {
        return $criterion instanceof Criterion\UserMetadata;
    }

    public function handle(CriteriaConverter $converter, Criterion $criterion)
    {
        switch ($criterion->target)
        {
            case Criterion\UserMetadata::OWNER:

                $valueList = (array)$criterion->value;

                foreach ($valueList as $value) {
                    $result[] = 'owner_id:' . $this->escapeValue($value);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                }

                return count($result) == 1 ? $result[0] : array_unshift($result, 'OR');
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

            case Criterion\UserMetadata::GROUP:

                $valueList = (array)$criterion->value;

                foreach ($valueList as $value) {
                    $result[] = 'owner_group_id:' . $this->escapeValue($value);
                }

                return count($result) == 1 ? $result[0] : array_unshift($result, 'OR');

            default:
                throw new NotImplementedException("Can not convert UserMetadata criterion for target {$criterion->target}: no such data in the solr schema by default");
        }
    }
}


1		<?php
2
3
4		namespace Kaliop\EzFindSearchEngineBundle\Core\Persistence\eZFind\Content\Search\Common\Gateway\CriterionHandler;
5
6		use eZ\Publish\API\Repository\Values\Content\Query\Criterion;
7		use Kaliop\EzFindSearchEngineBundle\Core\Persistence\eZFind\Content\Search\Common\Gateway\CriteriaConverter;
8		use Kaliop\EzFindSearchEngineBundle\Core\Persistence\eZFind\Content\Search\Common\Gateway\CriterionHandler;
9		use Kaliop\EzFindSearchEngineBundle\Core\Base\Exceptions\NotImplementedException;
10
11		class UserMetadata extends CriterionHandler
12		{
13		public function accept(Criterion $criterion)
14		{
15		return $criterion instanceof Criterion\UserMetadata;
16		}
17
18		public function handle(CriteriaConverter $converter, Criterion $criterion)
19		{
20		switch ($criterion->target)
21		{
22	View Code Duplication	case Criterion\UserMetadata::OWNER:
		0 ignored issues – show Duplication introduced 2018-06-23 18:46 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		$valueList = (array)$criterion->value;
24
25		foreach ($valueList as $value) {
26		$result[] = 'owner_id:' . $this->escapeValue($value);
		0 ignored issues – show Coding Style Comprehensibility introduced 2018-06-23 18:46 UTC by Report Bug Copy Issue Report `$result` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$result = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
27		}
28
29		return count($result) == 1 ? $result[0] : array_unshift($result, 'OR');
		0 ignored issues – show Bug introduced 2018-06-23 18:46 UTC by Report Bug Copy Issue Report The variable `$result` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
30
31	View Code Duplication	case Criterion\UserMetadata::GROUP:
		0 ignored issues – show Duplication introduced 2018-06-23 18:46 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		$valueList = (array)$criterion->value;
33
34		foreach ($valueList as $value) {
35		$result[] = 'owner_group_id:' . $this->escapeValue($value);
36		}
37
38		return count($result) == 1 ? $result[0] : array_unshift($result, 'OR');
39
40		default:
41		throw new NotImplementedException("Can not convert UserMetadata criterion for target {$criterion->target}: no such data in the solr schema by default");
42		}
43		}
44		}
45

kaliop-uk / ezfindsearchenginebundle

UserMetadata::handle() B last analyzed 2018-12-18 19:37 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

UserMetadata::handle() B
last analyzed 2018-12-18 19:37 UTC