Issues in Generic.php (master) - Issues in master - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1507)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

PHPDaemon/SockJS/Methods/Generic.php (33 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace PHPDaemon\SockJS\Methods;

use PHPDaemon\Core\Timer;

/**
 * Contains some base methods
 * @package Libraries
 * @subpackage SockJS
 * @author  Vasily Zorin <[email protected]>
 */
abstract class Generic extends \PHPDaemon\HTTPRequest\Generic
{
    protected $stage = 0;
    protected $sessId;
    protected $serverId;
    protected $path;
    protected $heartbeatTimer;

    protected $opts;

    protected $stopped = false;

    protected $callbackParamEnabled = false;
    protected $frames = [];

    protected $allowedMethods = 'GET';

    protected $errors = [
        1002 => 'Connection interrupted',
        2010 => 'Another connection still open',
        3000 => 'Go away!',
    ];

    protected $pollMode = ['stream'];

    protected $gcEnabled = true;

    protected $cacheable = false;
    protected $poll = false;

    protected $bytesSent = 0;

    protected $heartbeatOnFinish = false;


    /**
     * Constructor
     * @return void
     */
    public function init()
    {
        $this->sessId = $this->attrs->sessId;
        $this->serverId = $this->attrs->serverId;
        $this->path = $this->attrs->path;

        // @TODO: revert timeout after request
        $this->upstream->setTimeouts($this->appInstance->config->networktimeoutread->value,
            $this->appInstance->config->networktimeoutwrite->value);

        $this->opts = $this->appInstance->getRouteOptions($this->attrs->path);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->CORS();
        if ($this->isFinished()) {
            return;
        }
        if ($this->opts['cookie_needed'] && !$this instanceof Info) {
            if (isset($_COOKIE['JSESSIONID'])) {
                $val = $_COOKIE['JSESSIONID'];
                if (!is_string($val) || $val === '') {
                    $val = 'dummy';
                }
            } else {
                $val = 'dummy';
            }
            $this->setcookie('JSESSIONID', $val, 0, '/');
        }
        $this->contentType($this->contentType);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if (!$this->cacheable) {
            $this->noncache();
            $this->header('X-Accel-Buffering: no');
        }
        if ($this->callbackParamEnabled) {
            if (!isset($_GET['c']) || !is_string($_GET['c']) || preg_match('~[^_\.a-zA-Z0-9]~', $_GET['c'])) {
                $this->header('500 Internal Server Error');
                $this->out('"callback" parameter required');
                $this->finish();
                return;
            }
        }
        if (($f = $this->appInstance->config->heartbeatinterval->value) > 0) {
            $this->heartbeatTimer = setTimeout(function ($timer) {

                if (in_array('one-by-one', $this->pollMode)) {
                    $this->heartbeatOnFinish = true;
                    $this->stop();
                    return;
                }
                $this->sendFrame('h');
                if ($this->gcEnabled) {
                    $this->gcCheck();
                }
            }, $f * 1e6);
        }
        $this->afterHeaders();
        if ($this->poll) {
            $this->acquire(function () {
                $this->poll();
            });
        }
    }

    /**
     * CORS
     * @return void
     */
    protected function CORS()
    {
        if (isset($_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS'])) {
            $this->header('Access-Control-Allow-Headers: ' . $_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS']);
        }
        if (isset($_SERVER['HTTP_ORIGIN']) && $_SERVER['HTTP_ORIGIN'] !== 'null') {
            $this->header('Access-Control-Allow-Origin:' . $_SERVER['HTTP_ORIGIN']);
        } else {
            $this->header('Access-Control-Allow-Origin: *');
        }
        $this->header('Access-Control-Allow-Credentials: true');
        if ($_SERVER['REQUEST_METHOD'] === 'OPTIONS') {
            $this->header('204 No Content');
            $this->header('Cache-Control: max-age=31536000, public, pre-check=0, post-check=0');
            $this->header('Access-Control-Max-Age: 31536000');
            $this->header('Access-Control-Allow-Methods: OPTIONS, ' . $this->allowedMethods);
            $this->header('Expires: ' . date('r', strtotime('+1 year')));
            $this->finish();
        } elseif (!in_array($_SERVER['REQUEST_METHOD'], explode(', ', $this->allowedMethods), true)) {
            $this->header('405 Method Not Allowed');
            $this->finish();
        }
    }

    /**
     * contentType
     * @param  string $type Content-Type
     * @return void
     */
    protected function contentType($type)
    {
        $this->header('Content-Type: ' . $type . '; charset=UTF-8');
    }

    /**
     * noncache
     * @return void
     */
    protected function noncache()
    {
        $this->header('Pragma: no-cache');
        $this->header('Cache-Control: no-store, no-cache, must-revalidate, max-age=0');
    }

    /**
     * Output some data
     * @param  string $s String to out
     * @param  boolean $flush
     * @return boolean        Success
     */
    public function out($s, $flush = true)
    {
        if ($this->heartbeatTimer !== null) {
            Timer::setTimeout($this->heartbeatTimer);
        }
        return parent::out($s, $flush);;
    }

    /**
     * Stop
     * @return void
     */
    public function stop()
    {
        if ($this->stopped) {
            return;
        }
        $this->stopped = true;
        if (in_array('one-by-one', $this->pollMode)) {
            $this->finish();
            return;
        }
        $this->appInstance->unsubscribeReal('s2c:' . $this->sessId, function ($redis) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $this->finish();
        });
    }

    /**
     * Send frame
     * @param  string $frame
     * @return void
     */
    protected function sendFrame($frame)
    {
        if (substr($frame, 0, 1) === 'c') {
            $this->finish();
        }
    }

    /**
     * gcCheck
     * @return void
     */
    public function gcCheck()
    {
        if ($this->stopped) {
            return;
        }
        $max = $this->appInstance->config->gcmaxresponsesize->value;
        if ($max > 0 && $this->bytesSent > $max) {
            $this->stop();
        }
    }

    /**
     * afterHeaders
     * @return void
     */
    public function afterHeaders()
    {
    }

    /**
     * acquire
     * @param  callable $cb
     * @callback $cb ( )
     * @return void
     */
    protected function acquire($cb)
    {
        $this->appInstance->getkey('error:' . $this->sessId, function ($redis) use ($cb) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if (!$redis) {
                $this->internalServerError();
                return;
            }
            if ($redis->result !== null) {
                $this->error((int)$redis->result);
                return;
            }
            if ($this->appInstance->getLocalSubscribersCount('w8in:' . $this->sessId) > 0) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                $this->anotherConnectionStillOpen();
                return;
            }
            $this->appInstance->publish('w8in:' . $this->sessId, '', function ($redis) use ($cb) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                if (!$redis) {
                    $this->internalServerError();
                    return;
                }
                if ($redis->result > 0) {
                    $this->anotherConnectionStillOpen();
                    return;
                }
                $this->appInstance->subscribe('w8in:' . $this->sessId, [$this, 'w8in'], function ($redis) use ($cb) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    if (!$redis) {
                        $this->internalServerError();
                        return;
                    }
                    if ($this->appInstance->getLocalSubscribersCount('w8in:' . $this->sessId) > 1) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        $this->anotherConnectionStillOpen();
                        return;
                    }
                    $this->appInstance->publish('w8in:' . $this->sessId, '', function ($redis) use ($cb) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        if (!$redis) {
                            $this->internalServerError();
                            return;
                        }
                        if ($redis->result > 1) {
                            $this->anotherConnectionStillOpen();
                            return;
                        }
                        if ($this->appInstance->getLocalSubscribersCount('w8in:' . $this->sessId) > 1) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                            $this->anotherConnectionStillOpen();
                            return;
                        }
                        $cb === null || $cb();
                    });
                });
            });
        });
    }

    /**
     * internalServerError
     * @return void
     */
    public function internalServerError()
    {
        $this->header('500 Internal Server Error');
        $this->out('"callback" parameter required');
        $this->finish();
    }

    /**
     * error
     * @param  integer $code
     * @return void
     */
    protected function error($code)
    {
        $this->sendFrame('c' . json_encode([$code, isset($this->errors[$code]) ? $this->errors[$code] : null]));
    }

    /**
     * anotherConnectionStillOpen
     * @return void
     */
    protected function anotherConnectionStillOpen()
    {
        $this->appInstance->setkey('error:' . $this->sessId, 1002, function () {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $this->appInstance->expire('error:' . $this->sessId, $this->appInstance->config->deadsessiontimeout->value,
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                function () {
                    $this->error(2010);
                });
        });
    }

    /**
     * Poll
     * @param  callable $cb

     * @callback $cb ( )
     * @return void
     */
    protected function poll($cb = null)
    {
        $this->appInstance->subscribe('s2c:' . $this->sessId, [$this, 's2c'], function ($redis) use ($cb) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $this->appInstance->publish('poll:' . $this->sessId, json_encode($this->pollMode),
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                function ($redis) use ($cb) {
                    if (!$redis) {
                        $cb === null || $cb();
                        return;
                    }
                    if ($redis->result > 0) {
                        $cb === null || $cb();
                        return;
                    }
                    $this->appInstance->setnx('sess:' . $this->sessId, $this->attrs->server['REQUEST_URI'],
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                        function ($redis) use ($cb) {
                            if (!$redis || $redis->result === 0) {

                                $this->error(3000);
                                $cb === null || $cb();
                                return;
                            }
                            $this->appInstance->expire('sess:' . $this->sessId,
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                                $this->appInstance->config->deadsessiontimeout->value, function ($redis) use ($cb) {
                                    if (!$redis || $redis->result === 0) {

                                        $this->error(3000);
                                        $cb === null || $cb();
                                        return;
                                    }
                                    $this->appInstance->subscribe('state:' . $this->sessId,
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                                        function ($redis) use ($cb) {
                                            if (!$redis) {
                                                return;
                                            }
                                            list(, $chan, $state) = $redis->result;
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
                                            if ($state === 'started') {
                                                $this->sendFrame('o');
                                                if (!in_array('stream', $this->pollMode)) {
                                                    $this->finish();
                                                    return;
                                                }
                                            }
                                            $this->appInstance->publish('poll:' . $this->sessId,
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                                                json_encode($this->pollMode), function ($redis) use ($cb) {
                                                    if (!$redis || $redis->result === 0) {

                                                        $this->error(3000);
                                                        $cb === null || $cb();
                                                        return;
                                                    }
                                                    $cb === null || $cb();
                                                });
                                        }, function ($redis) use ($cb) {

                                            if (!$this->appInstance->beginSession($this->path, $this->sessId,
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                                                $this->attrs->server)
                                            ) {
                                                $this->header('404 Not Found');
                                                $this->finish();
                                                $this->unsubscribeReal('state:' . $this->sessId);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                                            }
                                            $cb === null || $cb();
                                        });
                                });
                        });
                });
        });
    }

    /**
     * Output some data
     * @param  string $s String to out
     * @param  boolean $flush
     * @return boolean        Success
     */
    public function outputFrame($s, $flush = true)
    {
        $this->bytesSent += mb_orig_strlen($s);
        return parent::out($s, $flush);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Called when request iterated
     * @return void
     */
    public function run()
    {
        $this->sleep(30);
    }

    /**
     * w8in
     * @return void
     */
    public function w8in()
    {
    }

    /**
     * s2c
     * @param  object $redis
     * @return void
     */
    public function s2c($redis)
    {
        if (!$redis) {
            return;
        }
        list(, $chan, $msg) = $redis->result;
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        $frames = json_decode($msg, true);
        if (!is_array($frames) || !sizeof($frames)) {
            return;
        }
        foreach ($frames as $frame) {
            $this->sendFrame($frame);
        }
        if (!in_array('stream', $this->pollMode)) {
            $this->heartbeatOnFinish = false;
            $this->stop();
            return;
        }
        if ($this->gcEnabled) {
            $this->gcCheck();
        }
    }

    /**
     * On finish
     * @return void
     */
    public function onFinish()
    {
        $this->appInstance->unsubscribe('s2c:' . $this->sessId, [$this, 's2c']);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        $this->appInstance->unsubscribe('w8in:' . $this->sessId, [$this, 'w8in']);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        Timer::remove($this->heartbeatTimer);
        if ($this->heartbeatOnFinish) {
            $this->sendFrame('h');
        }
        parent::onFinish();
    }
}


kakserpom / phpdaemon

Issues (1507)

Security Analysis not enabled

PHPDaemon/SockJS/Methods/Generic.php (33 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like