Issues in Application.php (master) - Issues in master - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1507)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

PHPDaemon/SockJS/Application.php (25 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace PHPDaemon\SockJS;

use PHPDaemon\Servers\WebSocket\Pool as WebSocketPool;
use PHPDaemon\Structures\ObjectStorage;

/**
 * @package    Libraries
 * @subpackage SockJS
 * @author     Vasily Zorin <[email protected]>
 */
class Application extends \PHPDaemon\Core\AppInstance
{
    public $wss;
    protected $redis;
    protected $sessions;

    /**
     * Set Redis instance
     * @param \PHPDaemon\Clients\Redis\Pool $redis
     * @return $this
     */
    public function setRedis(\PHPDaemon\Clients\Redis\Pool $redis)
    {
        $this->redis = $redis;
        return $this;
    }

    /**
     * getLocalSubscribersCount
     * @param  string $chan
     * @return integer
     */
    public function getLocalSubscribersCount($chan)
    {
        return $this->redis->getLocalSubscribersCount($this->config->redisprefix->value . $chan);
    }

    /**
     * subscribe
     * @param  string $chan [@todo description]
     * @param  callable $cb [@todo description]
     * @param  callable $opcb [@todo description]

     * @callback $cb ( )
     * @callback $opcb ( )
     * @return void
     */
    public function subscribe($chan, $cb, $opcb = null)
    {
        $this->redis->subscribe($this->config->redisprefix->value . $chan, $cb, $opcb);

    }

    /**
     * setnx
     * @param  string $key [@todo description]
     * @param  mixed $value [@todo description]
     * @param  callable $cb [@todo description]

     * @callback $cb ( )
     * @return void
     */
    public function setnx($key, $value, $cb = null)
    {
        $this->redis->setnx($this->config->redisprefix->value . $key, $value, $cb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * setkey
     * @param  string $key [@todo description]
     * @param  mixed $value [@todo description]
     * @param  callable $cb [@todo description]

     * @callback $cb ( )
     * @return void
     */
    public function setkey($key, $value, $cb = null)
    {
        $this->redis->set($this->config->redisprefix->value . $key, $value, $cb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * getkey
     * @param  string $key [@todo description]
     * @param  callable $cb [@todo description]

     * @callback $cb ( )
     * @return void
     */
    public function getkey($key, $cb = null)
    {
        $this->redis->get($this->config->redisprefix->value . $key, $cb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * expire
     * @param  string $key [@todo description]
     * @param  integer $seconds [@todo description]
     * @param  callable $cb [@todo description]

     * @callback $cb ( )
     * @return void
     */
    public function expire($key, $seconds, $cb = null)
    {
        $this->redis->expire($this->config->redisprefix->value . $key, $seconds, $cb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * unsubscribe
     * @param  string $chan [@todo description]
     * @param  callable $cb [@todo description]
     * @param  callable $opcb [@todo description]

     * @callback $cb ( )
     * @callback $opcb ( )
     * @return void
     */
    public function unsubscribe($chan, $cb, $opcb = null)
    {
        $this->redis->unsubscribe($this->config->redisprefix->value . $chan, $cb, $opcb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * unsubscribeReal
     * @param  string $chan [@todo description]
     * @param  callable $opcb [@todo description]

     * @callback $opcb ( )
     * @return void
     */
    public function unsubscribeReal($chan, $opcb = null)
    {
        $this->redis->unsubscribeReal($this->config->redisprefix->value . $chan, $opcb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * publish
     * @param  string $chan [@todo description]
     * @param  callable $cb [@todo description]
     * @param  callable $opcb [@todo description]

     * @callback $cb ( )
     * @callback $opcb ( )
     * @return void
     */
    public function publish($chan, $cb, $opcb = null)
    {
        $this->redis->publish($this->config->redisprefix->value . $chan, $cb, $opcb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * Called when the worker is ready to go
     * @return void
     */
    public function onReady()
    {
        $this->redis = \PHPDaemon\Clients\Redis\Pool::getInstance($this->config->redisname->value);
        $this->sessions = new ObjectStorage;
        $this->wss = new ObjectStorage;
        foreach (preg_split('~\s*;\s*~', $this->config->wssname->value) as $wssname) {
            $this->attachWss(WebSocketPool::getInstance(trim($wssname)));
        }
    }

    /**
     * attachWss
     * @param \PHPDaemon\Network\Pool $wss
     * @return boolean
     */
    public function attachWss($wss)
    {
        if ($this->wss->contains($wss)) {
            return false;
        }
        $this->wss->attach($wss);
        $wss->bind('customTransport', [$this, 'wsHandler']);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        return true;
    }

    /**
     * onFinish
     * @return void
     */
    public function onFinish()
    {
        foreach ($this->attachedTo as $wss) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->detachWss($wss);
        }
        parent::onFinish();
    }

    /**
     * detachWss
     * @param  object $wss [@todo description]
     * @return boolean
     */
    public function detachWss($wss)
    {
        if (!$this->wss->contains($wss)) {
            return false;
        }
        $this->wss->detach($wss);
        $wss->unbind('transport', [$this, 'wsHandler']);
        return true;
    }

    /**
     * wsHandler
     * @param  object $ws [@todo description]
     * @param  string $path [@todo description]
     * @param  object $client [@todo description]
     * @param  callable $state [@todo description]
     * @callback $state ( object $route )
     * @return boolean
     */
    public function wsHandler($ws, $path, $client, $state)
    {
        $e = explode('/', $path);
        $method = array_pop($e);
        $serverId = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $sessId = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($method !== 'websocket') {
            return false;
        }
        if (sizeof($e) < 3 || !isset($e[sizeof($e) - 2]) || !ctype_digit($e[sizeof($e) - 2])) {
            return false;
        }
        $sessId = array_pop($e);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $serverId = array_pop($e);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $path = implode('/', $e);
        $client = new WebSocketConnectionProxy($this, $client);
        $route = $ws->getRoute($path, $client, true);
        if (!$route) {
            $state($route);
            return false;
        }
        $route = new WebSocketRouteProxy($this, $route);
        $state($route);
        return true;
    }

    /**
     * beginSession
     * @param  string $path [@todo description]
     * @param  string $sessId [@todo description]
     * @param  string $server [@todo description]
     * @return object

     */
    public function beginSession($path, $sessId, $server)
    {
        $session = new Session($this, $sessId, $server);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        foreach ($this->wss as $wss) {
            if ($session->route = $wss->getRoute($path, $session)) {
                break;
            }
        }
        if (!$session->route) {
            return false;
        }
        $this->sessions->attach($session);
        $session->onHandshake();
        return $session;
    }

    /**
     * getRouteOptions
     * @param  string $path [@todo description]
     * @return array
     */
    public function getRouteOptions($path)
    {
        $opts = [
            'websocket' => true,
            'origins' => ['*:*'],
            'cookie_needed' => false,
        ];
        foreach ($this->wss as $wss) {
            if ($wss->routeExists($path)) {
                foreach ($wss->getRouteOptions($path) as $k => $v) {
                    $opts[$k] = $v;
                }
                break;
            }
        }
        return $opts;
    }

    /**
     * endSession
     * @param Session $session
     * @return void
     */
    public function endSession($session)
    {
        $this->sessions->detach($session);
    }

    /**
     * Creates Request.
     * @param  object $req Request.
     * @param  object $upstream Upstream application instance.
     * @return object           Request.
     */
    public function beginRequest($req, $upstream)
    {
        $e = array_map('rawurldecode', explode('/', $req->attrs->server['DOCUMENT_URI']));

        $serverId = null;
        $sessId = null;

        /* Route discovery */
        $path = null;
        $extra = [];
        do {
            foreach ($this->wss as $wss) {
                $try = implode('/', $e);
                if ($try === '') {
                    $try = '/';
                }
                if ($wss->routeExists($try)) {
                    $path = $try;
                    break 2;
                }
            }
            array_unshift($extra, array_pop($e));
        } while (sizeof($e) > 0);

        if ($path === null) {
            return $this->callMethod('NotFound', $req, $upstream);
        }

        if (sizeof($extra) > 0 && end($extra) === '') {
            array_pop($extra);
        }

        $method = sizeof($extra) ? array_pop($extra) : null;

        if ($method === null) {
            $method = 'Welcome';
        } elseif ($method === 'info') {
        } elseif (preg_match('~^iframe(?:-([^/]*))?\.html$~', $method, $m)) {
            $method = 'Iframe';
            $version = isset($m[1]) ? $m[1] : null;
        } else {
            if (sizeof($extra) < 2) {
                return $this->callMethod('NotFound', $req, $upstream);
            }
            $sessId = array_pop($extra);
            $serverId = array_pop($extra);
            if ($sessId === '' || $serverId === '' || mb_orig_strpos($sessId,
                    '.') !== false || mb_orig_strpos($serverId, '.') !== false
            ) {
                return $this->callMethod('NotFound', $req, $upstream);
            }
        }
        $req->attrs->sessId = $sessId;
        $req->attrs->serverId = $serverId;
        $req->attrs->path = $path;
        $req = $this->callMethod($method, $req, $upstream);
        if ($req instanceof Methods\Iframe && mb_orig_strlen($version)) {
            $req->attrs->version = $version;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }
        return $req;
    }

    /**
     * callMethod
     * @param  string $method [@todo description]
     * @param  object $req [@todo description]
     * @param  object $upstream [@todo description]
     * @return object
     */
    public function callMethod($method, $req, $upstream)
    {
        $method = strtr(ucwords(strtr($method, ['_' => ' '])), [' ' => '']);
        if (strtolower($method) === 'generic') {
            $method = 'NotFound';
        }
        $class = __NAMESPACE__ . '\\Methods\\' . $method;
        if (!class_exists($class)) {
            $class = __NAMESPACE__ . '\\Methods\\NotFound';
        }
        return new $class($this, $upstream, $req);
    }

    /**
     * Setting default config options
     * @return array|bool
     */
    protected function getConfigDefaults()
    {
        return [
            /* [string] @todo redis-name */
            'redis-name' => '',

            /* [string] @todo redis-prefix */
            'redis-prefix' => 'sockjs:',

            /* [string] @todo wss-name */
            'wss-name' => '',

            /* [Double] @todo batch-delay */
            'batch-delay' => new \PHPDaemon\Config\Entry\Double('0.05'),

            /* [Double] @todo heartbeat-interval */
            'heartbeat-interval' => new \PHPDaemon\Config\Entry\Double('25'),

            /* [Time] @todo dead-session-timeout */
            'dead-session-timeout' => new \PHPDaemon\Config\Entry\Time('1h'),

            /* [Size] @todo gc-max-response-size */
            'gc-max-response-size' => new \PHPDaemon\Config\Entry\Size('128k'),

            /* [Time] @todo network-timeout-read */
            'network-timeout-read' => new \PHPDaemon\Config\Entry\Time('2h'),

            /* [Time] @todo network-timeout-write */
            'network-timeout-write' => new \PHPDaemon\Config\Entry\Time('120s'),
        ];
    }
}


Issues (1507)

Security Analysis not enabled

PHPDaemon/SockJS/Application.php (25 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

kakserpom / phpdaemon

Issues (1507)

Security Analysis not enabled

PHPDaemon/SockJS/Application.php (25 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like