Issues in PubSub.php (master) - Issues in master - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1507)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

PHPDaemon/PubSub/PubSub.php (5 issues)

Labels

Severity

Informational 5

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace PHPDaemon\PubSub;

/**
 * PubSub
 * @package PHPDaemon\PubSub
 * @author  Vasily Zorin <[email protected]>
 */
class PubSub
{
    use \PHPDaemon\Traits\ClassWatchdog;
    use \PHPDaemon\Traits\StaticObjectWatchdog;

    /**
     * @var PubSubEvent[] Storage of events
     */
    protected $events = [];

    /**
     * Is event exists?
     * @param  string $id Event ID
     * @return boolean
     */
    public function eventExists($id)
    {
        return isset($this->events[$id]);
    }

    /**
     * Subcribe to event
     * @param  string $id Event ID
     * @param  object $obj Subscriber
     * @param  callable $cb Callback
     * @return boolean       Success

     */
    public function sub($id, $obj, $cb)
    {
        if (!isset($this->events[$id])) {
            return false;
        }
        return $this->events[$id]->sub($obj, $cb);
    }

    /**
     * Adds event
     * @param  string $id Event ID
     * @param  PubSubEvent $obj
     * @return void
     */
    public function addEvent($id, PubSubEvent $obj)
    {
        $this->events[$id] = $obj;
    }

    /**
     * Removes event
     * @param  string $id Event ID
     * @return void
     */
    public function removeEvent($id)
    {
        unset($this->events[$id]);
    }

    /**
     * Unsubscribe object from event
     * @param  string $id Event ID
     * @param  object $obj Subscriber
     * @return boolean      Success

     */
    public function unsub($id, $obj)

    {
        if (!isset($this->events[$id])) {
            return false;
        }
        return $this->events[$id]->unsub($obj);
    }

    /**
     * Publish
     * @param  string $id Event ID
     * @param  mixed $data Data
     * @return boolean       Success

     */
    public function pub($id, $data)

    {
        if (!isset($this->events[$id])) {
            return false;
        }
        return $this->events[$id]->pub($data);
    }

    /**
     * Unsubscribe object from all events
     * @param  object $obj Subscriber
     * @return boolean      Success
     */
    public function unsubFromAll($obj)
    {
        foreach ($this->events as $event) {
            $event->unsub($obj);
        }
        return true;
    }
}


1		<?php
2		namespace PHPDaemon\PubSub;
3
4		/**
5		* PubSub
6		* @package PHPDaemon\PubSub
7		* @author Vasily Zorin <[email protected]>
8		*/
9		class PubSub
10		{
11		use \PHPDaemon\Traits\ClassWatchdog;
12		use \PHPDaemon\Traits\StaticObjectWatchdog;
13
14		/**
15		* @var PubSubEvent[] Storage of events
16		*/
17		protected $events = [];
18
19		/**
20		* Is event exists?
21		* @param string $id Event ID
22		* @return boolean
23		*/
24		public function eventExists($id)
25		{
26		return isset($this->events[$id]);
27		}
28
29		/**
30		* Subcribe to event
31		* @param string $id Event ID
32		* @param object $obj Subscriber
33		* @param callable $cb Callback
34		* @return boolean Success
		0 ignored issues – show Documentation introduced 2016-05-10 20:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `false\|PubSubEvent`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
35		*/
36		public function sub($id, $obj, $cb)
37		{
38		if (!isset($this->events[$id])) {
39		return false;
40		}
41		return $this->events[$id]->sub($obj, $cb);
42		}
43
44		/**
45		* Adds event
46		* @param string $id Event ID
47		* @param PubSubEvent $obj
48		* @return void
49		*/
50		public function addEvent($id, PubSubEvent $obj)
51		{
52		$this->events[$id] = $obj;
53		}
54
55		/**
56		* Removes event
57		* @param string $id Event ID
58		* @return void
59		*/
60		public function removeEvent($id)
61		{
62		unset($this->events[$id]);
63		}
64
65		/**
66		* Unsubscribe object from event
67		* @param string $id Event ID
68		* @param object $obj Subscriber
69		* @return boolean Success
		0 ignored issues – show Documentation introduced 2016-05-18 23:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `false\|PubSubEvent`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
70		*/
71	View Code Duplication	public function unsub($id, $obj)
		0 ignored issues – show Duplication introduced 2018-01-16 22:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72		{
73		if (!isset($this->events[$id])) {
74		return false;
75		}
76		return $this->events[$id]->unsub($obj);
77		}
78
79		/**
80		* Publish
81		* @param string $id Event ID
82		* @param mixed $data Data
83		* @return boolean Success
		0 ignored issues – show Documentation introduced 2016-05-18 23:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `false\|PubSubEvent`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
84		*/
85	View Code Duplication	public function pub($id, $data)
		0 ignored issues – show Duplication introduced 2018-01-16 22:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86		{
87		if (!isset($this->events[$id])) {
88		return false;
89		}
90		return $this->events[$id]->pub($data);
91		}
92
93		/**
94		* Unsubscribe object from all events
95		* @param object $obj Subscriber
96		* @return boolean Success
97		*/
98		public function unsubFromAll($obj)
99		{
100		foreach ($this->events as $event) {
101		$event->unsub($obj);
102		}
103		return true;
104		}
105		}
106

kakserpom / phpdaemon

Issues (1507)

Security Analysis not enabled

PHPDaemon/PubSub/PubSub.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like