Issues in FileWatcher.php (master) - Issues in master - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1507)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

PHPDaemon/FS/FileWatcher.php (2 issues)

Labels

Documentation 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace PHPDaemon\FS;

use PHPDaemon\Core\Daemon;
use PHPDaemon\Core\Timer;

/**
 * Implementation of the file watcher
 * @package PHPDaemon\FS
 * @author  Vasily Zorin <[email protected]>
 */
class FileWatcher
{
    use \PHPDaemon\Traits\ClassWatchdog;
    use \PHPDaemon\Traits\StaticObjectWatchdog;

    /**
     * @var array Associative array of the files being observed
     */
    public $files = [];

    /**
     * @var resource Resource returned by inotify_init()
     */
    public $inotify;

    /**
     * @var Array of inotify descriptors
     */
    public $descriptors = [];

    /**
     * Constructor
     */
    public function __construct()
    {
        if (Daemon::loadModuleIfAbsent('inotify')) {
            $this->inotify = inotify_init();
            stream_set_blocking($this->inotify, 0);
        }

        Timer::add(
            function ($event) {
                Daemon::$process->fileWatcher->watch();
                if (sizeof(Daemon::$process->fileWatcher->files) > 0) {
                    $event->timeout();
                }
            },
            1e6 * 1,
            'fileWatcher'
        );
    }

    /**
     * Check the file system, triggered by timer
     * @return void
     */
    public function watch()
    {
        if ($this->inotify) {
            $events = inotify_read($this->inotify);
            if (!$events) {
                return;
            }
            foreach ($events as $ev) {
                $path = $this->descriptors[$ev['wd']];
                if (!isset($this->files[$path])) {
                    continue;
                }
                $this->onFileChanged($path);
            }
        } else {
            static $hash = [];

            foreach ($this->files as $path => $v) {
                if (!file_exists($path)) {
                    // file can be deleted
                    unset($this->files[$path]);
                    continue;
                }

                $mt = filemtime($path);

                if (isset($hash[$path]) && ($mt > $hash[$path])) {
                    $this->onFileChanged($path);
                }

                $hash[$path] = $mt;
            }
        }
    }

    /**
     * Called when file $path is changed
     * @param  string $path Path
     * @return void
     */
    public function onFileChanged($path)
    {
        if (!Daemon::lintFile($path)) {
            Daemon::log(__METHOD__ . ': Detected parse error in ' . $path);
            return;
        }
        foreach ($this->files[$path] as $cb) {
            if (is_callable($cb) || is_array($cb)) {
                $cb($path);
            } elseif (!Daemon::$process->IPCManager->importFile($cb, $path)) {
                $this->rmWatch($path, $cb);
            }
        }
    }

    /**
     * Cancels your subscription on object in FS
     * @param  string $path Path
     * @param  mixed $cb Callback
     * @return boolean
     */
    public function rmWatch($path, $cb)
    {
        $path = realpath($path);

        if (!isset($this->files[$path])) {
            return false;
        }
        if (($k = array_search($cb, $this->files[$path], true)) !== false) {
            unset($this->files[$path][$k]);
        }
        if (sizeof($this->files[$path]) === 0) {
            if ($this->inotify) {
                if (($descriptor = array_search($path, $this->descriptors)) !== false) {
                    inotify_rm_watch($this->inotify, $cb);
                }
            }
            unset($this->files[$path]);
        }
        return true;
    }

    /**
     * Adds your subscription on object in FS
     * @param  string $path Path
     * @param  mixed $cb Callback
     * @param  integer $flags Look inotify_add_watch()

     * @return true

     */
    public function addWatch($path, $cb, $flags = null)
    {
        $path = realpath($path);
        if (!isset($this->files[$path])) {
            $this->files[$path] = [];
            if ($this->inotify) {
                $this->descriptors[inotify_add_watch($this->inotify, $path, $flags ?: IN_MODIFY)] = $path;
            }
        }
        $this->files[$path][] = $cb;
        Timer::setTimeout('fileWatcher');
        return true;
    }
}


1			<?php
2			namespace PHPDaemon\FS;
3
4			use PHPDaemon\Core\Daemon;
5			use PHPDaemon\Core\Timer;
6
7			/**
8			* Implementation of the file watcher
9			* @package PHPDaemon\FS
10			* @author Vasily Zorin <[email protected]>
11			*/
12			class FileWatcher
13			{
14			use \PHPDaemon\Traits\ClassWatchdog;
15			use \PHPDaemon\Traits\StaticObjectWatchdog;
16
17			/**
18			* @var array Associative array of the files being observed
19			*/
20			public $files = [];
21
22			/**
23			* @var resource Resource returned by inotify_init()
24			*/
25			public $inotify;
26
27			/**
28			* @var Array of inotify descriptors
29			*/
30			public $descriptors = [];
31
32			/**
33			* Constructor
34			*/
35			public function __construct()
36			{
37			if (Daemon::loadModuleIfAbsent('inotify')) {
38			$this->inotify = inotify_init();
39			stream_set_blocking($this->inotify, 0);
40			}
41
42			Timer::add(
43			function ($event) {
44			Daemon::$process->fileWatcher->watch();
45			if (sizeof(Daemon::$process->fileWatcher->files) > 0) {
46			$event->timeout();
47			}
48			},
49			1e6 * 1,
50			'fileWatcher'
51			);
52			}
53
54			/**
55			* Check the file system, triggered by timer
56			* @return void
57			*/
58			public function watch()
59			{
60			if ($this->inotify) {
61			$events = inotify_read($this->inotify);
62			if (!$events) {
63			return;
64			}
65			foreach ($events as $ev) {
66			$path = $this->descriptors[$ev['wd']];
67			if (!isset($this->files[$path])) {
68			continue;
69			}
70			$this->onFileChanged($path);
71			}
72			} else {
73			static $hash = [];
74
75			foreach ($this->files as $path => $v) {
76			if (!file_exists($path)) {
77			// file can be deleted
78			unset($this->files[$path]);
79			continue;
80			}
81
82			$mt = filemtime($path);
83
84			if (isset($hash[$path]) && ($mt > $hash[$path])) {
85			$this->onFileChanged($path);
86			}
87
88			$hash[$path] = $mt;
89			}
90			}
91			}
92
93			/**
94			* Called when file $path is changed
95			* @param string $path Path
96			* @return void
97			*/
98			public function onFileChanged($path)
99			{
100			if (!Daemon::lintFile($path)) {
101			Daemon::log(__METHOD__ . ': Detected parse error in ' . $path);
102			return;
103			}
104			foreach ($this->files[$path] as $cb) {
105			if (is_callable($cb) \|\| is_array($cb)) {
106			$cb($path);
107			} elseif (!Daemon::$process->IPCManager->importFile($cb, $path)) {
108			$this->rmWatch($path, $cb);
109			}
110			}
111			}
112
113			/**
114			* Cancels your subscription on object in FS
115			* @param string $path Path
116			* @param mixed $cb Callback
117			* @return boolean
118			*/
119			public function rmWatch($path, $cb)
120			{
121			$path = realpath($path);
122
123			if (!isset($this->files[$path])) {
124			return false;
125			}
126			if (($k = array_search($cb, $this->files[$path], true)) !== false) {
127			unset($this->files[$path][$k]);
128			}
129			if (sizeof($this->files[$path]) === 0) {
130			if ($this->inotify) {
131			if (($descriptor = array_search($path, $this->descriptors)) !== false) {
132			inotify_rm_watch($this->inotify, $cb);
133			}
134			}
135			unset($this->files[$path]);
136			}
137			return true;
138			}
139
140			/**
141			* Adds your subscription on object in FS
142			* @param string $path Path
143			* @param mixed $cb Callback
144			* @param integer $flags Look inotify_add_watch()
			0 ignored issues – show Documentation introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$flags` not be `integer\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
145			* @return true
			0 ignored issues – show Documentation introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `boolean`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
146			*/
147			public function addWatch($path, $cb, $flags = null)
148			{
149			$path = realpath($path);
150			if (!isset($this->files[$path])) {
151			$this->files[$path] = [];
152			if ($this->inotify) {
153			$this->descriptors[inotify_add_watch($this->inotify, $path, $flags ?: IN_MODIFY)] = $path;
154			}
155			}
156			$this->files[$path][] = $cb;
157			Timer::setTimeout('fileWatcher');
158			return true;
159			}
160			}
161

kakserpom / phpdaemon

Issues (1507)

Security Analysis not enabled

PHPDaemon/FS/FileWatcher.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like