Issues in Section.php (master) - Issues in master - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1507)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

PHPDaemon/Config/Section.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace PHPDaemon\Config;

use PHPDaemon\Config\Entry\Generic;

/**
 * Config section
 *
 * @property Entry\Boolean enable
 * @property Entry\Boolean allowoverridebinpath
 * @property Entry\Boolean allowoverridechroot
 * @property Entry\Boolean allowoverrideuser
 * @property Entry\Boolean allowoverridegroup
 * @property Entry\Boolean allowoverridecwd
 * @property Entry\Generic cwd
 * @property Entry\Generic indexfiles
 * @property Entry\Generic mastersocket
 * @package    Core
 * @subpackage Config
 *
 * @author     Vasily Zorin <[email protected]>
 * @dynamic_fields
 */
class Section implements \ArrayAccess
{
    use \PHPDaemon\Traits\ClassWatchdog;

    /** @var */
    public $source;
    /** @var */
    public $revision;

    /**
     * Constructor
     * @param hash
     * @return object

     */
    public function __construct($arr = [])
    {
        foreach ($arr as $k => $v) {
            if (!is_object($v)) {
                $e = new Generic;
                $e->setHumanValue($v);
                $this->{$k} = $e;
            } else {
                $this->{$k} = $v;
            }
        }
    }

    /**
     * Count elements
     * @return integer
     */
    public function count()
    {
        return count($this) - 2;
    }

    /**
     * toArray handler
     * @return hash

     */
    public function toArray()
    {
        $arr = [];
        foreach ($this as $k => $entry) {

            if (!$entry instanceof Generic) {
                continue;
            }
            $arr[$k] = $entry->value;
        }
        return $arr;
    }

    /**
     * Checks if property exists
     * @param string Property name
     * @return boolean Exists?
     */

    public function offsetExists($prop)
    {
        $prop = $this->getRealPropertyName($prop);
        return property_exists($this, $prop);
    }

    /**
     * Get real property name
     * @param string Property name
     * @return string Real property name
     */
    public function getRealPropertyName($prop)
    {
        return str_replace('-', '', strtolower($prop));
    }

    /**
     * Get property by name
     * @param string Property name
     * @return mixed
     */
    public function offsetGet($prop)
    {
        $prop = $this->getRealPropertyName($prop);
        return isset($this->{$prop}) ? $this->{$prop}->value : null;
    }

    /**
     * Set property
     * @param string Property name
     * @param mixed  Value
     * @return void
     */
    public function offsetSet($prop, $value)
    {
        $prop = $this->getRealPropertyName($prop);
        $this->{$prop} = $value;
    }

    /**
     * Unset property
     * @param string Property name
     * @return void
     */
    public function offsetUnset($prop)
    {
        $prop = $this->getRealPropertyName($prop);
        unset($this->{$prop});
    }

    /**
     * Impose default config
     * @param array {"setting": "value"}
     * @return void
     */
    public function imposeDefault($settings = [])
    {
        foreach ($settings as $name => $value) {
            $name = strtolower(str_replace('-', '', $name));
            if (!isset($this->{$name})) {
                if (is_scalar($value)) {
                    $this->{$name} = new Generic($value);
                } else {
                    $this->{$name} = $value;
                }
            } elseif ($value instanceof Section) {
                $value->imposeDefault($value);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            } else {
                $current = $this->{$name};
                if (!is_object($value)) {
                    $this->{$name} = new Generic($value);
                } else {
                    $this->{$name} = $value;
                }
                $this->{$name}->setHumanValue($current->value);
                $this->{$name}->source = $current->source;
                $this->{$name}->revision = $current->revision;
            }
        }
    }
}


1			<?php
2			namespace PHPDaemon\Config;
3
4			use PHPDaemon\Config\Entry\Generic;
5
6			/**
7			* Config section
8			*
9			* @property Entry\Boolean enable
10			* @property Entry\Boolean allowoverridebinpath
11			* @property Entry\Boolean allowoverridechroot
12			* @property Entry\Boolean allowoverrideuser
13			* @property Entry\Boolean allowoverridegroup
14			* @property Entry\Boolean allowoverridecwd
15			* @property Entry\Generic cwd
16			* @property Entry\Generic indexfiles
17			* @property Entry\Generic mastersocket
18			* @package Core
19			* @subpackage Config
20			*
21			* @author Vasily Zorin <[email protected]>
22			* @dynamic_fields
23			*/
24			class Section implements \ArrayAccess
25			{
26			use \PHPDaemon\Traits\ClassWatchdog;
27
28			/** @var */
29			public $source;
30			/** @var */
31			public $revision;
32
33			/**
34			* Constructor
35			* @param hash
36			* @return object
			0 ignored issues – show Comprehensibility Best Practice introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
37			*/
38			public function __construct($arr = [])
39			{
40			foreach ($arr as $k => $v) {
41			if (!is_object($v)) {
42			$e = new Generic;
43			$e->setHumanValue($v);
44			$this->{$k} = $e;
45			} else {
46			$this->{$k} = $v;
47			}
48			}
49			}
50
51			/**
52			* Count elements
53			* @return integer
54			*/
55			public function count()
56			{
57			return count($this) - 2;
58			}
59
60			/**
61			* toArray handler
62			* @return hash
			0 ignored issues – show Documentation introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `array`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
63			*/
64			public function toArray()
65			{
66			$arr = [];
67			foreach ($this as $k => $entry) {
			0 ignored issues – show Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this` of type `this<PHPDaemon\Config\Section>` is not traversable. Loading history...
68			if (!$entry instanceof Generic) {
69			continue;
70			}
71			$arr[$k] = $entry->value;
72			}
73			return $arr;
74			}
75
76			/**
77			* Checks if property exists
78			* @param string Property name
79			* @return boolean Exists?
80			*/
81
82			public function offsetExists($prop)
83			{
84			$prop = $this->getRealPropertyName($prop);
85			return property_exists($this, $prop);
86			}
87
88			/**
89			* Get real property name
90			* @param string Property name
91			* @return string Real property name
92			*/
93			public function getRealPropertyName($prop)
94			{
95			return str_replace('-', '', strtolower($prop));
96			}
97
98			/**
99			* Get property by name
100			* @param string Property name
101			* @return mixed
102			*/
103			public function offsetGet($prop)
104			{
105			$prop = $this->getRealPropertyName($prop);
106			return isset($this->{$prop}) ? $this->{$prop}->value : null;
107			}
108
109			/**
110			* Set property
111			* @param string Property name
112			* @param mixed Value
113			* @return void
114			*/
115			public function offsetSet($prop, $value)
116			{
117			$prop = $this->getRealPropertyName($prop);
118			$this->{$prop} = $value;
119			}
120
121			/**
122			* Unset property
123			* @param string Property name
124			* @return void
125			*/
126			public function offsetUnset($prop)
127			{
128			$prop = $this->getRealPropertyName($prop);
129			unset($this->{$prop});
130			}
131
132			/**
133			* Impose default config
134			* @param array {"setting": "value"}
135			* @return void
136			*/
137			public function imposeDefault($settings = [])
138			{
139			foreach ($settings as $name => $value) {
140			$name = strtolower(str_replace('-', '', $name));
141			if (!isset($this->{$name})) {
142			if (is_scalar($value)) {
143			$this->{$name} = new Generic($value);
144			} else {
145			$this->{$name} = $value;
146			}
147			} elseif ($value instanceof Section) {
148			$value->imposeDefault($value);
			0 ignored issues – show Documentation introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$value` is of type `object<PHPDaemon\Config\Section>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
149			} else {
150			$current = $this->{$name};
151			if (!is_object($value)) {
152			$this->{$name} = new Generic($value);
153			} else {
154			$this->{$name} = $value;
155			}
156			$this->{$name}->setHumanValue($current->value);
157			$this->{$name}->source = $current->source;
158			$this->{$name}->revision = $current->revision;
159			}
160			}
161			}
162			}
163

kakserpom / phpdaemon

Issues (1507)

Security Analysis not enabled

PHPDaemon/Config/Section.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like