Issues in Connection.php (master) - Issues in master - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1507)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

PHPDaemon/Clients/WebSocket/Connection.php (12 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace PHPDaemon\Clients\WebSocket;

use PHPDaemon\Core\Daemon;
use PHPDaemon\Network\ClientConnection;
use PHPDaemon\Utils\Binary;
use PHPDaemon\Utils\Crypt;

/**
 * Class Connection
 * @package Clients
 * @subpackage WebSocket
 * @author Kozin Denis <[email protected]>
 * @author Vasily Zorin <[email protected]>
 */
class Connection extends ClientConnection
{

    /**
     * Globally Unique Identifier
     * @see http://tools.ietf.org/html/rfc6455
     */
    const GUID = '258EAFA5-E914-47DA-95CA-C5AB0DC85B11';

    const STATE_HEADER = 1;
    const STATE_DATA = 2;

    /**
     * @var string
     */
    protected $key;

    /**
     * @var array
     */
    public $headers = [];

    /**
     * @var int
     */
    protected $state = self::STATE_STANDBY;

    /**
     * @var array
     */
    protected $opCodes = [
        1 => Pool::TYPE_TEXT,
        2 => Pool::TYPE_BINARY,
        8 => Pool::TYPE_CLOSE,
        9 => Pool::TYPE_PING,
        10 => Pool::TYPE_PONG
    ];

    /**
     * @var string
     */
    public $type;

    /**
     * @var int
     */
    protected $pctLength = 0;

    /**
     * @var string
     */
    protected $isMasked = false;

    /**
     * Called when the connection is handshaked (at low-level), and peer is ready to recv. data
     * @return void
     */
    public function onReady()
    {
        $this->setWatermark(2, $this->pool->maxAllowedPacket);
        Crypt::randomString(16, null, function ($string) {
            $this->key = base64_encode($string);
            $this->write('GET /' . $this->path . " HTTP/1.1\r\nHost: " . $this->host . ($this->port != 80 ? ':' . $this->port : '') . "\r\nUpgrade: websocket\r\nConnection: Upgrade\r\nSec-WebSocket-Key: " . $this->key . "\r\nSec-WebSocket-Version: 13\r\n\r\n");
        });
    }

    /**
     * Called when new data received
     * @return void
     */
    public function onRead()
    {
        start:
        if ($this->state === static::STATE_HEADER) {
            $l = $this->getInputLength();
            if ($l < 2) {
                return;
            }
            $hdr = $this->look(2);
            $fb = Binary::getbitmap(ord($hdr));
            $fin = (bool)$fb[0];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $opCode = bindec(substr($fb, 4, 4));

            if (isset($this->opCodes[$opCode])) {
                $this->type = $this->opCodes[$opCode];
            } else {
                $this->log('opCode: ' . $opCode . ': unknown frame type');
                $this->finish();
                return;
            }
            $sb = ord(mb_orig_substr($hdr, 1));
            $sbm = Binary::getbitmap($sb);
            $this->isMasked = (bool)$sbm[0];
$answer = 42;

$correct = false;

$correct = (bool) $answer;
            $payloadLength = $sb & 127;

            if ($payloadLength <= 125) {
                $this->drain(2);
                $this->pctLength = $payloadLength;
            } elseif ($payloadLength === 126) {
                if ($l < 4) {
                    return;
                }
                $this->drain(2);
                $this->pctLength = Binary::b2i($this->read(2));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            } elseif ($payloadLength === 127) {
                if ($l < 10) {
                    return;
                }
                $this->drain(2);
                $this->pctLength = Binary::b2i($this->read(8));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }

            if ($this->pool->maxAllowedPacket < $this->pctLength) {

                Daemon::$process->log('max-allowed-packet (' . $this->pool->config->maxallowedpacket->getHumanValue() . ') exceed, aborting connection');
                $this->finish();
                return;
            }
            $this->setWatermark($this->pctLength + ($this->isMasked ? 4 : 0));
            $this->state = static::STATE_DATA;
        }

        if ($this->state === static::STATE_DATA) {
            if ($this->getInputLength() < $this->pctLength + ($this->isMasked ? 4 : 0)) {
                return;
            }
            $this->state = static::STATE_HEADER;
            $this->setWatermark(2);
            if ($this->isMasked) {
                $this->trigger('frame', static::mask($this->read(4), $this->read($this->pctLength)));

            } else {
                $this->trigger('frame', $this->read($this->pctLength));
            }
        }
        if ($this->state === static::STATE_STANDBY) {
            while (($line = $this->readLine()) !== null) {
                $line = trim($line);
                if ($line === '') {
                    $expectedKey = base64_encode(pack('H*', sha1($this->key . static::GUID)));
                    if (isset($this->headers['HTTP_SEC_WEBSOCKET_ACCEPT']) && $expectedKey === $this->headers['HTTP_SEC_WEBSOCKET_ACCEPT']) {
                        $this->state = static::STATE_HEADER;
                        if ($this->onConnected) {
                            $this->connected = true;
                            $this->onConnected->executeAll($this);
                            $this->onConnected = null;
                        }
                        $this->trigger('connected');
                        goto start;
                    } else {
                        Daemon::$process->log(__METHOD__ . ': Handshake failed. Connection to ' . $this->url . ' failed.');
                        $this->finish();
                    }
                } else {
                    $e = explode(': ', $line);
                    if (isset($e[1])) {
                        $this->headers['HTTP_' . strtoupper(strtr($e[0], ['-' => '_']))] = $e[1];
                    }
                }
            }
            return;
        }
        goto start;
    }

    /**
     * Send frame to WebSocket server
     * @param string $payload
     * @param string $type
     * @param boolean $isMasked
     */
    public function sendFrame($payload, $type = Pool::TYPE_TEXT, $isMasked = true)
    {
        $payloadLength = mb_orig_strlen($payload);
        if ($payloadLength > $this->pool->maxAllowedPacket) {

            Daemon::$process->log('max-allowed-packet (' . $this->pool->config->maxallowedpacket->getHumanValue() . ') exceed, aborting connection');
            return;
        }

        $firstByte = '';
        switch ($type) {
            case Pool::TYPE_TEXT:
                $firstByte = 129;
                break;
            case Pool::TYPE_CLOSE:
                $firstByte = 136;
                break;
            case Pool::TYPE_PING:
                $firstByte = 137;
                break;
            case Pool::TYPE_PONG:
                $firstByte = 138;
                break;
        }

        $hdrPacket = chr($firstByte);

        $isMaskedInt = $isMasked ? 128 : 0;
        if ($payloadLength <= 125) {
            $hdrPacket .= chr($payloadLength + $isMaskedInt);
        } elseif ($payloadLength <= 65535) {
            $hdrPacket .= chr(126 + $isMaskedInt) . // 126 + 128
                chr($payloadLength >> 8) .
                chr($payloadLength & 0xFF);
        } else {

            $hdrPacket .= chr(127 + $isMaskedInt) . // 127 + 128
                chr($payloadLength >> 56) .
                chr($payloadLength >> 48) .
                chr($payloadLength >> 40) .
                chr($payloadLength >> 32) .
                chr($payloadLength >> 24) .
                chr($payloadLength >> 16) .
                chr($payloadLength >> 8) .
                chr($payloadLength & 0xFF);
        }
        $this->write($hdrPacket);
        if ($isMasked) {

            $this->write($mask = chr(mt_rand(0, 0xFF)) .
                chr(mt_rand(0, 0xFF)) .
                chr(mt_rand(0, 0xFF)) .
                chr(mt_rand(0, 0xFF)));
            $this->write(static::mask($mask, $payload));
        } else {
            $this->write($payload);
        }
    }

    /**
     * @TODO
     * @return void
     */
    public function onFinish()
    {
        parent::onFinish();
        $this->trigger('disconnected');
    }

    /**
     * @TODO
     * @param  string $mask
     * @param  string $str
     * @return string
     */
    protected static function mask($mask, $str)
    {
        $out = '';
        $l = mb_orig_strlen($str);
        $ml = mb_orig_strlen($mask);
        while (($o = mb_orig_strlen($out)) < $l) {
            $out .= mb_orig_substr($str, $o, $ml) ^ $mask;
        }
        return $out;
    }
}


1		<?php
2		namespace PHPDaemon\Clients\WebSocket;
3
4		use PHPDaemon\Core\Daemon;
5		use PHPDaemon\Network\ClientConnection;
6		use PHPDaemon\Utils\Binary;
7		use PHPDaemon\Utils\Crypt;
8
9		/**
10		* Class Connection
11		* @package Clients
12		* @subpackage WebSocket
13		* @author Kozin Denis <[email protected]>
14		* @author Vasily Zorin <[email protected]>
15		*/
16		class Connection extends ClientConnection
17		{
18
19		/**
20		* Globally Unique Identifier
21		* @see http://tools.ietf.org/html/rfc6455
22		*/
23		const GUID = '258EAFA5-E914-47DA-95CA-C5AB0DC85B11';
24
25		const STATE_HEADER = 1;
26		const STATE_DATA = 2;
27
28		/**
29		* @var string
30		*/
31		protected $key;
32
33		/**
34		* @var array
35		*/
36		public $headers = [];
37
38		/**
39		* @var int
40		*/
41		protected $state = self::STATE_STANDBY;
42
43		/**
44		* @var array
45		*/
46		protected $opCodes = [
47		1 => Pool::TYPE_TEXT,
48		2 => Pool::TYPE_BINARY,
49		8 => Pool::TYPE_CLOSE,
50		9 => Pool::TYPE_PING,
51		10 => Pool::TYPE_PONG
52		];
53
54		/**
55		* @var string
56		*/
57		public $type;
58
59		/**
60		* @var int
61		*/
62		protected $pctLength = 0;
63
64		/**
65		* @var string
66		*/
67		protected $isMasked = false;
68
69		/**
70		* Called when the connection is handshaked (at low-level), and peer is ready to recv. data
71		* @return void
72		*/
73		public function onReady()
74		{
75		$this->setWatermark(2, $this->pool->maxAllowedPacket);
76		Crypt::randomString(16, null, function ($string) {
77		$this->key = base64_encode($string);
78		$this->write('GET /' . $this->path . " HTTP/1.1\r\nHost: " . $this->host . ($this->port != 80 ? ':' . $this->port : '') . "\r\nUpgrade: websocket\r\nConnection: Upgrade\r\nSec-WebSocket-Key: " . $this->key . "\r\nSec-WebSocket-Version: 13\r\n\r\n");
79		});
80		}
81
82		/**
83		* Called when new data received
84		* @return void
85		*/
86		public function onRead()
87		{
88		start:
89		if ($this->state === static::STATE_HEADER) {
90		$l = $this->getInputLength();
91		if ($l < 2) {
92		return;
93		}
94		$hdr = $this->look(2);
95		$fb = Binary::getbitmap(ord($hdr));
96		$fin = (bool)$fb[0];
		0 ignored issues – show Unused Code introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$fin` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
97		$opCode = bindec(substr($fb, 4, 4));
98
99		if (isset($this->opCodes[$opCode])) {
100		$this->type = $this->opCodes[$opCode];
101		} else {
102		$this->log('opCode: ' . $opCode . ': unknown frame type');
103		$this->finish();
104		return;
105		}
106		$sb = ord(mb_orig_substr($hdr, 1));
107		$sbm = Binary::getbitmap($sb);
108		$this->isMasked = (bool)$sbm[0];
		0 ignored issues – show Documentation Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$isMasked` was declared of type `string`, but `(bool) $sbm[0]` is of type `boolean`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
109		$payloadLength = $sb & 127;
110
111		if ($payloadLength <= 125) {
112		$this->drain(2);
113		$this->pctLength = $payloadLength;
114		} elseif ($payloadLength === 126) {
115		if ($l < 4) {
116		return;
117		}
118		$this->drain(2);
119		$this->pctLength = Binary::b2i($this->read(2));
		0 ignored issues – show Documentation introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->read(2)` is of type `string\|false`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\PHPDaemon\Utils\Binary::b2i($this->read(2))` can also be of type `double`. However, the property `$pctLength` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
120		} elseif ($payloadLength === 127) {
121		if ($l < 10) {
122		return;
123		}
124		$this->drain(2);
125		$this->pctLength = Binary::b2i($this->read(8));
		0 ignored issues – show Documentation introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->read(8)` is of type `string\|false`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\PHPDaemon\Utils\Binary::b2i($this->read(8))` can also be of type `double`. However, the property `$pctLength` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
126		}
127
128	View Code Duplication	if ($this->pool->maxAllowedPacket < $this->pctLength) {
		0 ignored issues – show Duplication introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
129		Daemon::$process->log('max-allowed-packet (' . $this->pool->config->maxallowedpacket->getHumanValue() . ') exceed, aborting connection');
130		$this->finish();
131		return;
132		}
133		$this->setWatermark($this->pctLength + ($this->isMasked ? 4 : 0));
134		$this->state = static::STATE_DATA;
135		}
136
137		if ($this->state === static::STATE_DATA) {
138		if ($this->getInputLength() < $this->pctLength + ($this->isMasked ? 4 : 0)) {
139		return;
140		}
141		$this->state = static::STATE_HEADER;
142		$this->setWatermark(2);
143		if ($this->isMasked) {
144		$this->trigger('frame', static::mask($this->read(4), $this->read($this->pctLength)));
		0 ignored issues – show Security Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->read(4)` targeting `PHPDaemon\Network\IOStream::read()` can also be of type `false`; however, `PHPDaemon\Clients\WebSocket\Connection::mask()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history... Security Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->read($this->pctLength)` targeting `PHPDaemon\Network\IOStream::read()` can also be of type `false`; however, `PHPDaemon\Clients\WebSocket\Connection::mask()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history...
145		} else {
146		$this->trigger('frame', $this->read($this->pctLength));
147		}
148		}
149		if ($this->state === static::STATE_STANDBY) {
150		while (($line = $this->readLine()) !== null) {
151		$line = trim($line);
152		if ($line === '') {
153		$expectedKey = base64_encode(pack('H*', sha1($this->key . static::GUID)));
154		if (isset($this->headers['HTTP_SEC_WEBSOCKET_ACCEPT']) && $expectedKey === $this->headers['HTTP_SEC_WEBSOCKET_ACCEPT']) {
155		$this->state = static::STATE_HEADER;
156		if ($this->onConnected) {
157		$this->connected = true;
158		$this->onConnected->executeAll($this);
159		$this->onConnected = null;
160		}
161		$this->trigger('connected');
162		goto start;
163		} else {
164		Daemon::$process->log(__METHOD__ . ': Handshake failed. Connection to ' . $this->url . ' failed.');
165		$this->finish();
166		}
167		} else {
168		$e = explode(': ', $line);
169		if (isset($e[1])) {
170		$this->headers['HTTP_' . strtoupper(strtr($e[0], ['-' => '_']))] = $e[1];
171		}
172		}
173		}
174		return;
175		}
176		goto start;
177		}
178
179		/**
180		* Send frame to WebSocket server
181		* @param string $payload
182		* @param string $type
183		* @param boolean $isMasked
184		*/
185		public function sendFrame($payload, $type = Pool::TYPE_TEXT, $isMasked = true)
186		{
187		$payloadLength = mb_orig_strlen($payload);
188	View Code Duplication	if ($payloadLength > $this->pool->maxAllowedPacket) {
		0 ignored issues – show Duplication introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
189		Daemon::$process->log('max-allowed-packet (' . $this->pool->config->maxallowedpacket->getHumanValue() . ') exceed, aborting connection');
190		return;
191		}
192
193		$firstByte = '';
194		switch ($type) {
195		case Pool::TYPE_TEXT:
196		$firstByte = 129;
197		break;
198		case Pool::TYPE_CLOSE:
199		$firstByte = 136;
200		break;
201		case Pool::TYPE_PING:
202		$firstByte = 137;
203		break;
204		case Pool::TYPE_PONG:
205		$firstByte = 138;
206		break;
207		}
208
209		$hdrPacket = chr($firstByte);
210
211		$isMaskedInt = $isMasked ? 128 : 0;
212		if ($payloadLength <= 125) {
213		$hdrPacket .= chr($payloadLength + $isMaskedInt);
214		} elseif ($payloadLength <= 65535) {
215		$hdrPacket .= chr(126 + $isMaskedInt) . // 126 + 128
216		chr($payloadLength >> 8) .
217		chr($payloadLength & 0xFF);
218	View Code Duplication	} else {
		0 ignored issues – show Duplication introduced 2015-12-08 06:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
219		$hdrPacket .= chr(127 + $isMaskedInt) . // 127 + 128
220		chr($payloadLength >> 56) .
221		chr($payloadLength >> 48) .
222		chr($payloadLength >> 40) .
223		chr($payloadLength >> 32) .
224		chr($payloadLength >> 24) .
225		chr($payloadLength >> 16) .
226		chr($payloadLength >> 8) .
227		chr($payloadLength & 0xFF);
228		}
229		$this->write($hdrPacket);
230	View Code Duplication	if ($isMasked) {
		0 ignored issues – show Duplication introduced 2015-12-08 06:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
231		$this->write($mask = chr(mt_rand(0, 0xFF)) .
232		chr(mt_rand(0, 0xFF)) .
233		chr(mt_rand(0, 0xFF)) .
234		chr(mt_rand(0, 0xFF)));
235		$this->write(static::mask($mask, $payload));
236		} else {
237		$this->write($payload);
238		}
239		}
240
241		/**
242		* @TODO
243		* @return void
244		*/
245		public function onFinish()
246		{
247		parent::onFinish();
248		$this->trigger('disconnected');
249		}
250
251		/**
252		* @TODO
253		* @param string $mask
254		* @param string $str
255		* @return string
256		*/
257		protected static function mask($mask, $str)
258		{
259		$out = '';
260		$l = mb_orig_strlen($str);
261		$ml = mb_orig_strlen($mask);
262		while (($o = mb_orig_strlen($out)) < $l) {
263		$out .= mb_orig_substr($str, $o, $ml) ^ $mask;
264		}
265		return $out;
266		}
267		}
268

kakserpom / phpdaemon

Issues (1507)

Security Analysis not enabled

PHPDaemon/Clients/WebSocket/Connection.php (12 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like