Issues in MultiEval.php (master) - Issues in master - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1507)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

PHPDaemon/Clients/Redis/MultiEval.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace PHPDaemon\Clients\Redis;

use PHPDaemon\Core\CallbackWrapper;

/**
 * Easy wrapper for queue of eval's
 *
 * @package    NetworkClients
 * @subpackage RedisClient
 * @author     Efimenko Dmitriy <[email protected]>
 *
 * Use exampe 1:
 * var $eval = $this->redis->meval($cb);
 * $eval->add('redis.call("set",KEYS[1],ARGV[1])', [$key1], [$arg1]);
 * $eval->add('redis.call("del",KEYS[1])', [$key2]);
 * $eval->add('redis.call("expireat",KEYS[1],ARGV[1])', $key1, $arg2);
 * $eval->exec();
 *
 * Use exampe 2:
 * var $eval = $this->redis->meval($cb);
 * $eval('redis.call("set",KEYS[1],ARGV[1])', [$key1], [$arg1]);
 * $eval('redis.call("del",KEYS[1])', [$key2]);
 * $eval('redis.call("expireat",KEYS[1],ARGV[1])', $key1, $arg2);
 * $eval();
 *
 * Result request:
 * eval 'redis.call("set",KEYS[1],ARGV[1]);redis.call("del",KEYS[2]);redis.call("expireat",KEYS[1],ARGV[2])' 2 $key1 $key2 $arg1 $arg2
 */
class MultiEval
{
    use \PHPDaemon\Traits\ClassWatchdog;
    use \PHPDaemon\Traits\StaticObjectWatchdog;

    /**
     * @var array Listeners
     */
    public $listeners = [];
    protected $pool;
    protected $stack = [];
    protected $cachedParams = false;

    /**
     * Constructor
     * @param callable $cb Callback
     * @param Pool $pool Redis pool
     */
    public function __construct($cb, $pool)
    {
        $this->pool = $pool;
        if ($cb !== null) {
            $this->addListener($cb);
        }
    }

    /**
     * Adds listener
     * @param callable $cb
     */
    public function addListener($cb)
    {
        $this->listeners[] = CallbackWrapper::wrap($cb);
    }

    /**
     * Clean up
     */
    public function cleanup()
    {
        $this->listeners = [];
    }

    /**
     * Adds eval command or calls execute() method
     * @return void
     */
    public function __invoke(...$args)
    {
        if (!count($args)) {
            $this->execute();
            return;
        }
        $this->add(...$args);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Runs the stack of commands
     */
    public function execute()
    {
        if (!count($this->stack)) {
            foreach ($this->listeners as $cb) {
                $cb($this->pool);
            }
            return;
        }

        $params = $this->getParams();
        $params[] = function ($redis) {
            foreach ($this->listeners as $cb) {
                $cb($redis);
            }
        };
        $this->pool->eval(...$params);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * Return params for eval command
     * @return array

     */
    public function getParams()
    {
        if ($this->cachedParams) {
            return $this->cachedParams;
        }

        $CMDS = [];
        $KEYS = [];
        $ARGV = [];
        $KEYNUM = 0;
        $ARGNUM = 0;

        foreach ($this->stack as $part) {
            list($cmd, $keys, $argv) = $part;

            if (!empty($keys)) {

                $cmd = preg_replace_callback('~KEYS\[(\d+)\]~', function ($m) use (&$KEYS, &$KEYNUM, $keys) {
                    $key = $keys[$m[1] - 1];
                    if (!isset($KEYS[$key])) {
                        $KEYS[$key] = ++$KEYNUM;
                    }
                    return 'KEYS[' . $KEYS[$key] . ']';
                }, $cmd);
            }

            if (!empty($argv)) {

                $cmd = preg_replace_callback('~ARGV\[(\d+)\]~', function ($m) use (&$ARGV, &$ARGNUM, $argv) {
                    $arg = $argv[$m[1] - 1];
                    if (!isset($ARGV[$arg])) {
                        $ARGV[$arg] = ++$ARGNUM;
                    }
                    return 'ARGV[' . $ARGV[$arg] . ']';
                }, $cmd);
            }

            $CMDS[] = $cmd;
        }

        return $this->cachedParams = array_merge(

            [implode(';', $CMDS), count($KEYS)],
            array_keys($KEYS),
            array_keys($ARGV)
        );
    }

    /**
     * Adds eval command in stack
     * @param string $cmd Lua script
     * @param mixed $keys Keys
     * @param mixed $argv Arguments
     */
    public function add($cmd, $keys = null, $argv = null)
    {
        if ($keys !== null) {

            if (is_scalar($keys)) {
                $keys = [(string)$keys];
            } elseif (!is_array($keys)) {
                throw new \Exception("Keys must be an array or scalar");
            }
        }
        if ($argv !== null) {

            if (is_scalar($argv)) {
                $argv = [(string)$argv];
            } elseif (!is_array($argv)) {
                throw new \Exception("Argv must be an array or scalar");
            }
        }

        $this->cachedParams = false;
        $this->stack[] = [$cmd, $keys, $argv];
    }
}


1		<?php
2		namespace PHPDaemon\Clients\Redis;
3
4		use PHPDaemon\Core\CallbackWrapper;
5
6		/**
7		* Easy wrapper for queue of eval's
8		*
9		* @package NetworkClients
10		* @subpackage RedisClient
11		* @author Efimenko Dmitriy <[email protected]>
12		*
13		* Use exampe 1:
14		* var $eval = $this->redis->meval($cb);
15		* $eval->add('redis.call("set",KEYS[1],ARGV[1])', [$key1], [$arg1]);
16		* $eval->add('redis.call("del",KEYS[1])', [$key2]);
17		* $eval->add('redis.call("expireat",KEYS[1],ARGV[1])', $key1, $arg2);
18		* $eval->exec();
19		*
20		* Use exampe 2:
21		* var $eval = $this->redis->meval($cb);
22		* $eval('redis.call("set",KEYS[1],ARGV[1])', [$key1], [$arg1]);
23		* $eval('redis.call("del",KEYS[1])', [$key2]);
24		* $eval('redis.call("expireat",KEYS[1],ARGV[1])', $key1, $arg2);
25		* $eval();
26		*
27		* Result request:
28		* eval 'redis.call("set",KEYS[1],ARGV[1]);redis.call("del",KEYS[2]);redis.call("expireat",KEYS[1],ARGV[2])' 2 $key1 $key2 $arg1 $arg2
29		*/
30		class MultiEval
31		{
32		use \PHPDaemon\Traits\ClassWatchdog;
33		use \PHPDaemon\Traits\StaticObjectWatchdog;
34
35		/**
36		* @var array Listeners
37		*/
38		public $listeners = [];
39		protected $pool;
40		protected $stack = [];
41		protected $cachedParams = false;
42
43		/**
44		* Constructor
45		* @param callable $cb Callback
46		* @param Pool $pool Redis pool
47		*/
48		public function __construct($cb, $pool)
49		{
50		$this->pool = $pool;
51		if ($cb !== null) {
52		$this->addListener($cb);
53		}
54		}
55
56		/**
57		* Adds listener
58		* @param callable $cb
59		*/
60		public function addListener($cb)
61		{
62		$this->listeners[] = CallbackWrapper::wrap($cb);
63		}
64
65		/**
66		* Clean up
67		*/
68		public function cleanup()
69		{
70		$this->listeners = [];
71		}
72
73		/**
74		* Adds eval command or calls execute() method
75		* @return void
76		*/
77		public function __invoke(...$args)
78		{
79		if (!count($args)) {
80		$this->execute();
81		return;
82		}
83		$this->add(...$args);
		0 ignored issues – show Documentation introduced 2016-05-16 19:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$args` is of type `array<integer,?>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
84		}
85
86		/**
87		* Runs the stack of commands
88		*/
89		public function execute()
90		{
91		if (!count($this->stack)) {
92		foreach ($this->listeners as $cb) {
93		$cb($this->pool);
94		}
95		return;
96		}
97
98		$params = $this->getParams();
99		$params[] = function ($redis) {
100		foreach ($this->listeners as $cb) {
101		$cb($redis);
102		}
103		};
104		$this->pool->eval(...$params);
		0 ignored issues – show Documentation Bug introduced 2016-03-02 14:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `eval` does not exist on `object<PHPDaemon\Clients\Redis\Pool>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
105		}
106
107		/**
108		* Return params for eval command
109		* @return array
		0 ignored issues – show Documentation introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `boolean\|array<string\|integer>`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
110		*/
111		public function getParams()
112		{
113		if ($this->cachedParams) {
114		return $this->cachedParams;
115		}
116
117		$CMDS = [];
118		$KEYS = [];
119		$ARGV = [];
120		$KEYNUM = 0;
121		$ARGNUM = 0;
122
123		foreach ($this->stack as $part) {
124		list($cmd, $keys, $argv) = $part;
125
126	View Code Duplication	if (!empty($keys)) {
		0 ignored issues – show Duplication introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127		$cmd = preg_replace_callback('~KEYS\[(\d+)\]~', function ($m) use (&$KEYS, &$KEYNUM, $keys) {
128		$key = $keys[$m[1] - 1];
129		if (!isset($KEYS[$key])) {
130		$KEYS[$key] = ++$KEYNUM;
131		}
132		return 'KEYS[' . $KEYS[$key] . ']';
133		}, $cmd);
134		}
135
136	View Code Duplication	if (!empty($argv)) {
		0 ignored issues – show Duplication introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
137		$cmd = preg_replace_callback('~ARGV\[(\d+)\]~', function ($m) use (&$ARGV, &$ARGNUM, $argv) {
138		$arg = $argv[$m[1] - 1];
139		if (!isset($ARGV[$arg])) {
140		$ARGV[$arg] = ++$ARGNUM;
141		}
142		return 'ARGV[' . $ARGV[$arg] . ']';
143		}, $cmd);
144		}
145
146		$CMDS[] = $cmd;
147		}
148
149		return $this->cachedParams = array_merge(
		0 ignored issues – show Documentation Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `array_merge(array(implod...YS), array_keys($ARGV))` of type `array<integer,string\|int...string","1":"integer"}>` is incompatible with the declared type `boolean` of property `$cachedParams`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
150		[implode(';', $CMDS), count($KEYS)],
151		array_keys($KEYS),
152		array_keys($ARGV)
153		);
154		}
155
156		/**
157		* Adds eval command in stack
158		* @param string $cmd Lua script
159		* @param mixed $keys Keys
160		* @param mixed $argv Arguments
161		*/
162		public function add($cmd, $keys = null, $argv = null)
163		{
164	View Code Duplication	if ($keys !== null) {
		0 ignored issues – show Duplication introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
165		if (is_scalar($keys)) {
166		$keys = [(string)$keys];
167		} elseif (!is_array($keys)) {
168		throw new \Exception("Keys must be an array or scalar");
169		}
170		}
171	View Code Duplication	if ($argv !== null) {
		0 ignored issues – show Duplication introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
172		if (is_scalar($argv)) {
173		$argv = [(string)$argv];
174		} elseif (!is_array($argv)) {
175		throw new \Exception("Argv must be an array or scalar");
176		}
177		}
178
179		$this->cachedParams = false;
180		$this->stack[] = [$cmd, $keys, $argv];
181		}
182		}
183

kakserpom / phpdaemon

Issues (1507)

Security Analysis not enabled

PHPDaemon/Clients/Redis/MultiEval.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like