PHPDaemon\Servers\WebSocket\Protocols\VE

Complexity

Total Complexity

27

Size/Duplication

Total Lines	169
Duplicated Lines	59.76 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	sendHandshakeReply()	0	20	4
B	_computeKey()	24	24	5
C	sendFrame()	26	42	8
C	onRead()	51	53	10

<?php
namespace PHPDaemon\Servers\WebSocket\Protocols;

use PHPDaemon\Core\Daemon;
use PHPDaemon\Servers\WebSocket\Connection;

/**
 * Websocket protocol hixie-76
 * @see         http://tools.ietf.org/html/draft-hixie-thewebsocketprotocol-76
 * @description Deprecated websocket protocol (IETF drafts 'hixie-76' or 'hybi-00')
 */
class VE extends Connection {
	const STRING = 0x00;
	const BINARY = 0x80;

	/**
	 * Sends a handshake message reply
	 * @param string Received data (no use in this class)
	 * @return boolean OK?
	 */
	public function sendHandshakeReply($extraHeaders = '') {
		if (!isset($this->server['HTTP_SEC_WEBSOCKET_ORIGIN'])) {
			$this->server['HTTP_SEC_WEBSOCKET_ORIGIN'] = '';
		}

		$this->write("HTTP/1.1 101 Web Socket Protocol Handshake\r\n"
				. "Upgrade: WebSocket\r\n"
				. "Connection: Upgrade\r\n"
				. "Sec-WebSocket-Origin: " . $this->server['HTTP_ORIGIN'] . "\r\n"
				. "Sec-WebSocket-Location: ws://" . $this->server['HTTP_HOST'] . $this->server['REQUEST_URI'] . "\r\n"
		);
		if ($this->pool->config->expose->value) {
			$this->writeln('X-Powered-By: phpDaemon/' . Daemon::$version);
		}
		if (isset($this->server['HTTP_SEC_WEBSOCKET_PROTOCOL'])) {
			$this->writeln("Sec-WebSocket-Protocol: " . $this->server['HTTP_SEC_WEBSOCKET_PROTOCOL']);
		}
		$this->writeln($extraHeaders);
		return true;
	}

	/**
	 * Computes key for Sec-WebSocket.
	 * @param string Key
	 * @return string Result
	 */
	protected function _computeKey($key) {

This method seems to be duplicated in your project.

		$spaces = 0;
		$digits = '';

		for ($i = 0, $s = strlen($key); $i < $s; ++$i) {
			$c = binarySubstr($key, $i, 1);

			if ($c === "\x20") {
				++$spaces;
			}
			elseif (ctype_digit($c)) {
				$digits .= $c;
			}
		}

		if ($spaces > 0) {
			$result = (float)floor($digits / $spaces);
		}
		else {
			$result = (float)$digits;
		}

		return pack('N', $result);
	}

	/**
	 * Sends a frame.
	 * @param  string   $data  Frame's data.
	 * @param  string   $type  Frame's type. ("STRING" OR "BINARY")

Should the type for parameter $type not be string|null?

	 * @param  callable $cb    Optional. Callback called when the frame is received by client.

Should the type for parameter $cb not be callable|null?

	 * @callback $cb ( )
	 * @return boolean         Success.
	 */
	public function sendFrame($data, $type = null, $cb = null) {
		if (!$this->handshaked) {
			return false;
		}

		if ($this->finished && $type !== 'CONNCLOSE') {
			return false;
		}

		// Binary
		$type = $this->getFrameType($type);
		if (($type & self::BINARY) === self::BINARY) {

This code seems to be duplicated across your project.

			$n   = strlen($data);
			$len = '';
			$pos = 0;

			char:

			++$pos;
			$c = $n >> 0 & 0x7F;
			$n >>= 7;

			if ($pos !== 1) {
				$c += 0x80;
			}

			if ($c !== 0x80) {
				$len = chr($c) . $len;
				goto char;
			};

			$this->write(chr(self::BINARY) . $len . $data);
		}
		// String
		else {
			$this->write(chr(self::STRING) . $data . "\xFF");
		}
		if ($cb !== null) {
			$this->onWriteOnce($cb);
		}
		return true;
	}

	/**
	 * Called when new data received
	 * @return void
	 */
	public function onRead() {
		while (($buflen = $this->getInputLength()) >= 2) {

This code seems to be duplicated across your project.

			$hdr       = $this->look(10);
			$frametype = ord(binarySubstr($hdr, 0, 1));
			if (($frametype & 0x80) === 0x80) {
				$len = 0;
				$i   = 0;
				do {
					if ($buflen < $i + 1) {
						return;
					}
					$b = ord(binarySubstr($hdr, ++$i, 1));
					$n = $b & 0x7F;
					$len *= 0x80;
					$len += $n;
				} while ($b > 0x80);

				if ($this->pool->maxAllowedPacket <= $len) {
					// Too big packet
					$this->finish();
					return;
				}

				if ($buflen < $len + $i + 1) {
					// not enough data yet
					return;
				}

				$this->drain($i + 1);
				$this->onFrame($this->read($len), $frametype);

It seems like $this->read($len) targeting PHPDaemon\Network\IOStream::read() can also be of type false; however, PHPDaemon\Servers\WebSocket\Connection::onFrame() does only seem to accept string, did you maybe forget to handle an error condition?

			}
			else {
				if (($p = $this->search("\xFF")) !== false) {
					if ($this->pool->maxAllowedPacket <= $p - 1) {
						// Too big packet
						$this->finish();
						return;
					}
					$this->drain(1);
					$data = $this->read($p);
					$this->drain(1);
					$this->onFrame($data, 'STRING');

It seems like $data defined by $this->read($p) on line 166 can also be of type false; however, PHPDaemon\Servers\WebSocket\Connection::onFrame() does only seem to accept string, did you maybe forget to handle an error condition?

				}
				else {
					if ($this->pool->maxAllowedPacket < $buflen - 1) {
						// Too big packet
						$this->finish();
						return;
					}
				}
			}
		}
	}
}