Input::parseMultipart() - Code Metrics - Inspection of "EventLoopContainer" - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — EventLoopContainer ( c9a84d...6e77fa )

by Vasily

created 2016-06-06 02:46 UTC

Input::parseMultipart() F

↳ Parent: Input

Complexity

Conditions	41
Paths	0

Size

Total Lines	139
Code Lines	102

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	2	Features	0

Metric	Value
cc	41
eloc	102
c	3
b	2
f	0
nc	0
nop	0
dl	0
loc	139
rs	2

How to fix Long Method Complexity

<?php
namespace PHPDaemon\HTTPRequest;

use PHPDaemon\Core\Daemon;
use PHPDaemon\Core\Debug;

/**
 * HTTP request input buffer
 * @package PHPDaemon\HTTPRequest
 * @author  Vasily Zorin <[email protected]>
 */
class Input extends \EventBuffer
{
    use \PHPDaemon\Traits\ClassWatchdog;
    use \PHPDaemon\Traits\StaticObjectWatchdog;

    /**
     * State: seek nearest boundary
     */
    const STATE_SEEKBOUNDARY = 0;
    /**
     * State: headers
     */
    const STATE_HEADERS = 1;
    /**
     * State: body
     */
    const STATE_BODY = 2;
    /**
     * State: upload
     */
    const STATE_UPLOAD = 3;
    /**
     * @var array Current Part
     */
    public $curPart;
    /**
     * @var string Boundary
     */
    protected $boundary;
    /**
     * @var integer Maximum file size from multi-part query
     */
    protected $maxFileSize = 0;
    /**
     * @var integer Readed
     */
    protected $readed = 0;
    /**
     * @var boolean Frozen
     */
    protected $frozen = false;
    /**
     * @var boolean EOF
     */
    protected $EOF = false;
    /**
     * @var array Content dispostion of current Part
     */
    protected $curPartDisp = false;
    /**
     * @var Generic Related Request
     */
    protected $req;
    /**
     * @var integer (self::STATE_*) State of multi-part processor
     */
    protected $state = self::STATE_SEEKBOUNDARY;
    /**
     * @var integer Size of current upload chunk
     */
    protected $curChunkSize;

    /**
     * Set boundary
     * @param  string $boundary Boundary
     * @return void
     */
    public function setBoundary($boundary)
    {
        $this->boundary = $boundary;
    }

    /**
     * Freeze input
     * @param  boolean $at_front At front. Default is true. If the front of a buffer is frozen, operations that drain data from the front of the buffer, or that prepend data to the buffer, will fail until it is unfrozen. If the back a buffer is frozen, operations that append data from the buffer will fail until it is unfrozen

     * @return void
     */
    public function freeze($at_front = false)
    {
        $this->frozen = true;
        //parent::freeze($at_front); // @TODO: discuss related pecl-event/libevent bug

    }

    /**
     * Unfreeze input
     * @param  boolean $at_front At front. Default is true. If the front of a buffer is frozen, operations that drain data from the front of the buffer, or that prepend data to the buffer, will fail until it is unfrozen. If the back a buffer is frozen, operations that append data from the buffer will fail until it is unfrozen

     * @return void
     */
    public function unfreeze($at_front = false)
    {
        $f = $this->frozen;
        $this->frozen = false;
        //parent::unfreeze($at_front); // @TODO: discuss related pecl-event/libevent bug

        $this->onRead();
        if ($f && $this->EOF) {
            $this->onEOF();
        }
        $this->req->checkIfReady();
    }

    /**
     * onRead
     * @return void
     */
    protected function onRead()
    {
        if (!empty($this->boundary)) {
            $this->req->attrs->input->parseMultipart();
        }
        if (($this->req->attrs->contentLength <= $this->readed) && !$this->EOF) {
            $this->sendEOF();
        }
    }

    /**
     * Send EOF
     * @return void
     */
    public function sendEOF()
    {
        if (!$this->EOF) {
            $this->EOF = true;
            $this->onEOF();
        }
    }

    /**
     * onEOF
     * @return void
     */
    protected function onEOF()
    {
        if (!$this->req) {
            return;
        }
        if ($this->frozen) {
            return;
        }
        if ($this->req->attrs->inputDone) {
            return;
        }
        $this->curPart =& $foo;

        $this->req->attrs->inputDone = true;
        $this->req->attrs->raw = '';
        if (($l = $this->length) > 0) {
            $this->req->attrs->raw = $this->read($l);
            if (isset($this->req->contype['application/x-www-form-urlencoded'])) {
                Generic::parseStr($this->req->attrs->raw, $this->req->attrs->post);
            }
            if (isset($this->req->contype['application/json']) || isset($this->req->contype['application/x-json'])) {
                $this->req->attrs->post = json_decode($this->req->attrs->raw, true);
            }
        }
        $this->req->postPrepare();
        $this->req->checkIfReady();
    }

    /**
     * Is frozen?
     * @return boolean
     */
    public function isFrozen()
    {
        return $this->frozen;
    }

    /**
     * Is EOF?
     * @return boolean
     */
    public function isEof()
    {
        return $this->EOF;
    }

    /**
     * Set request
     * @param  Generic $req Request
     * @return void
     */
    public function setRequest(Generic $req)
    {
        $this->req = $req;
    }

    /**
     * Moves $n bytes from input buffer to arbitrary buffer
     * @param  \EventBuffer $buf Source nuffer
     * @return integer
     */
    public function readFromBuffer(\EventBuffer $buf)
    {
        if (!$this->req) {
            return false;
        }
        $n = min($this->req->attrs->contentLength - $this->readed, $buf->length);
        if ($n > 0) {
            $m = $this->appendFrom($buf, $n);
            $this->readed += $m;
            if ($m > 0) {
                $this->onRead();
            }
        } else {
            $this->onRead();
            return 0;
        }
        return $m;
    }

    /**
     * Append string to input buffer
     * @param  string $chunk Piece of request input
     * @param  boolean $final Final call is THIS SEQUENCE of calls (not mandatory final in request)?
     * @return void
     */
    public function readFromString($chunk, $final = true)
    {
        $this->add($chunk);
        $this->readed += mb_orig_strlen($chunk);
        if ($final) {
            $this->onRead();
        }
    }


    /**
     * Read from buffer without draining
     * @param  integer $n Number of bytes to read
     * @param  integer $o Offset
     * @return string
     */
    public function look($n, $o = 0)
    {
        if ($this->length <= $o) {
            return '';
        }
        return $this->substr($o, $n);
    }


    /**
     * Parses multipart
     * @return void
     */
    public function parseMultipart()
    {
        start:
        if ($this->frozen) {
            return;
        }
        if ($this->state === self::STATE_SEEKBOUNDARY) {
            // seek to the nearest boundary
            if (($p = $this->search('--' . $this->boundary . "\r\n")) === false) {
                return;
            }
            // we have found the nearest boundary at position $p
            if ($p > 0) {
                $extra = $this->read($p);
                if ($extra !== "\r\n") {
                    $this->log('parseBody(): SEEKBOUNDARY: got unexpected data before boundary (length = ' . $p . '): ' . Debug::exportBytes($extra));

                }
            }
            $this->drain(mb_orig_strlen($this->boundary) + 4); // drain
            $this->state = self::STATE_HEADERS;
        }
        if ($this->state === self::STATE_HEADERS) {
            // parse the part's headers
            $this->curPartDisp = false;

            $i = 0;
            do {
                $l = $this->readline(\EventBuffer::EOL_CRLF);
                if ($l === null) {
                    return;
                }
                if ($l === '') {
                    break;
                }

                $e = explode(':', $l, 2);
                $e[0] = strtr(strtoupper($e[0]), Generic::$htr);
                if (isset($e[1])) {
                    $e[1] = ltrim($e[1]);
                }
                if (($e[0] === 'CONTENT_DISPOSITION') && isset($e[1])) {
                    Generic::parseStr($e[1], $this->curPartDisp, true);
                    if (!isset($this->curPartDisp['form-data'])) {
                        break;
                    }
                    if (!isset($this->curPartDisp['name'])) {
                        break;
                    }
                    $this->curPartDisp['name'] = trim($this->curPartDisp['name'], '"');
                    $name = $this->curPartDisp['name'];
                    if (isset($this->curPartDisp['filename'])) {
                        $this->curPartDisp['filename'] = trim($this->curPartDisp['filename'], '"');
                        if (!ini_get('file_uploads')) {
                            break;
                        }
                        $this->req->attrs->files[$name] = [
                            'name' => $this->curPartDisp['filename'],
                            'type' => '',
                            'tmp_name' => null,
                            'fp' => null,
                            'error' => UPLOAD_ERR_OK,
                            'size' => 0,
                        ];
                        $this->curPart = &$this->req->attrs->files[$name];
                        $this->req->onUploadFileStart($this);
                        $this->state = self::STATE_UPLOAD;
                    } else {
                        $this->curPart = &$this->req->attrs->post[$name];
                        $this->curPart = '';

                    }
                } elseif (($e[0] === 'CONTENT_TYPE') && isset($e[1])) {
                    if (isset($this->curPartDisp['name']) && isset($this->curPartDisp['filename'])) {
                        $this->curPart['type'] = $e[1];
                    }
                }
            } while ($i++ < 10);
            if ($this->state === self::STATE_HEADERS) {
                $this->state = self::STATE_BODY;
            }
            goto start;
        }
        if (($this->state === self::STATE_BODY) || ($this->state === self::STATE_UPLOAD)) {
            // process the body
            $chunkEnd1 = $this->search("\r\n--" . $this->boundary . "\r\n");
            $chunkEnd2 = $this->search("\r\n--" . $this->boundary . "--\r\n");
            if ($chunkEnd1 === false && $chunkEnd2 === false) {
                /*  we have only piece of Part in buffer */
                $l = $this->length - mb_orig_strlen($this->boundary) - 8;
                if ($l <= 0) {
                    return;
                }
                if (($this->state === self::STATE_BODY) && isset($this->curPartDisp['name'])) {
                    $this->curPart .= $this->read($l);
                } elseif (($this->state === self::STATE_UPLOAD) && isset($this->curPartDisp['filename'])) {
                    $this->curPart['size'] += $l;
                    if ($this->req->getUploadMaxSize() < $this->curPart['size']) {
                        $this->curPart['error'] = UPLOAD_ERR_INI_SIZE;
                        $this->req->header('413 Request Entity Too Large');
                        $this->req->out('');
                        $this->req->finish();
                    } elseif ($this->maxFileSize && ($this->maxFileSize < $this->curPart['size'])) {
                        $this->curPart['error'] = UPLOAD_ERR_FORM_SIZE;
                        $this->req->header('413 Request Entity Too Large');
                        $this->req->out('');
                        $this->req->finish();
                    } else {
                        $this->curChunkSize = $l;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
                        $this->req->onUploadFileChunk($this);
                    }
                }
            } else {    /* we have entire Part in buffer */

                if ($chunkEnd1 === false) {
                    $l = $chunkEnd2;
                    $endOfMsg = true;
                } else {
                    $l = $chunkEnd1;
                    $endOfMsg = false;
                }

                if (($this->state === self::STATE_BODY) && isset($this->curPartDisp['name'])) {
                    $this->curPart .= $this->read($l);
                    if ($this->curPartDisp['name'] === 'MAX_FILE_SIZE') {
                        $this->maxFileSize = (int)$this->curPart;
                    }
                } elseif (($this->state === self::STATE_UPLOAD) && isset($this->curPartDisp['filename'])) {
                    $this->curPart['size'] += $l;
                    $this->curChunkSize = $l;
                    $this->req->onUploadFileChunk($this, true);
                }

                $this->state = self::STATE_SEEKBOUNDARY;
                if ($endOfMsg) { // end of whole message
                    $this->sendEOF();
                } else {
                    goto start; // let's read the next part
                }
            }
        }
    }

    /**
     * Log
     * @param  string $msg Message
     * @return void
     */
    public function log($msg)
    {
        Daemon::log(get_class($this) . ': ' . $msg);
    }

    /**
     * Get current upload chunk as string
     * @return string Chunk body
     */
    public function getChunkString()
    {
        if (!$this->curChunkSize) {
            return false;
        }
        $chunk = $this->read($this->curChunkSize);
        $this->curChunkSize = null;
        return $chunk;
    }

    /**
     * Write current upload chunk to file descriptor
     * @todo   It is not supported yet (callback missing in EventBuffer->write())

     * @param  mixed $fd File destriptor
     * @param  callable $cb Callback

     * @return boolean      Success
     */
    public function writeChunkToFd($fd, $cb = null)
    {
        return false; // It is not supported yet (callback missing in EventBuffer->write())
        if (!$this->curChunkSize) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            return false;
        }
        $this->write($fd, $this->curChunkSize);
        $this->curChunkSize = null;
        return true;
    }
}


1			<?php
2			namespace PHPDaemon\HTTPRequest;
3
4			use PHPDaemon\Core\Daemon;
5			use PHPDaemon\Core\Debug;
6
7			/**
8			* HTTP request input buffer
9			* @package PHPDaemon\HTTPRequest
10			* @author Vasily Zorin <[email protected]>
11			*/
12			class Input extends \EventBuffer
13			{
14			use \PHPDaemon\Traits\ClassWatchdog;
15			use \PHPDaemon\Traits\StaticObjectWatchdog;
16
17			/**
18			* State: seek nearest boundary
19			*/
20			const STATE_SEEKBOUNDARY = 0;
21			/**
22			* State: headers
23			*/
24			const STATE_HEADERS = 1;
25			/**
26			* State: body
27			*/
28			const STATE_BODY = 2;
29			/**
30			* State: upload
31			*/
32			const STATE_UPLOAD = 3;
33			/**
34			* @var array Current Part
35			*/
36			public $curPart;
37			/**
38			* @var string Boundary
39			*/
40			protected $boundary;
41			/**
42			* @var integer Maximum file size from multi-part query
43			*/
44			protected $maxFileSize = 0;
45			/**
46			* @var integer Readed
47			*/
48			protected $readed = 0;
49			/**
50			* @var boolean Frozen
51			*/
52			protected $frozen = false;
53			/**
54			* @var boolean EOF
55			*/
56			protected $EOF = false;
57			/**
58			* @var array Content dispostion of current Part
59			*/
60			protected $curPartDisp = false;
61			/**
62			* @var Generic Related Request
63			*/
64			protected $req;
65			/**
66			* @var integer (self::STATE_*) State of multi-part processor
67			*/
68			protected $state = self::STATE_SEEKBOUNDARY;
69			/**
70			* @var integer Size of current upload chunk
71			*/
72			protected $curChunkSize;
73
74			/**
75			* Set boundary
76			* @param string $boundary Boundary
77			* @return void
78			*/
79			public function setBoundary($boundary)
80			{
81			$this->boundary = $boundary;
82			}
83
84			/**
85			* Freeze input
86			* @param boolean $at_front At front. Default is true. If the front of a buffer is frozen, operations that drain data from the front of the buffer, or that prepend data to the buffer, will fail until it is unfrozen. If the back a buffer is frozen, operations that append data from the buffer will fail until it is unfrozen
			0 ignored issues – show Coding Style introduced 2016-05-18 23:30 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 327 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
87			* @return void
88			*/
89			public function freeze($at_front = false)
90			{
91			$this->frozen = true;
92			//parent::freeze($at_front); // @TODO: discuss related pecl-event/libevent bug
			0 ignored issues – show Coding Style Best Practice introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history... Unused Code Comprehensibility introduced 2016-02-05 10:49 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
93			}
94
95			/**
96			* Unfreeze input
97			* @param boolean $at_front At front. Default is true. If the front of a buffer is frozen, operations that drain data from the front of the buffer, or that prepend data to the buffer, will fail until it is unfrozen. If the back a buffer is frozen, operations that append data from the buffer will fail until it is unfrozen
			0 ignored issues – show Coding Style introduced 2016-05-18 23:30 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 327 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
98			* @return void
99			*/
100			public function unfreeze($at_front = false)
101			{
102			$f = $this->frozen;
103			$this->frozen = false;
104			//parent::unfreeze($at_front); // @TODO: discuss related pecl-event/libevent bug
			0 ignored issues – show Coding Style Best Practice introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history... Unused Code Comprehensibility introduced 2016-02-05 10:49 UTC by Report Bug Copy Issue Report `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
105			$this->onRead();
106			if ($f && $this->EOF) {
107			$this->onEOF();
108			}
109			$this->req->checkIfReady();
110			}
111
112			/**
113			* onRead
114			* @return void
115			*/
116			protected function onRead()
117			{
118			if (!empty($this->boundary)) {
119			$this->req->attrs->input->parseMultipart();
120			}
121			if (($this->req->attrs->contentLength <= $this->readed) && !$this->EOF) {
122			$this->sendEOF();
123			}
124			}
125
126			/**
127			* Send EOF
128			* @return void
129			*/
130			public function sendEOF()
131			{
132			if (!$this->EOF) {
133			$this->EOF = true;
134			$this->onEOF();
135			}
136			}
137
138			/**
139			* onEOF
140			* @return void
141			*/
142			protected function onEOF()
143			{
144			if (!$this->req) {
145			return;
146			}
147			if ($this->frozen) {
148			return;
149			}
150			if ($this->req->attrs->inputDone) {
151			return;
152			}
153			$this->curPart =& $foo;
			0 ignored issues – show Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report The variable `$foo` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
154			$this->req->attrs->inputDone = true;
155			$this->req->attrs->raw = '';
156			if (($l = $this->length) > 0) {
157			$this->req->attrs->raw = $this->read($l);
158			if (isset($this->req->contype['application/x-www-form-urlencoded'])) {
159			Generic::parseStr($this->req->attrs->raw, $this->req->attrs->post);
160			}
161			if (isset($this->req->contype['application/json']) \|\| isset($this->req->contype['application/x-json'])) {
162			$this->req->attrs->post = json_decode($this->req->attrs->raw, true);
163			}
164			}
165			$this->req->postPrepare();
166			$this->req->checkIfReady();
167			}
168
169			/**
170			* Is frozen?
171			* @return boolean
172			*/
173			public function isFrozen()
174			{
175			return $this->frozen;
176			}
177
178			/**
179			* Is EOF?
180			* @return boolean
181			*/
182			public function isEof()
183			{
184			return $this->EOF;
185			}
186
187			/**
188			* Set request
189			* @param Generic $req Request
190			* @return void
191			*/
192			public function setRequest(Generic $req)
193			{
194			$this->req = $req;
195			}
196
197			/**
198			* Moves $n bytes from input buffer to arbitrary buffer
199			* @param \EventBuffer $buf Source nuffer
200			* @return integer
201			*/
202			public function readFromBuffer(\EventBuffer $buf)
203			{
204			if (!$this->req) {
205			return false;
206			}
207			$n = min($this->req->attrs->contentLength - $this->readed, $buf->length);
208			if ($n > 0) {
209			$m = $this->appendFrom($buf, $n);
210			$this->readed += $m;
211			if ($m > 0) {
212			$this->onRead();
213			}
214			} else {
215			$this->onRead();
216			return 0;
217			}
218			return $m;
219			}
220
221			/**
222			* Append string to input buffer
223			* @param string $chunk Piece of request input
224			* @param boolean $final Final call is THIS SEQUENCE of calls (not mandatory final in request)?
225			* @return void
226			*/
227			public function readFromString($chunk, $final = true)
228			{
229			$this->add($chunk);
230			$this->readed += mb_orig_strlen($chunk);
231			if ($final) {
232			$this->onRead();
233			}
234			}
235
236
237			/**
238			* Read from buffer without draining
239			* @param integer $n Number of bytes to read
240			* @param integer $o Offset
241			* @return string
242			*/
243			public function look($n, $o = 0)
244			{
245			if ($this->length <= $o) {
246			return '';
247			}
248			return $this->substr($o, $n);
249			}
250
251
252			/**
253			* Parses multipart
254			* @return void
255			*/
256			public function parseMultipart()
257			{
258			start:
259			if ($this->frozen) {
260			return;
261			}
262			if ($this->state === self::STATE_SEEKBOUNDARY) {
263			// seek to the nearest boundary
264			if (($p = $this->search('--' . $this->boundary . "\r\n")) === false) {
265			return;
266			}
267			// we have found the nearest boundary at position $p
268			if ($p > 0) {
269			$extra = $this->read($p);
270			if ($extra !== "\r\n") {
271			$this->log('parseBody(): SEEKBOUNDARY: got unexpected data before boundary (length = ' . $p . '): ' . Debug::exportBytes($extra));
			0 ignored issues – show Coding Style introduced 2016-02-05 10:49 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 150 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
272			}
273			}
274			$this->drain(mb_orig_strlen($this->boundary) + 4); // drain
275			$this->state = self::STATE_HEADERS;
276			}
277			if ($this->state === self::STATE_HEADERS) {
278			// parse the part's headers
279			$this->curPartDisp = false;
			0 ignored issues – show Documentation Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report It seems like `false` of type `false` is incompatible with the declared type `array` of property `$curPartDisp`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
280			$i = 0;
281			do {
282			$l = $this->readline(\EventBuffer::EOL_CRLF);
283			if ($l === null) {
284			return;
285			}
286			if ($l === '') {
287			break;
288			}
289
290			$e = explode(':', $l, 2);
291			$e[0] = strtr(strtoupper($e[0]), Generic::$htr);
292			if (isset($e[1])) {
293			$e[1] = ltrim($e[1]);
294			}
295			if (($e[0] === 'CONTENT_DISPOSITION') && isset($e[1])) {
296			Generic::parseStr($e[1], $this->curPartDisp, true);
297			if (!isset($this->curPartDisp['form-data'])) {
298			break;
299			}
300			if (!isset($this->curPartDisp['name'])) {
301			break;
302			}
303			$this->curPartDisp['name'] = trim($this->curPartDisp['name'], '"');
304			$name = $this->curPartDisp['name'];
305			if (isset($this->curPartDisp['filename'])) {
306			$this->curPartDisp['filename'] = trim($this->curPartDisp['filename'], '"');
307			if (!ini_get('file_uploads')) {
308			break;
309			}
310			$this->req->attrs->files[$name] = [
311			'name' => $this->curPartDisp['filename'],
312			'type' => '',
313			'tmp_name' => null,
314			'fp' => null,
315			'error' => UPLOAD_ERR_OK,
316			'size' => 0,
317			];
318			$this->curPart = &$this->req->attrs->files[$name];
319			$this->req->onUploadFileStart($this);
320			$this->state = self::STATE_UPLOAD;
321			} else {
322			$this->curPart = &$this->req->attrs->post[$name];
323			$this->curPart = '';
			0 ignored issues – show Documentation Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report It seems like `''` of type `string` is incompatible with the declared type `array` of property `$curPart`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
324			}
325			} elseif (($e[0] === 'CONTENT_TYPE') && isset($e[1])) {
326			if (isset($this->curPartDisp['name']) && isset($this->curPartDisp['filename'])) {
327			$this->curPart['type'] = $e[1];
328			}
329			}
330			} while ($i++ < 10);
331			if ($this->state === self::STATE_HEADERS) {
332			$this->state = self::STATE_BODY;
333			}
334			goto start;
335			}
336			if (($this->state === self::STATE_BODY) \|\| ($this->state === self::STATE_UPLOAD)) {
337			// process the body
338			$chunkEnd1 = $this->search("\r\n--" . $this->boundary . "\r\n");
339			$chunkEnd2 = $this->search("\r\n--" . $this->boundary . "--\r\n");
340			if ($chunkEnd1 === false && $chunkEnd2 === false) {
341			/* we have only piece of Part in buffer */
342			$l = $this->length - mb_orig_strlen($this->boundary) - 8;
343			if ($l <= 0) {
344			return;
345			}
346			if (($this->state === self::STATE_BODY) && isset($this->curPartDisp['name'])) {
347			$this->curPart .= $this->read($l);
348			} elseif (($this->state === self::STATE_UPLOAD) && isset($this->curPartDisp['filename'])) {
349			$this->curPart['size'] += $l;
350			if ($this->req->getUploadMaxSize() < $this->curPart['size']) {
351			$this->curPart['error'] = UPLOAD_ERR_INI_SIZE;
352			$this->req->header('413 Request Entity Too Large');
353			$this->req->out('');
354			$this->req->finish();
355			} elseif ($this->maxFileSize && ($this->maxFileSize < $this->curPart['size'])) {
356			$this->curPart['error'] = UPLOAD_ERR_FORM_SIZE;
357			$this->req->header('413 Request Entity Too Large');
358			$this->req->out('');
359			$this->req->finish();
360			} else {
361			$this->curChunkSize = $l;
			0 ignored issues – show Documentation Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report It seems like `$l` can also be of type `double`. However, the property `$curChunkSize` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
362			$this->req->onUploadFileChunk($this);
363			}
364			}
365			} else { /* we have entire Part in buffer */
366
367			if ($chunkEnd1 === false) {
368			$l = $chunkEnd2;
369			$endOfMsg = true;
370			} else {
371			$l = $chunkEnd1;
372			$endOfMsg = false;
373			}
374
375			if (($this->state === self::STATE_BODY) && isset($this->curPartDisp['name'])) {
376			$this->curPart .= $this->read($l);
377			if ($this->curPartDisp['name'] === 'MAX_FILE_SIZE') {
378			$this->maxFileSize = (int)$this->curPart;
379			}
380			} elseif (($this->state === self::STATE_UPLOAD) && isset($this->curPartDisp['filename'])) {
381			$this->curPart['size'] += $l;
382			$this->curChunkSize = $l;
383			$this->req->onUploadFileChunk($this, true);
384			}
385
386			$this->state = self::STATE_SEEKBOUNDARY;
387			if ($endOfMsg) { // end of whole message
388			$this->sendEOF();
389			} else {
390			goto start; // let's read the next part
391			}
392			}
393			}
394			}
395
396			/**
397			* Log
398			* @param string $msg Message
399			* @return void
400			*/
401			public function log($msg)
402			{
403			Daemon::log(get_class($this) . ': ' . $msg);
404			}
405
406			/**
407			* Get current upload chunk as string
408			* @return string Chunk body
409			*/
410			public function getChunkString()
411			{
412			if (!$this->curChunkSize) {
413			return false;
414			}
415			$chunk = $this->read($this->curChunkSize);
416			$this->curChunkSize = null;
417			return $chunk;
418			}
419
420			/**
421			* Write current upload chunk to file descriptor
422			* @todo It is not supported yet (callback missing in EventBuffer->write())
			0 ignored issues – show Coding Style introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Comment refers to a TODO task This check looks `TODO` comments that have been left in the code. ``TODO``s show that something is left unfinished and should be attended to. Loading history...
423			* @param mixed $fd File destriptor
424			* @param callable $cb Callback
			0 ignored issues – show Documentation introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Should the type for parameter `$cb` not be `callable\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
425			* @return boolean Success
426			*/
427			public function writeChunkToFd($fd, $cb = null)
428			{
429			return false; // It is not supported yet (callback missing in EventBuffer->write())
430			if (!$this->curChunkSize) {
			0 ignored issues – show Unused Code introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report `// It is not supported y...) { return false; }` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history... Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report The variable `$this` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
431			return false;
432			}
433			$this->write($fd, $this->curChunkSize);
434			$this->curChunkSize = null;
435			return true;
436			}
437			}
438

kakserpom / phpdaemon

Push — EventLoopContainer ( c9a84d...6e77fa )

Input::parseMultipart() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like