AppResolver::getInstance() - Code Metrics - Inspection of "Fix getAppFullname -> getAppFullName (camelcase)" - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#264)

by Дмитрий

created 2016-07-10 08:24 UTC

AppResolver::getInstance() D

↳ Parent: AppResolver

Complexity

Conditions	10
Paths	12

Size

Total Lines	34
Code Lines	22

Duplication

Lines	8
Ratio	23.53 %

Importance

Changes	4
Bugs	2	Features	0

Metric	Value
cc	10
eloc	22
c	4
b	2
f	0
nc	12
nop	4
dl	8
loc	34
rs	4.8196

How to fix Complexity

<?php
namespace PHPDaemon\Core;

use PHPDaemon\Config;

/**
 * Application resolver
 * @package PHPDaemon\Core
 * @author  Vasily Zorin <[email protected]>
 */
class AppResolver
{
    use \PHPDaemon\Traits\ClassWatchdog;
    use \PHPDaemon\Traits\StaticObjectWatchdog;

    /**
     * Preloads applications
     * @param  boolean $privileged If true, we are in the pre-fork stage
     * @return void
     */
    public function preload($privileged = false)
    {
        foreach (Daemon::$config as $fullname => $section) {

            if (!$section instanceof Config\Section) {
                continue;
            }
            if (isset($section->limitinstances)) {
                continue;
            }
            if ((isset($section->enable) && $section->enable->value) ||
                (!isset($section->enable) && !isset($section->disable))
            ) {
                if (mb_orig_strpos($fullname, ':') === false) {
                    $fullname .= ':';
                }
                list($appName, $instance) = explode(':', $fullname, 2);
                $appNameLower = strtolower($appName);
                if ($appNameLower !== 'pool' && $privileged && (!isset($section->privileged) || !$section->privileged->value)) {

                    continue;
                }
                if (isset(Daemon::$appInstances[$appNameLower][$instance])) {
                    continue;
                }
                $this->getInstance($appName, $instance, true, true);
            }
        }
    }

    /**
     * Gets instance of application
     * @param  string $appName Application name
     * @param  string $instance Instance name
     * @param  boolean $spawn If true, we spawn an instance if absent
     * @param  boolean $preload If true, worker is at the preload stage
     * @return object $instance AppInstance
     */
    public function getInstance($appName, $instance = '', $spawn = true, $preload = false)
    {
        $class = ClassFinder::find($appName, 'Applications');
        if (isset(Daemon::$appInstances[$class][$instance])) {
            return Daemon::$appInstances[$class][$instance];
        }
        if (!$spawn) {
            return false;
        }
        $fullname = $this->getAppFullName($appName, $instance);
        if (!class_exists($class)) {

            Daemon::$process->log(__METHOD__ . ': unable to find application class ' . json_encode($class) . '\'');
            return false;
        }
        if (!is_subclass_of($class, '\\PHPDaemon\\Core\\AppInstance')) {

            Daemon::$process->log(__METHOD__ . ': class ' . json_encode($class) . '\' found, but skipped as long as it is not subclass of \\PHPDaemon\\Core\\AppInstance');

            return false;
        }
        $fullnameClass = $this->getAppFullName($class, $instance);
        if ($fullname !== $fullnameClass && isset(Daemon::$config->{$fullname})) {
            Daemon::$config->renameSection($fullname, $fullnameClass);
        }
        if (!$preload) {
            /** @noinspection PhpUndefinedVariableInspection */
            if (!$class::$runOnDemand) {
                return false;
            }
            if (isset(Daemon::$config->{$fullnameClass}->limitinstances)) {
                return false;
            }
        }

        return new $class($instance);
    }

    /**
     * Resolve full name of application by its class and name
     * @param  string $appName Application name
     * @param  string $instance Application class
     * @return string
     */
    public function getAppFullName($appName, $instance = '')
    {
        return $appName . ($instance !== '' ? ':' . $instance : '');
    }

    /**
     * Routes incoming request to related application
     * @param  object $req Generic
     * @param  object $upstream AppInstance of Upstream
     * @param  string $responder

     * @return object Request
     */
    public function getRequest($req, $upstream, $responder = null)
    {
        if (isset($req->attrs->server['APPNAME'])) {
            $appName = $req->attrs->server['APPNAME'];
        } elseif ($responder !== null) {
            $appName = $responder;
        } elseif (($appName = $this->getRequestRoute($req, $upstream)) !== null) {
            if ($appName === false) {
                return $req;
            }
        } else {
            return $req;
        }
        if (mb_orig_strpos($appName, ':') === false) {
            $appName .= ':';
        }
        list($app, $instance) = explode(':', $appName, 2);

        $appInstance = $this->getInstanceByAppName($app, $instance);

        if (!$appInstance) {
            return $req;
        }

        return $appInstance->handleRequest($req, $upstream);
    }

    /**
     * Routes incoming request to related application. Method is for overloading
     * @param  object $req Generic
     * @param  object $upstream AppInstance of Upstream
     * @return string Application's name

     */
    public function getRequestRoute($req, $upstream)

    {
    }

    /**
     * Gets instance of application
     * @alias AppResolver::getInstance
     * @param  string $appName Application name
     * @param  string $instance Instance name
     * @param  boolean $spawn If true, we spawn an instance if absent
     * @param  boolean $preload If true, worker is at the preload stage
     * @return object AppInstance
     */
    public function getInstanceByAppName($appName, $instance = '', $spawn = true, $preload = false)
    {
        return $this->getInstance($appName, $instance, $spawn, $preload);
    }
}


1		<?php
2		namespace PHPDaemon\Core;
3
4		use PHPDaemon\Config;
5
6		/**
7		* Application resolver
8		* @package PHPDaemon\Core
9		* @author Vasily Zorin <[email protected]>
10		*/
11		class AppResolver
12		{
13		use \PHPDaemon\Traits\ClassWatchdog;
14		use \PHPDaemon\Traits\StaticObjectWatchdog;
15
16		/**
17		* Preloads applications
18		* @param boolean $privileged If true, we are in the pre-fork stage
19		* @return void
20		*/
21		public function preload($privileged = false)
22		{
23		foreach (Daemon::$config as $fullname => $section) {
		0 ignored issues – show Bug introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report The expression `\PHPDaemon\Core\Daemon::$config` of type `object<PHPDaemon\Config\Object>` is not traversable. Loading history...
24		if (!$section instanceof Config\Section) {
25		continue;
26		}
27		if (isset($section->limitinstances)) {
28		continue;
29		}
30		if ((isset($section->enable) && $section->enable->value) \|\|
31		(!isset($section->enable) && !isset($section->disable))
32		) {
33		if (mb_orig_strpos($fullname, ':') === false) {
34		$fullname .= ':';
35		}
36		list($appName, $instance) = explode(':', $fullname, 2);
37		$appNameLower = strtolower($appName);
38		if ($appNameLower !== 'pool' && $privileged && (!isset($section->privileged) \|\| !$section->privileged->value)) {
		0 ignored issues – show Coding Style introduced 2016-05-10 20:52 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 128 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
39		continue;
40		}
41		if (isset(Daemon::$appInstances[$appNameLower][$instance])) {
42		continue;
43		}
44		$this->getInstance($appName, $instance, true, true);
45		}
46		}
47		}
48
49		/**
50		* Gets instance of application
51		* @param string $appName Application name
52		* @param string $instance Instance name
53		* @param boolean $spawn If true, we spawn an instance if absent
54		* @param boolean $preload If true, worker is at the preload stage
55		* @return object $instance AppInstance
56		*/
57		public function getInstance($appName, $instance = '', $spawn = true, $preload = false)
58		{
59		$class = ClassFinder::find($appName, 'Applications');
60		if (isset(Daemon::$appInstances[$class][$instance])) {
61		return Daemon::$appInstances[$class][$instance];
62		}
63		if (!$spawn) {
64		return false;
65		}
66		$fullname = $this->getAppFullName($appName, $instance);
67	View Code Duplication	if (!class_exists($class)) {
		0 ignored issues – show Duplication introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		Daemon::$process->log(__METHOD__ . ': unable to find application class ' . json_encode($class) . '\'');
69		return false;
70		}
71	View Code Duplication	if (!is_subclass_of($class, '\\PHPDaemon\\Core\\AppInstance')) {
		0 ignored issues – show Duplication introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
72		Daemon::$process->log(__METHOD__ . ': class ' . json_encode($class) . '\' found, but skipped as long as it is not subclass of \\PHPDaemon\\Core\\AppInstance');
		0 ignored issues – show Coding Style introduced 2016-02-05 10:49 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 171 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
73		return false;
74		}
75		$fullnameClass = $this->getAppFullName($class, $instance);
76		if ($fullname !== $fullnameClass && isset(Daemon::$config->{$fullname})) {
77		Daemon::$config->renameSection($fullname, $fullnameClass);
78		}
79		if (!$preload) {
80		/** @noinspection PhpUndefinedVariableInspection */
81		if (!$class::$runOnDemand) {
82		return false;
83		}
84		if (isset(Daemon::$config->{$fullnameClass}->limitinstances)) {
85		return false;
86		}
87		}
88
89		return new $class($instance);
90		}
91
92		/**
93		* Resolve full name of application by its class and name
94		* @param string $appName Application name
95		* @param string $instance Application class
96		* @return string
97		*/
98		public function getAppFullName($appName, $instance = '')
99		{
100		return $appName . ($instance !== '' ? ':' . $instance : '');
101		}
102
103		/**
104		* Routes incoming request to related application
105		* @param object $req Generic
106		* @param object $upstream AppInstance of Upstream
107		* @param string $responder
		0 ignored issues – show Documentation introduced 2016-06-29 11:47 UTC by Report Bug Copy Issue Report Should the type for parameter `$responder` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
108		* @return object Request
109		*/
110		public function getRequest($req, $upstream, $responder = null)
111		{
112		if (isset($req->attrs->server['APPNAME'])) {
113		$appName = $req->attrs->server['APPNAME'];
114		} elseif ($responder !== null) {
115		$appName = $responder;
116		} elseif (($appName = $this->getRequestRoute($req, $upstream)) !== null) {
117		if ($appName === false) {
118		return $req;
119		}
120		} else {
121		return $req;
122		}
123		if (mb_orig_strpos($appName, ':') === false) {
124		$appName .= ':';
125		}
126		list($app, $instance) = explode(':', $appName, 2);
127
128		$appInstance = $this->getInstanceByAppName($app, $instance);
129
130		if (!$appInstance) {
131		return $req;
132		}
133
134		return $appInstance->handleRequest($req, $upstream);
135		}
136
137		/**
138		* Routes incoming request to related application. Method is for overloading
139		* @param object $req Generic
140		* @param object $upstream AppInstance of Upstream
141		* @return string Application's name
		0 ignored issues – show Documentation introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Should the return type not be `string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
142		*/
143		public function getRequestRoute($req, $upstream)
		0 ignored issues – show Unused Code introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report The parameter `$req` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report The parameter `$upstream` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
144		{
145		}
146
147		/**
148		* Gets instance of application
149		* @alias AppResolver::getInstance
150		* @param string $appName Application name
151		* @param string $instance Instance name
152		* @param boolean $spawn If true, we spawn an instance if absent
153		* @param boolean $preload If true, worker is at the preload stage
154		* @return object AppInstance
155		*/
156		public function getInstanceByAppName($appName, $instance = '', $spawn = true, $preload = false)
157		{
158		return $this->getInstance($appName, $instance, $spawn, $preload);
159		}
160		}
161

kakserpom / phpdaemon

Pull Request — master (#264)

AppResolver::getInstance() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like