PHPDaemon\Clients\Redis\Examples\Scan

Complexity

Total Complexity

2

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	onReady()	0	25	2

<?php
/**
 * `phpd.conf`
 * Clients\Redis\Examples\Scan {}
 */
namespace PHPDaemon\Clients\Redis\Examples;

use PHPDaemon\Core\Daemon;
use PHPDaemon\Core\Debug;

/**
 * @package    NetworkClients
 * @subpackage RedisClientExample
 * @author     Efimenko Dmitriy <ezheg89@gmail.com>
 */
class Scan extends \PHPDaemon\Core\AppInstance {
	/**
	 * @var Pool
	 */
	public $redis;

	/**
	 * Called when the worker is ready to go
	 * @return void
	 */
	public function onReady() {
		$this->redis = \PHPDaemon\Clients\Redis\Pool::getInstance();

It seems like \PHPDaemon\Clients\Redis\Pool::getInstance() of type object<PHPDaemon\Network\this> is incompatible with the declared type object<PHPDaemon\Clients\Redis\Examples\Pool> of property $redis.

		$params = [];
		foreach (range(0, 100) as $i) {
			$params[] = 'myset' . $i;
			$params[] = 'value' . $i;
		}
		$params[] = function($redis) {

The parameter $redis is not used and could be removed.

			$params = [function($redis) {
				D('Count: ' . count($redis->result[1]) . '; Next: ' . $redis->result[0]);
			}];
			
			$cbEnd = function($redis, $scan) {

The parameter $redis is not used and could be removed.

The parameter $scan is not used and could be removed.

				D('Full scan end!');
			};

			// test 1
			// call_user_func_array([$this->redis, 'scan'], $params);

69% of this comment could be valid code. Did you maybe forget this after debugging?

			// test 2
			$this->redis->autoscan('scan', $params, $cbEnd, 50);
		};
		call_user_func_array([$this->redis, 'mset'], $params);
	}
}