PHPDaemon\Clients\IMAP\Pool

Complexity

Total Complexity

6

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getConfigDefaults()	0	7	1
B	open()	0	21	5

<?php

namespace PHPDaemon\Clients\IMAP;

use PHPDaemon\Network\Client;
use PHPDaemon\Core\Daemon;

class Pool extends Client
{
    protected function getConfigDefaults()
    {
        return [
            'port'    => 143,
            'sslport' => 993,
        ];
    }

    public function open($host, $user, $pass, $cb, $ssl = true)
    {
        $params = compact('host', 'user', 'pass', 'cb', 'ssl');
        $params['port'] = $params['ssl'] ? $this->config->sslport->value : $this->config->port->value;

The property sslport does not seem to exist in PHPDaemon\Config\Section.

The property port does not seem to exist in PHPDaemon\Config\Section.

        $dest = 'tcp://' . $params['host'] . ':' . $params['port'] . ($params['ssl'] ? '#ssl' : '');
        $this->getConnection($dest, function ($conn) use ($params) {
            if (!$conn || !$conn->isConnected()) {
                call_user_func($params['cb'], false);
                return;
            }
            $conn->bind('onauth', function ($conn, $ok) use ($params) {

The parameter $ok is not used and could be removed.

                $conn->selectBox();
            });
            $conn->bind('onselect', function ($conn, $ok) use ($params) {

The parameter $ok is not used and could be removed.

                call_user_func($params['cb'], $conn);
            });
            $conn->auth($params['user'], $params['pass']);

            //TODO: startTls

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

        });
    }
}