Application - Code Metrics - Inspection of "SockJS\Application->setRedis() method" - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3fcc00...26959a )

by Vasily

created 2016-03-29 10:45 UTC

Application C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	383
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes	5
Bugs	1	Features	0

Metric	Value
wmc	57
c	5
b	1
f	0
lcom	1
cbo	11
dl	0
loc	383
rs	6.433

21 Methods

Rating	Name	Size	Complexity
B	getConfigDefaults()	30	1
A	setRedis()	4	1
A	getLocalSubscribersCount()	3	1
A	subscribe()	3	1
A	setnx()	3	1
A	setkey()	3	1
A	getkey()	3	1
A	expire()	3	1
A	unsubscribe()	3	1
A	unsubscribeReal()	3	1
A	publish()	3	1
A	onReady()	8	2
A	onFinish()	6	2
A	attachWss()	8	2
B	wsHandler()	24	6
A	detachWss()	8	2
A	beginSession()	14	4
A	getRouteOptions()	16	4
A	endSession()	3	1
D	beginRequest()	61	20
A	callMethod()	11	3

How to fix Complexity

<?php
namespace PHPDaemon\SockJS;

use PHPDaemon\HTTPRequest\Generic;
use PHPDaemon\Core\Daemon;
use PHPDaemon\Structures\ObjectStorage;
use PHPDaemon\Core\Debug;
use PHPDaemon\Servers\WebSocket\Pool as WebSocketPool;

/**
 * @package    Libraries
 * @subpackage SockJS
 * @author     Vasily Zorin <[email protected]>
 */
class Application extends \PHPDaemon\Core\AppInstance {
	protected $redis;
	protected $sessions;

	public $wss;

	/**
	 * Setting default config options
	 * @return array|bool
	 */
	protected function getConfigDefaults() {
		return [
			/* [string] @todo redis-name */

			'redis-name' => '',

			/* [string] @todo redis-prefix */

			'redis-prefix' => 'sockjs:',

			/* [string] @todo wss-name */

			'wss-name' => '',
			
			/* [Double] @todo batch-delay */

			'batch-delay' => new \PHPDaemon\Config\Entry\Double('0.05'),
			
			/* [Double] @todo heartbeat-interval */

			'heartbeat-interval' => new \PHPDaemon\Config\Entry\Double('25'),
			
			/* [Time] @todo dead-session-timeout */

			'dead-session-timeout' => new \PHPDaemon\Config\Entry\Time('1h'),
			
			/* [Size] @todo gc-max-response-size */

			'gc-max-response-size' => new \PHPDaemon\Config\Entry\Size('128k'),
			
			/* [Time] @todo network-timeout-read */

			'network-timeout-read' => new \PHPDaemon\Config\Entry\Time('2h'),
			
			/* [Time] @todo network-timeout-write */

			'network-timeout-write' => new \PHPDaemon\Config\Entry\Time('120s'),
		];
	}

	/**
	 * Set Redis instance
	 * @param \PHPDaemon\Clients\Redis\Pool $redis
	 * @return $this
	 */
	public function setRedis(\PHPDaemon\Clients\Redis\Pool $redis) {
		$this->redis = $redis;
		return $this;
	}

	/**
	 * getLocalSubscribersCount
	 * @param  string $chan
	 * @return integer
	 */
	public function getLocalSubscribersCount($chan) {
		return $this->redis->getLocalSubscribersCount($this->config->redisprefix->value . $chan);
	}

	/**
	 * subscribe
	 * @param  string   $chan [@todo description]

	 * @param  callable $cb   [@todo description]

	 * @param  callable $opcb [@todo description]

	 * @callback $cb ( )
	 * @callback $opcb ( )
	 * @return void
	 */
	public function subscribe($chan, $cb, $opcb = null) {
		$this->redis->subscribe($this->config->redisprefix->value . $chan, $cb, $opcb);

	}

	/**
	 * setnx
	 * @param  string   $key   [@todo description]

	 * @param  mixed    $value [@todo description]

	 * @param  callable $cb    [@todo description]

	 * @callback $cb ( )
	 * @return void
	 */
	public function setnx($key, $value, $cb = null) {
		$this->redis->setnx($this->config->redisprefix->value . $key, $value, $cb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	/**
	 * setkey
	 * @param  string   $key   [@todo description]

	 * @param  mixed    $value [@todo description]

	 * @param  callable $cb    [@todo description]

	 * @callback $cb ( )
	 * @return void
	 */
	public function setkey($key, $value, $cb = null) {
		$this->redis->set($this->config->redisprefix->value . $key, $value, $cb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	/**
	 * getkey
	 * @param  string   $key   [@todo description]

	 * @param  callable $cb    [@todo description]

	 * @callback $cb ( )
	 * @return void
	 */
	public function getkey($key, $cb = null) {
		$this->redis->get($this->config->redisprefix->value . $key, $cb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	/**
	 * expire
	 * @param  string   $key     [@todo description]

	 * @param  integer  $seconds [@todo description]

	 * @param  callable $cb      [@todo description]

	 * @callback $cb ( )
	 * @return void
	 */
	public function expire($key, $seconds, $cb = null) {
		$this->redis->expire($this->config->redisprefix->value . $key, $seconds, $cb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	/**
	 * unsubscribe
	 * @param  string   $chan [@todo description]

	 * @param  callable $cb   [@todo description]

	 * @param  callable $opcb [@todo description]

	 * @callback $cb ( )
	 * @callback $opcb ( )
	 * @return void
	 */
	public function unsubscribe($chan, $cb, $opcb = null) {
		$this->redis->unsubscribe($this->config->redisprefix->value . $chan, $cb, $opcb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	/**
	 * unsubscribeReal
	 * @param  string   $chan [@todo description]

	 * @param  callable $opcb [@todo description]

	 * @callback $opcb ( )
	 * @return void
	 */
	public function unsubscribeReal($chan, $opcb = null) {
		$this->redis->unsubscribeReal($this->config->redisprefix->value . $chan, $opcb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	/**
	 * publish
	 * @param  string   $chan [@todo description]

	 * @param  callable $cb   [@todo description]

	 * @param  callable $opcb [@todo description]

	 * @callback $cb ( )
	 * @callback $opcb ( )
	 * @return void
	 */
	public function publish($chan, $cb, $opcb = null) {
		$this->redis->publish($this->config->redisprefix->value . $chan, $cb, $opcb);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	/**
	 * Called when the worker is ready to go
	 * @return void
	 */
	public function onReady() {
		$this->redis = \PHPDaemon\Clients\Redis\Pool::getInstance($this->config->redisname->value);
		$this->sessions = new ObjectStorage;
		$this->wss = new ObjectStorage;
		foreach (preg_split('~\s*;\s*~', $this->config->wssname->value) as $wssname) {
			$this->attachWss(WebSocketPool::getInstance(trim($wssname)));
		}
	}

	/**
	 * onFinish
	 * @return void
	 */
	public function onFinish() {
		foreach ($this->attachedTo as $wss) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
			$this->detachWss($wss);
		}
		parent::onFinish();
	}

	/**
	 * attachWss
	 * @param \PHPDaemon\Network\Pool $wss
	 * @return boolean
	 */
	public function attachWss($wss) {
		if ($this->wss->contains($wss)) {
			return false;
		}
		$this->wss->attach($wss);
		$wss->bind('customTransport', [$this, 'wsHandler']);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
		return true;
	}

	/**
	 * wsHandler
	 * @param  object   $ws     [@todo description]

	 * @param  string   $path   [@todo description]

	 * @param  object   $client [@todo description]

	 * @param  callable $state  [@todo description]

	 * @callback $state ( object $route )
	 * @return boolean
	 */
	public function wsHandler($ws, $path, $client, $state) {
		$e = explode('/', $path);
		$method = array_pop($e);
		$serverId = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$sessId = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		if ($method !== 'websocket') {
			return false;
		}
		if (sizeof($e) < 3 || !isset($e[sizeof($e) - 2]) || !ctype_digit($e[sizeof($e) - 2])) {
			return false;
		}
		$sessId = array_pop($e);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$serverId = array_pop($e);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$path = implode('/', $e);
		$client = new WebSocketConnectionProxy($this, $client);
		$route = $ws->getRoute($path, $client, true);
		if (!$route) {
			$state($route);
			return false;
		}
		$route = new WebSocketRouteProxy($this, $route);
		$state($route);
		return true;
	}

	/**
	 * detachWss
	 * @param  object $wss [@todo description]

	 * @return boolean
	 */
	public function detachWss($wss) {
		if (!$this->wss->contains($wss)) {
			return false;
		}
		$this->wss->detach($wss);
		$wss->unbind('transport', [$this, 'wsHandler']);
		return true;
	}

	/**
	 * beginSession
	 * @param  string $path   [@todo description]

	 * @param  string $sessId [@todo description]

	 * @param  string $server [@todo description]

	 * @return object

	 */
	public function beginSession($path, $sessId, $server) {
		$session = new Session($this, $sessId, $server);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		foreach ($this->wss as $wss) {
			if ($session->route = $wss->getRoute($path, $session)) {
				break;
			}
		}
		if (!$session->route) {
			return false;
		}
		$this->sessions->attach($session);
		$session->onHandshake();
		return $session;
	}

	/**
	 * getRouteOptions
	 * @param  string $path [@todo description]

	 * @return array
	 */
	public function getRouteOptions($path) {
		$opts = [
			'websocket' => true,
			'origins' => ['*:*'],
			'cookie_needed' => false,
		];
		foreach ($this->wss as $wss) {
			if ($wss->routeExists($path)) {
				foreach ($wss->getRouteOptions($path) as $k => $v) {
					$opts[$k] = $v;
				}
				break;
			}
		}
		return $opts;
	}

	/**
	 * endSession
	 * @param Session $session
	 * @return void
	 */
	public function endSession($session) {
		$this->sessions->detach($session);
	}

	/**
	 * Creates Request.
	 * @param  object $req      Request.
	 * @param  object $upstream Upstream application instance.
	 * @return object           Request.
	 */
	public function beginRequest($req, $upstream) {
		$e = array_map('rawurldecode', explode('/', $req->attrs->server['DOCUMENT_URI']));
		
		$serverId = null;
		$sessId = null;

		/* Route discovery */
		$path = null;
		$extra = [];
		do {
			foreach ($this->wss as $wss) {
				$try = implode('/', $e);
				if ($try === '') {
					$try = '/';
				}
				if ($wss->routeExists($try)) {
					$path = $try;
					break 2;
				}
			}
		 	array_unshift($extra, array_pop($e));
		} while (sizeof($e) > 0);

		if ($path === null) {
			return $this->callMethod('NotFound', $req, $upstream);
		}

		if (sizeof($extra) > 0 && end($extra) === '') {
			array_pop($extra);
		}

		$method = sizeof($extra) ? array_pop($extra) : null;
		
		if ($method === null) {
			$method = 'Welcome';
		}
		elseif ($method === 'info') {


		}
		elseif (preg_match('~^iframe(?:-([^/]*))?\.html$~', $method, $m)) {
			$method = 'Iframe';
			$version = isset($m[1]) ? $m[1] : null;
		} else {
			if (sizeof($extra) < 2) {
				return $this->callMethod('NotFound', $req, $upstream);	
			}
			$sessId = array_pop($extra);
			$serverId = array_pop($extra);
			if ($sessId === '' || $serverId === '' || strpos($sessId, '.') !== false || strpos($serverId, '.') !== false) {
				return $this->callMethod('NotFound', $req, $upstream);	
			}
		}
		$req->attrs->sessId = $sessId;
		$req->attrs->serverId = $serverId;
		$req->attrs->path = $path;
		$req = $this->callMethod($method, $req, $upstream);
		if ($req instanceof Methods\Iframe && strlen($version)) {
			$req->attrs->version = $version;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		}
		return $req;
	}

	/**
	 * callMethod
	 * @param  string $method   [@todo description]

	 * @param  object $req      [@todo description]

	 * @param  object $upstream [@todo description]

	 * @return object
	 */
	public function callMethod($method, $req, $upstream) {
		$method = strtr(ucwords(strtr($method, ['_' => ' '])), [' ' => '']);
		if (strtolower($method) === 'generic') {
			$method = 'NotFound';
		}
		$class = __NAMESPACE__ . '\\Methods\\' . $method;
		if (!class_exists($class)) {
			$class = __NAMESPACE__ . '\\Methods\\NotFound'; 
		}
		return new $class($this, $upstream, $req);
	}
}


Push — master ( 3fcc00...26959a )

Application C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

21 Methods

How to fix Complexity

Complex Class

Available Fixes

1			<?php
2			namespace PHPDaemon\SockJS;
3
4			use PHPDaemon\HTTPRequest\Generic;
5			use PHPDaemon\Core\Daemon;
6			use PHPDaemon\Structures\ObjectStorage;
7			use PHPDaemon\Core\Debug;
8			use PHPDaemon\Servers\WebSocket\Pool as WebSocketPool;
9
10			/**
11			* @package Libraries
12			* @subpackage SockJS
13			* @author Vasily Zorin <[email protected]>
14			*/
15			class Application extends \PHPDaemon\Core\AppInstance {
16			protected $redis;
17			protected $sessions;
18
19			public $wss;
20
21			/**
22			* Setting default config options
23			* @return array\|bool
24			*/
25			protected function getConfigDefaults() {
26			return [
27			/* [string] @todo redis-name */
			0 ignored issues – show Coding Style Best Practice introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history...
28			'redis-name' => '',
29
30			/* [string] @todo redis-prefix */
			0 ignored issues – show Coding Style Best Practice introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history...
31			'redis-prefix' => 'sockjs:',
32
33			/* [string] @todo wss-name */
			0 ignored issues – show Coding Style Best Practice introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history...
34			'wss-name' => '',
35
36			/* [Double] @todo batch-delay */
			0 ignored issues – show Coding Style Best Practice introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker. Loading history...

kakserpom / phpdaemon

Push — master ( 3fcc00...26959a )

Application C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

21 Methods

How to fix Complexity

Complex Class

Available Fixes

Duplication Side-by-Side

Filter issues like