PHPDaemon\Clients\AMQP\Driver\Protocol\v091\Parser\Table

Complexity

Total Complexity

26

Size/Duplication

Total Lines	161
Duplicated Lines	21.12 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	parse()	0	6	1
A	parseTable()	12	12	2
C	parseField()	0	44	15
B	parseDecimal()	0	29	5
A	parseArray()	12	12	2
A	parseByteArray()	10	10	1

<?php

namespace PHPDaemon\Clients\AMQP\Driver\Protocol\v091\Parser;

use PHPDaemon\Clients\AMQP\Driver\Protocol\Exception\AMQPProtocolException;

/**
 * Parse an AMQP table from a string buffer.
 *
 * This implementation uses the field types as discussed in the AMQP 0.9.1 SIG,
 * (*NOT* the specification) along with Qpid's extensions. This parser is suitable
 * for use with RabbitMQ and Qpid.
 *
 * @see https://www.rabbitmq.com/amqp-0-9-1-errata.html#section_3
 *
 * @see SpecTableParser for an implementation based on the AMQP 0.9.1 specification.
 *
 * Class Table
 * @author Aleksey I. Kuleshov YOU GLOBAL LIMITED
 * @package PHPDaemon\Clients\AMQP\Driver\Protocol\v091\Parser
 */
class Table implements TableInterface
{
    use ScalarParserTrait;

    /**
     * @var string A buffer containing the table data.
     */
    private $buffer = '';

    /**
     * Retrieve the next frame from the internal buffer.
     *
     * @param string &$buffer Binary data containing the table.
     *
     * @throws AMQPProtocolException if the incoming data does not conform to the
     *                               AMQP specification.
     * @return array
     */
    public function parse(&$buffer)
    {
        $this->buffer = &$buffer;

        return $this->parseTable();
    }

    /**
     * Parse an AMQP table from the head of the buffer.
     * @return array
     * @throws \PHPDaemon\Clients\AMQP\Driver\Protocol\Exception\AMQPProtocolException
     */
    private function parseTable()

This method seems to be duplicated in your project.

    {
        $length = $this->parseUnsignedInt32();
        $stopAt = strlen($this->buffer) - $length;
        $table = [];

        while (strlen($this->buffer) > $stopAt) {
            $table[$this->parseShortString()] = $this->parseField();
        }

        return $table;
    }

    /**
     * Parse a table or array field.
     *
     * @return integer|array|boolean|double|string|null
     * @throws AMQPProtocolException
     */
    private function parseField()
    {
        $type = $this->buffer[0];
        $this->buffer = substr($this->buffer, 1);

        // @todo bench switch vs if vs method map

Comments for TODO tasks are often forgotten in the code; it might be better to use a dedicated issue tracker.

        switch ($type) {
            case 's':
                return $this->parseSignedInt16();
            case 'l':
                return $this->parseSignedInt64();
            case 'x':
                return $this->parseByteArray();
            case 't':
                return $this->parseUnsignedInt8() !== 0;
            case 'b':
                return $this->parseSignedInt8();
            case 'I':
                return $this->parseSignedInt32();
            case 'f':
                return $this->parseFloat();
            case 'd':
                return $this->parseDouble();
            case 'D':
                return $this->parseDecimal();
            case 'S':
                return $this->parseLongString();
            case 'A':
                return $this->parseArray();
            case 'T':
                return $this->parseUnsignedInt64();
            case 'F':
                return $this->parseTable();
            case 'V':
                return null;
        }

        throw new AMQPProtocolException(
            sprintf(
                'table value type (0x%02x) is invalid or unrecognised.',
                ord($type)
            )
        );
    }

    /**
     * Parse an AMQP decimal from the head of the buffer.
     * @return string
     */
    public function parseDecimal()
    {
        $scale = $this->parseUnsignedInt8();
        $value = $this->parseSignedInt32();

        if (0 === $scale) {
            return (string)$value;
        }

        if ($value >= 0) {
            $sign = '';
            $value = (string)$value;
        } else {
            $sign = '-';
            $value = (string)-$value;
        }

        $length = strlen($value);

        if ($length === $scale) {
            return $sign . '0.' . $value;
        }

        if ($length < $scale) {
            return $sign . '0.' . str_repeat('0', $scale - $length) . $value;
        }

        return $sign . substr($value, 0, -$scale) . '.' . substr($value, -$scale);
    }

    /**
     * Parse an AMQP field-array value.
     * @return array
     * @throws \PHPDaemon\Clients\AMQP\Driver\Protocol\Exception\AMQPProtocolException
     */
    private function parseArray()

This method seems to be duplicated in your project.

    {
        $length = $this->parseUnsignedInt32();
        $stopAt = strlen($this->buffer) - $length;
        $array = [];

        while (strlen($this->buffer) > $stopAt) {
            $array[] = $this->parseField();
        }

        return $array;
    }

    /**
     * Parse an AMQP byte-array value.
     * @return array

Should the return type not be string?

     */
    private function parseByteArray()

This method seems to be duplicated in your project.

    {
        list(, $length) = unpack('N', $this->buffer);

        try {
            return substr($this->buffer, 4, $length);
        } finally {
            $this->buffer = substr($this->buffer, $length + 4);
        }
    }
}