IPCManager::updatedWorkers() - Code Metrics - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

IPCManager::updatedWorkers() C
last analyzed 2021-06-02 17:17 UTC

↳ Parent: IPCManager

Complexity

Conditions	13
Paths	36

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	13
dl	0
loc	38
rs	6.6166
c	0
b	0
f	0
nc	36
nop	0

How to fix Complexity

<?php
namespace PHPDaemon\IPCManager;

use PHPDaemon\Config;
use PHPDaemon\Core\AppInstance;
use PHPDaemon\Core\Daemon;
use PHPDaemon\Thread;

class IPCManager extends AppInstance
{
    /** @var */
    public $pool;
    /** @var */
    public $conn;
    /** @var */
    public $socketurl;

    /**
     * Setting default config options
     * Overriden from AppInstance::getConfigDefaults
     * @return array|bool
     */
    protected function getConfigDefaults()
    {
        return [
            // listen to
            'mastersocket' => 'unix:///tmp/phpDaemon-ipc-%x.sock',
        ];
    }

    /**
     * Constructor.
     * @return void
     */
    public function init()
    {
        $this->socketurl = sprintf($this->config->mastersocket->value,
            crc32(Daemon::$config->pidfile->value . "\x00" . Daemon::$config->user->value . "\x00" . Daemon::$config->group->value));
        if (Daemon::$process instanceof Thread\IPC) {
            $this->pool = MasterPool::getInstance(['listen' => $this->socketurl]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->pool->appInstance = $this;
            $this->pool->onReady();
        }
    }

    public function getSocketUrl()
    {
        return $this->socketurl;
    }

    /**
     * @TODO DESCR
     */
    public function updatedWorkers()
    {
        $perWorker = 1;
        $instancesCount = [];
        foreach (Daemon::$config as $name => $section) {

            if ((!$section instanceof Config\Section) || !isset($section->limitinstances)) {
                continue;
            }
            $instancesCount[$name] = 0;
        }
        foreach ($this->pool->workers as $worker) {
            foreach ($worker->instancesCount as $k => $v) {
                if (!isset($instancesCount[$k])) {
                    unset($worker->instancesCount[$k]);
                    continue;
                }
                $instancesCount[$k] += $v;
            }
        }
        foreach ($instancesCount as $name => $num) {
            $v = Daemon::$config->{$name}->limitinstances->value - $num;
            foreach ($this->pool->workers as $worker) {
                if ($v <= 0) {
                    break;
                }
                if ((isset($worker->instancesCount[$name])) && ($worker->instancesCount[$name] < $perWorker)) {
                    continue;
                }
                if (!isset($worker->instancesCount[$name])) {
                    $worker->instancesCount[$name] = 1;
                } else {
                    ++$worker->instancesCount[$name];
                }
                $worker->sendPacket(['op' => 'spawnInstance', 'appfullname' => $name]);
                --$v;
            }
        }
    }

    /**
     * Called when application instance is going to shutdown.
     * @param bool $graceful
     * @return boolean Ready to shutdown?
     */
    public function onShutdown($graceful = false)
    {
        if ($this->pool) {
            return $this->pool->onShutdown();
        }
        return true;
    }

    /**
     * @TODO DESCR
     * @param $workerId
     * @param $path
     * @return bool
     */
    public function importFile($workerId, $path)
    {
        if (!isset($this->pool->workers[$workerId])) {
            return false;
        }
        $worker = $this->pool->workers[$workerId];
        $worker->sendPacket(['op' => 'importFile', 'path' => $path]);
        return true;
    }

    /**
     * @TODO DESCR
     */
    public function ensureConnection()
    {
        $this->sendPacket('');
    }

    /**
     * @TODO DESCR
     * @param $packet
     */
    public function sendPacket($packet = null)
    {
        if ($this->conn && $this->conn->isConnected()) {
            $this->conn->sendPacket($packet);
            return;
        }

        $cb = function ($conn) use ($packet) {
            $conn->sendPacket($packet);
        };
        if (!$this->conn) {
            $this->conn = new WorkerConnection(null, null, null);

            $this->conn->connect($this->socketurl);
        }
        $this->conn->onConnected($cb);
    }

    /**
     * @TODO DESCR
     * @param $appInstance
     * @param $method
     * @param array $args
     * @param callable $cb

     */
    public function sendBroadcastCall($appInstance, $method, $args = [], $cb = null)

    {
        $this->sendPacket([
            'op' => 'broadcastCall',
            'appfullname' => $appInstance,
            'method' => $method,
            'args' => $args,
        ]);
    }

    /**
     * @TODO DESCR
     * @param $appInstance
     * @param $method
     * @param array $args
     * @param callable $cb

     */
    public function sendSingleCall($appInstance, $method, $args = [], $cb = null)

    {
        $this->sendPacket([
            'op' => 'singleCall',
            'appfullname' => $appInstance,
            'method' => $method,
            'args' => $args,
        ]);
    }

    /**
     * @TODO DESCR
     * @param $workerId
     * @param $appInstance
     * @param $method
     * @param array $args
     * @param callable $cb

     */
    public function sendDirectCall($workerId, $appInstance, $method, $args = [], $cb = null)

    {
        $this->sendPacket([
            'op' => 'directCall',
            'appfullname' => $appInstance,
            'method' => $method,
            'args' => $args,
            'workerId' => $workerId,
        ]);
    }
}


1		<?php
2		namespace PHPDaemon\IPCManager;
3
4		use PHPDaemon\Config;
5		use PHPDaemon\Core\AppInstance;
6		use PHPDaemon\Core\Daemon;
7		use PHPDaemon\Thread;
8
9		class IPCManager extends AppInstance
10		{
11		/** @var */
12		public $pool;
13		/** @var */
14		public $conn;
15		/** @var */
16		public $socketurl;
17
18		/**
19		* Setting default config options
20		* Overriden from AppInstance::getConfigDefaults
21		* @return array\|bool
22		*/
23		protected function getConfigDefaults()
24		{
25		return [
26		// listen to
27		'mastersocket' => 'unix:///tmp/phpDaemon-ipc-%x.sock',
28		];
29		}
30
31		/**
32		* Constructor.
33		* @return void
34		*/
35		public function init()
36		{
37		$this->socketurl = sprintf($this->config->mastersocket->value,
38		crc32(Daemon::$config->pidfile->value . "\x00" . Daemon::$config->user->value . "\x00" . Daemon::$config->group->value));
39		if (Daemon::$process instanceof Thread\IPC) {
40		$this->pool = MasterPool::getInstance(['listen' => $this->socketurl]);
		0 ignored issues – show Documentation introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report `array('listen' => $this->socketurl)` is of type `array<string,string,{"listen":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41		$this->pool->appInstance = $this;
42		$this->pool->onReady();
43		}
44		}
45
46		public function getSocketUrl()
47		{
48		return $this->socketurl;
49		}
50
51		/**
52		* @TODO DESCR
53		*/
54		public function updatedWorkers()
55		{
56		$perWorker = 1;
57		$instancesCount = [];
58		foreach (Daemon::$config as $name => $section) {
		0 ignored issues – show Bug introduced 2018-05-21 18:18 UTC by Report Bug Copy Issue Report The expression `\PHPDaemon\Core\Daemon::$config` of type `object<PHPDaemon\Config\_Object>` is not traversable. Loading history...
59		if ((!$section instanceof Config\Section) \|\| !isset($section->limitinstances)) {
60		continue;
61		}
62		$instancesCount[$name] = 0;
63		}
64		foreach ($this->pool->workers as $worker) {
65		foreach ($worker->instancesCount as $k => $v) {
66		if (!isset($instancesCount[$k])) {
67		unset($worker->instancesCount[$k]);
68		continue;
69		}
70		$instancesCount[$k] += $v;
71		}
72		}
73		foreach ($instancesCount as $name => $num) {
74		$v = Daemon::$config->{$name}->limitinstances->value - $num;
75		foreach ($this->pool->workers as $worker) {
76		if ($v <= 0) {
77		break;
78		}
79		if ((isset($worker->instancesCount[$name])) && ($worker->instancesCount[$name] < $perWorker)) {
80		continue;
81		}
82		if (!isset($worker->instancesCount[$name])) {
83		$worker->instancesCount[$name] = 1;
84		} else {
85		++$worker->instancesCount[$name];
86		}
87		$worker->sendPacket(['op' => 'spawnInstance', 'appfullname' => $name]);
88		--$v;
89		}
90		}
91		}
92
93		/**
94		* Called when application instance is going to shutdown.
95		* @param bool $graceful
96		* @return boolean Ready to shutdown?
97		*/
98		public function onShutdown($graceful = false)
99		{
100		if ($this->pool) {
101		return $this->pool->onShutdown();
102		}
103		return true;
104		}
105
106		/**
107		* @TODO DESCR
108		* @param $workerId
109		* @param $path
110		* @return bool
111		*/
112		public function importFile($workerId, $path)
113		{
114		if (!isset($this->pool->workers[$workerId])) {
115		return false;
116		}
117		$worker = $this->pool->workers[$workerId];
118		$worker->sendPacket(['op' => 'importFile', 'path' => $path]);
119		return true;
120		}
121
122		/**
123		* @TODO DESCR
124		*/
125		public function ensureConnection()
126		{
127		$this->sendPacket('');
128		}
129
130		/**
131		* @TODO DESCR
132		* @param $packet
133		*/
134		public function sendPacket($packet = null)
135		{
136		if ($this->conn && $this->conn->isConnected()) {
137		$this->conn->sendPacket($packet);
138		return;
139		}
140
141		$cb = function ($conn) use ($packet) {
142		$conn->sendPacket($packet);
143		};
144		if (!$this->conn) {
145		$this->conn = new WorkerConnection(null, null, null);
		0 ignored issues – show Unused Code introduced 2015-12-06 14:42 UTC by Report Bug Copy Issue Report The call to `WorkerConnection::__construct()` has too many arguments starting with `null`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
146		$this->conn->connect($this->socketurl);
147		}
148		$this->conn->onConnected($cb);
149		}
150
151		/**
152		* @TODO DESCR
153		* @param $appInstance
154		* @param $method
155		* @param array $args
156		* @param callable $cb
		0 ignored issues – show Documentation introduced 2016-05-18 23:08 UTC by Report Bug Copy Issue Report Should the type for parameter `$cb` not be `callable\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
157		*/
158	View Code Duplication	public function sendBroadcastCall($appInstance, $method, $args = [], $cb = null)
		0 ignored issues – show Unused Code introduced 2018-01-16 22:41 UTC by Report Bug Copy Issue Report The parameter `$cb` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2018-01-16 22:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
159		{
160		$this->sendPacket([
161		'op' => 'broadcastCall',
162		'appfullname' => $appInstance,
163		'method' => $method,
164		'args' => $args,
165		]);
166		}
167
168		/**
169		* @TODO DESCR
170		* @param $appInstance
171		* @param $method
172		* @param array $args
173		* @param callable $cb
		0 ignored issues – show Documentation introduced 2016-05-18 23:08 UTC by Report Bug Copy Issue Report Should the type for parameter `$cb` not be `callable\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
174		*/
175	View Code Duplication	public function sendSingleCall($appInstance, $method, $args = [], $cb = null)
		0 ignored issues – show Unused Code introduced 2018-01-16 22:41 UTC by Report Bug Copy Issue Report The parameter `$cb` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2018-01-16 22:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
176		{
177		$this->sendPacket([
178		'op' => 'singleCall',
179		'appfullname' => $appInstance,
180		'method' => $method,
181		'args' => $args,
182		]);
183		}
184
185		/**
186		* @TODO DESCR
187		* @param $workerId
188		* @param $appInstance
189		* @param $method
190		* @param array $args
191		* @param callable $cb
		0 ignored issues – show Documentation introduced 2016-05-18 23:08 UTC by Report Bug Copy Issue Report Should the type for parameter `$cb` not be `callable\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
192		*/
193		public function sendDirectCall($workerId, $appInstance, $method, $args = [], $cb = null)
		0 ignored issues – show Unused Code introduced 2018-01-16 22:41 UTC by Report Bug Copy Issue Report The parameter `$cb` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
194		{
195		$this->sendPacket([
196		'op' => 'directCall',
197		'appfullname' => $appInstance,
198		'method' => $method,
199		'args' => $args,
200		'workerId' => $workerId,
201		]);
202		}
203		}
204

kakserpom / phpdaemon

IPCManager::updatedWorkers() C last analyzed 2021-06-02 17:17 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

IPCManager::updatedWorkers() C
last analyzed 2021-06-02 17:17 UTC