PHPDaemon\Structures\PriorityQueueCallbacks

Complexity

Total Complexity

13

Size/Duplication

Total Lines	88
Duplicated Lines	17.05 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	insert()	0	4	1
A	enqueue()	0	4	1
A	dequeue()	0	4	1
A	compare()	0	7	3
A	executeOne()	0	11	3
A	executeAll()	15	15	4

<?php
namespace PHPDaemon\Structures;

use PHPDaemon\Core\CallbackWrapper;

/**
 * PriorityQueueCallbacks
 * @package PHPDaemon\Structures
 * @author  Vasily Zorin <maintainer@daemon.io>
 */
class PriorityQueueCallbacks extends \SplPriorityQueue
{
    use \PHPDaemon\Traits\ClassWatchdog;
    use \PHPDaemon\Traits\StaticObjectWatchdog;

    /**
     * Insert callback
     * @param  callable $cb Callback
     * @param  integer $pri Priority
     * @return void
     */
    public function insert($cb, $pri = 0)
    {
        parent::insert(CallbackWrapper::wrap($cb), $pri);
    }

    /**
     * Enqueue callback
     * @param  callable $cb Callback
     * @param  integer $pri Priority
     * @return void
     */
    public function enqueue($cb, $pri = 0)
    {
        parent::insert(CallbackWrapper::wrap($cb), $pri);

It seems like you call parent on a different method (insert() instead of enqueue()). Are you sure this is correct? If so, you might want to change this to $this->insert().

    }

    /**
     * Dequeue
     * @return callable
     */
    public function dequeue()
    {
        return $this->extract();
    }

    /**
     * Compare two priorities
     * @param  integer $pri1
     * @param  integer $pri2
     * @return integer
     */
    public function compare($pri1, $pri2)
    {
        if ($pri1 === $pri2) {
            return 0;
        }
        return $pri1 < $pri2 ? -1 : 1;
    }

    /**
     * Executes one callback from the top of queue with arbitrary arguments
     * @param  mixed ...$args Arguments
     * @return boolean
     */
    public function executeOne(...$args)
    {
        if ($this->isEmpty()) {
            return false;
        }
        $cb = $this->extract();
        if ($cb) {
            $cb(...$args);
        }
        return true;
    }

    /**
     * Executes all callbacks from the top of queue to bottom with arbitrary arguments
     * @param  mixed ...$args Arguments
     * @return integer
     */
    public function executeAll(...$args)

This method seems to be duplicated in your project.

    {
        if ($this->isEmpty()) {
            return 0;
        }
        $n = 0;
        do {
            $cb = $this->extract();
            if ($cb) {
                $cb(...$args);
                ++$n;
            }
        } while (!$this->isEmpty());
        return $n;
    }
}