Generic - Code Metrics - kakserpom/phpdaemon - Measure and Improve Code Quality continuously with Scrutinizer

Generic F
last analyzed 2021-06-02 17:17 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	617
Duplicated Lines	0.97 %

Coupling/Cohesion

Components	3
Dependencies	7

Importance

Changes

Metric	Value
dl	6
loc	617
rs	1.983
c	0
b	0
f	0
wmc	86
lcom	3
cbo	7

34 Methods

Rating	Name	Duplication	Size	Complexity
A	log()	0	4	1
A	__construct()	0	14	3
A	callInit()	0	12	2
A	handleException()	0	3	1
A	isAborted()	0	4	1
A	isFinished()	0	4	1
A	isRunning()	0	4	1
A	out()	0	3	1
A	run()	0	3	1
C	eventCall()	0	43	13
A	free()	0	11	3
A	setPriority()	0	7	2
A	preinit()	0	9	2
A	__toString()	0	4	1
A	init()	0	3	1
A	getString()	3	11	4
A	getMixed()	0	4	1
A	getArray()	0	11	3
A	getInteger()	3	14	6
A	onWrite()	0	3	1
A	registerShutdownFunction()	0	4	1
A	unregisterShutdownFunction()	0	6	2
A	codepoint()	0	9	2
A	sleep()	0	20	4
A	terminate()	0	8	2
A	wakeup()	0	7	2
A	checkIfReady()	0	4	1
A	onAbort()	0	3	1
A	onFinish()	0	3	1
A	onWakeup()	0	7	1
A	onSleep()	0	7	1
B	abort()	0	21	6
C	finish()	0	55	11
A	postFinishHandler()	0	6	2

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Generic often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Generic, and based on these observations, apply Extract Interface, too.

<?php
namespace PHPDaemon\Request;

use PHPDaemon\Core\AppInstance;
use PHPDaemon\Core\Daemon;
use PHPDaemon\Core\EventLoop;

abstract class Generic
{
    use \PHPDaemon\Traits\ClassWatchdog;
    use \PHPDaemon\Traits\StaticObjectWatchdog;
    use \PHPDaemon\Traits\EventHandlers;

    /**
     * State: finished.
     * @var integer
     */
    const STATE_FINISHED = 1;

    /**
     * State: waiting.
     * @var integer
     */
    const STATE_WAITING = 2;

    /**
     * State: running.
     * @var integer
     */
    const STATE_RUNNING = 3;

    /**
     * Related Application instance
     * @var \PHPDaemon\Core\AppInstance
     */
    public $appInstance;

    /**
     * Is this request aborted?
     * @var boolean
     */
    protected $aborted = false;

    /**
     * State
     * @var integer (self::STATE_*)
     */
    protected $state = self::STATE_WAITING;

    /**
     * Attributes
     * @var \StdCLass
     */
    public $attrs;

    /**
     * Registered shutdown functions
     * @var array
     */
    protected $shutdownFuncs = [];

    /**
     * Is this request running?
     * @var boolean
     */
    protected $running = false;

    /**
     * Upstream
     * @var object
     */
    protected $upstream;

    /**
     * Event
     * @var object
     */
    protected $ev;

    /**
     * Current sleep() time
     * @var float
     */
    protected $sleepTime = 0;

    /**
     * Priority
     * @var integer
     */
    protected $priority = null;

    /**
     * Current code point
     * @var mixed
     */
    protected $codepoint;

    protected $autoinit = false; // @TODO: remove this option in future version

    /**
     * Log
     * @param string $msg Message
     * @return void
     */
    public function log($msg)
    {
        Daemon::log(get_class($this) . ': ' . $msg);
    }

    /**
     * Constructor
     * @param AppInstance $appInstance Parent AppInstance.
     * @param IRequestUpstream $upstream Upstream.
     * @param object $parent Source request.

     */
    public function __construct($appInstance, IRequestUpstream $upstream, $parent = null)
    {
        ++Daemon::$process->reqCounter;
        $this->appInstance = $appInstance;
        $this->upstream = $upstream;
        $this->ev = EventLoop::$instance->timer([$this, 'eventCall']);
        if ($this->priority !== null) {
            $this->ev->priority = $this->priority;
        }
        $this->preinit($parent);
        if ($this->autoinit) {
            $this->callInit();
        }
    }

    public function callInit()
    {
        $this->onWakeup();
        try {
            $this->init();
        } catch (\Throwable $e) {

            Daemon::uncaughtExceptionHandler($e);
            $this->finish();
            return;
        }
        $this->onSleep();
    }

    /**
     * Uncaught exception handler
     * @param $e
     * @return boolean|null Handled?
     */
    public function handleException($e)

    {
    }

    /**
     * Is this request aborted?
     * @return boolean
     */
    public function isAborted()
    {
        return $this->aborted;
    }

    /**
     * Is this request finished?
     * @return boolean
     */
    public function isFinished()
    {
        return $this->state === static::STATE_FINISHED;
    }

    /**
     * Is this request running?
     * @return boolean
     */
    public function isRunning()
    {
        return $this->running;
    }

    /**
     * Output some data
     * @param string $s String to out
     * @param bool $flush
     * @return boolean|null Success
     */
    public function out($s, $flush = true)
    {
    }

    /**
     * Called when request iterated.
     * @return integer Status.

     */
    protected function run()
    {
    }

    /**
     * Event handler of Request, called by Evtimer
     * @param $arg
     * @return void
     */
    public function eventCall($arg)

    {
        try {
            if ($this->state === Generic::STATE_FINISHED) {
                $this->finish();
                $this->free();
                return;
            }
            $this->state = Generic::STATE_RUNNING;
            $this->onWakeup();
            $throw = false;
            try {
                $ret = $this->run();
                if (($ret === Generic::STATE_FINISHED) || ($ret === null)) {
                    $this->finish();
                } elseif ($ret === Generic::STATE_WAITING) {
                    $this->state = $ret;
                }
            } catch (RequestSleep $e) {
                $this->state = Generic::STATE_WAITING;
            } catch (RequestTerminated $e) {
                $this->state = Generic::STATE_FINISHED;
            } catch (\Throwable $e) {

                if (!$this->handleException($e)) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
                    $throw = true;
                }
            }
            if ($this->state === Generic::STATE_FINISHED) {
                $this->finish();
            }
            $this->onSleep();
            if ($throw) {
                throw $e;
            }
        } catch (\Throwable $e) {

            Daemon::uncaughtExceptionHandler($e);
            $this->finish();
            return;
        }
        if ($this->state === Generic::STATE_WAITING) {
            $this->ev->add($this->sleepTime);
        }
    }

    /**
     * Frees the request
     * @return void
     */
    public function free()
    {
        if ($this->ev) {
            $this->ev->free();
            $this->ev = null;
        }
        if (isset($this->upstream)) {
            $this->upstream->freeRequest($this);
            $this->upstream = null;
        }
    }

    /**
     * Sets the priority
     * @param integer Priority
     * @return void
     */
    public function setPriority($p)
    {
        $this->priority = $p;
        if ($this->ev !== null) {
            $this->ev->priority = $p;
        }
    }

    /**
     * Preparing before init
     * @param object Source request
     * @return void
     */
    protected function preinit($req)
    {
        if ($req === null) {
            $req = new \stdClass;
            $req->attrs = new \stdClass;
        }

        $this->attrs = $req->attrs;
    }

    /**
     * This magic method called when the object casts to string
     * @return string Description
     */
    public function __toString()
    {
        return 'Request of type ' . get_class($this);
    }

    /**
     * Called when request constructs
     * @return void
     */
    protected function init()
    {
    }

    /**
     * Get string value from the given variable
     * @param Reference of variable.
     * @param array     Optional. Possible values.
     * @return string Value.
     */
    public static function getString(&$var, $values = null)
    {
        if (!is_string($var)) {
            $var = '';
        }
        if ($values !== null) {

            return in_array($var, $values, true) ? $var : $values[0];
        }

        return $var;
    }

    /**
     * Get string value from the given variable
     * @param Reference of variable.
     * @return string Value.
     */
    public static function getMixed(&$var)
    {
        return $var;
    }

    /**
     * Get array value from the given variable
     * @param Reference of variable.
     * @param array     Optional. Filter callback.
     * @return string Value.

     */
    public static function getArray(&$var, $filter = null)
    {
        if (!is_array($var)) {
            return [];
        }
        if ($filter !== null) {
            return array_filter($var, $filter);
        }

        return $var;
    }

    /**
     * Get integer value from the given variable
     * @param Reference of variable.
     * @param array     Optional. Possible values.
     * @return string Value.
     */
    public static function getInteger(&$var, $values = null)
    {
        if (is_string($var) && ctype_digit($var)) {
            $var = (int)$var;
        }
        if (!is_int($var)) {
            return 0;
        }
        if ($values !== null) {

            return in_array($var, $values, true) ? $var : $values[0];
        }

        return $var;
    }

    /**
     * Called when the connection is ready to accept new data
     * @return void
     */
    public function onWrite()
    {
    }

    /**
     * Adds new callback called before the request finished
     * @param callable $callback
     * @return void
     */
    public function registerShutdownFunction($callback)
    {
        $this->shutdownFuncs[] = $callback;
    }

    /**
     * Remove the given callback
     * @param callable $callback
     * @return void
     */
    public function unregisterShutdownFunction($callback)
    {
        if (($k = array_search($callback, $this->shutdownFuncs)) !== false) {
            unset($this->shutdownFuncs[$k]);
        }
    }

    /**
     * Helper for easy switching between several interruptable stages of request's execution
     * @param string Name
     * @return boolean Execute
     */
    public function codepoint($p)
    {
        if ($this->codepoint !== $p) {
            $this->codepoint = $p;
            return true;
        }

        return false;
    }

    /**
     * Delays the request execution for the given number of seconds
     *
     * @param integer $time Time to sleep in seconds
     * @param boolean $set Set this parameter to true when use call it outside of Request->run() or if you don't want to interrupt execution now
     * @throws RequestSleep
     * @return void
     */
    public function sleep($time = 0, $set = false)
    {
        if ($this->state === Generic::STATE_FINISHED) {
            return;
        }
        if ($this->state !== Generic::STATE_RUNNING) {
            $set = true;
        }

        $this->sleepTime = $time;
$answer = 42;

$correct = false;

$correct = (bool) $answer;

        if (!$set) {
            throw new RequestSleep;
        } else {
            $this->ev->del();
            $this->ev->add($this->sleepTime);
        }

        $this->state = Generic::STATE_WAITING;
    }

    /**
     * Throws terminating exception
     * @param $s
     * @throws RequestTerminated
     * @return void
     */
    public function terminate($s = null)
    {
        if (is_string($s)) {
            $this->out($s);
        }

        throw new RequestTerminated;
    }

    /**
     * Cancel current sleep
     * @return void
     */
    public function wakeup()
    {
        if ($this->state === Generic::STATE_WAITING) {
            $this->ev->del();
            $this->ev->add(0);
        }
    }

    /**
     * Called to check if Request is ready
     * @return boolean Ready?
     */
    public function checkIfReady()
    {
        return true;
    }

    /**
     * Called when the request aborted
     * @return void
     */
    public function onAbort()
    {
    }

    /**
     * Called when the request finished
     * @return void
     */
    public function onFinish()
    {
    }

    /**
     * Called when the request wakes up
     * @return void
     */
    public function onWakeup()
    {
        $this->running = true;
        Daemon::$req = $this;
        Daemon::$context = $this;
        Daemon::$process->setState(Daemon::WSTATE_BUSY);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Called when the request starts sleep
     * @return void
     */
    public function onSleep()
    {
        Daemon::$req = null;
        Daemon::$context = null;
        $this->running = false;
        Daemon::$process->setState(Daemon::WSTATE_IDLE);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Aborts the request
     * @return void
     */
    public function abort()
    {
        if ($this->aborted) {
            return;
        }

        $this->aborted = true;
        $this->onWakeup();
        $this->onAbort();

        if ((ignore_user_abort() === 1)
            && (($this->state === Generic::STATE_RUNNING) || ($this->state === Generic::STATE_WAITING))
            && !Daemon::$compatMode
        ) {
            $this->upstream->endRequest($this);
        } else {
            $this->finish(-1);
        }

        $this->onSleep();
    }

    /**
     * Finish the request
     * @param integer Optional. Status. 0 - normal, -1 - abort, -2 - termination
     * @param boolean Optional. Zombie. Default is false
     * @return void
     */
    public function finish($status = 0, $zombie = false)
    {
        if ($this->state === Generic::STATE_FINISHED) {
            return;
        }

        if (!$zombie) {
            $this->state = Generic::STATE_FINISHED;
        }

        if (!($r = $this->running)) {
            $this->onWakeup();
        }

        while (($cb = array_shift($this->shutdownFuncs)) !== null) {
            try {
                $cb($this);
            } catch (\Throwable $e) {

                Daemon::uncaughtExceptionHandler($e);
                // @TODO: break?
            }
        }

        if (!$r) {
            $this->onSleep();
        }

        $this->event('finish');
        $this->onFinish();
        $this->cleanupEventHandlers();

        if (Daemon::$compatMode) {
            return;
        }

        ++Daemon::$process->counterGC;

        if (Daemon::$compatMode) {
            return;
        }

        if (!Daemon::$obInStack) { // preventing recursion
            ob_flush();
        }

        if ($status !== -1) {
            $appStatus = 0;
            $this->postFinishHandler(function () use ($appStatus, $status) {
                $this->upstream->endRequest($this, $appStatus, $status);
                $this->free();
            });
        } else {
            $this->free();
        }
    }

    /**
     * Called after request finish
     * @param callable $cb

     * @return void
     */
    protected function postFinishHandler($cb = null)
    {
        if ($cb !== null) {
            $cb();
        }
    }
}


Generic F
last analyzed 2021-06-02 17:17 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

34 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

kakserpom / phpdaemon

Generic F last analyzed 2021-06-02 17:17 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

34 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Generic F
last analyzed 2021-06-02 17:17 UTC