PHPDaemon\Clients\Redis\Lock

Complexity

Total Complexity

5

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	timeout()	0	5	1
A	acquire()	0	10	1
A	release()	0	16	2

<?php
namespace PHPDaemon\Clients\Redis;

use PHPDaemon\Utils\Crypt;

/**
 * @package    NetworkClients
 * @subpackage RedisClient
 * @author     Vasily Zorin <maintainer@daemon.io>
 */
class Lock
{
    use \PHPDaemon\Traits\ClassWatchdog;
    use \PHPDaemon\Traits\StaticObjectWatchdog;

    protected $pool;
    protected $timeout;
    protected $token;
    protected $key;

    /**
     * Constructor
     * @param string $key
     * @param integer $timeout
     * @param Pool $pool
     */
    public function __construct($key, $timeout, $pool)
    {
        $this->pool = $pool;
        $this->timeout = $timeout;
        $this->key = $key;
    }

    /**
     * @TODO
     * @param  integer $timeout
     * @return this

Should the return type not be Lock?

     */
    public function timeout($timeout)
    {
        $this->timeout = $timeout;
        return $this;
    }

    /**
     * @TODO
     * @param  callable $cb
     * @callback $cb ( )
     * @return this

Should the return type not be Lock?

     */
    public function acquire($cb)
    {
        Crypt::randomString(16, null, function ($token) use ($cb) {
            $this->token = $token;
            $this->pool->set($this->key, $this->token, 'NX', 'EX', $this->timeout, function ($redis) use ($cb) {

The method set does not exist on object<PHPDaemon\Clients\Redis\Pool>? Since you implemented __call, maybe consider adding a @method annotation.

                $cb($this, $redis->result === 'OK', $redis);
            });
        });
        return $this;
    }

    /**
     * @TODO
     * @param  callable $cb

Should the type for parameter $cb not be callable|null?

     * @callback $cb ( )
     * @return this

Should the return type not be Lock?

     */
    public function release($cb = null)
    {
        $this->pool->eval(

The method eval does not exist on object<PHPDaemon\Clients\Redis\Pool>? Since you implemented __call, maybe consider adding a @method annotation.

            'if redis.call("get",KEYS[1]) == ARGV[1] then return redis.call("del",KEYS[1]) else return 0 end',
            1,
            $this->key,
            $this->token,
            function ($redis) use ($cb) {
                if ($cb !== null) {
                    $cb($this, $redis->result, $redis);
                }
            }
        );

        return $this;
    }
}