kafkiansky / symfony-basic-auth-middleware

src/AuthenticateBasic.php

<?php

declare(strict_types=1);

namespace Kafkiansky\SymfonyMiddleware;

use Nyholm\Psr7\Response;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

final class AuthenticateBasic implements MiddlewareInterface
{
    public function __construct(
        private string $user,
        private string $password,
        private string $realm,
        private array|null $excludedPaths = null,

The type Kafkiansky\SymfonyMiddleware\null was not found. Maybe you did not declare it correctly or list all dependencies?

        private array|null $excludedPatterns = null,
    ) {
    }

    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $path = $request->getUri()->getPath();

        if ($this->excludedPaths !== null && in_array($path, $this->excludedPaths)) {

It seems like $this->excludedPaths can also be of type Kafkiansky\SymfonyMiddleware\null; however, parameter $haystack of in_array() does only seem to accept array, maybe add an additional type check?

            return $handler->handle($request);
        }

        if ($this->excludedPatterns !== null && $this->isMatchedByPattern($path)) {
            return $handler->handle($request);
        }

        if ($this->isCredentialsMatched($request)) {
            return $handler->handle($request);
        }

        return new Response(401, [
            'WWW-Authenticate' => 'Basic realm="'.$this->realm.'"'
        ]);
    }

    private function isCredentialsMatched(ServerRequestInterface $request): bool
    {
        $user = $request->getServerParams()['PHP_AUTH_USER'] ?? null;
        $passwd = $request->getServerParams()['PHP_AUTH_PW'] ?? null;

        return $user === $this->user && $passwd === $this->password;
    }

    private function isMatchedByPattern(string $path): bool
    {
        foreach ($this->excludedPatterns as $excludedPattern) {
            if (preg_match($excludedPattern, $path)) {
                return true;
            }
        }

        return false;
    }
}