kadet1090 / nucleus

Exception/Protocol/BindingException.php

Spacing +2 added lines, -2 removed lines

@@ -42,13 +42,13 @@
 
     private static function _conditionDescription(Error $error)
     {
-        if(!empty($error->text)) {
+        if (!empty($error->text)) {
             return $error->text;
         }
 
         return [
             'bad-request' => 'Bad Request: "{resource}" is not valid XMPP resource identifier.',
             'conflict'    => 'Conflict: {bare}/{resource} is already in use.'
-        ][$error->condition] ?? 'Unknown reason: '.$error->condition;
+        ][$error->condition] ?? 'Unknown reason: ' . $error->condition;
     }
 }

Utils/Filter/element.php

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
 {
     $predicate = $uri instanceof \Closure ? $uri : \Kadet\Xmpp\Utils\filter\same($uri);
 
-    return function ($element) use ($predicate) {
+    return function($element) use ($predicate) {
         if (!$element instanceof XmlElement) {
             return false;
         }
@@ -74,7 +74,7 @@ 
 {
     $predicate = $name instanceof \Closure ? $name : \Kadet\Xmpp\Utils\filter\same($name);
 
-    return function ($element) use ($predicate) {
+    return function($element) use ($predicate) {
         if (!$element instanceof XmlElement) {
             return false;
         }
@@ -108,7 +108,7 @@ 
 {
     $predicate = $value instanceof \Closure ? $value : \Kadet\Xmpp\Utils\filter\equals($value);
 
-    return function ($element) use ($name, $predicate) {
+    return function($element) use ($name, $predicate) {
         if (!$element instanceof XmlElement) {
             return false;
         }

Stanza/Stanza.php

Spacing +5 added lines, -5 removed lines

@@ -53,7 +53,7 @@ 
 
     public function getFrom()
     {
-        if((string)$this->_from !== $this->hasAttribute('from')) {
+        if ((string)$this->_from !== $this->hasAttribute('from')) {
             $this->_from = $this->hasAttribute('from') ? new Jid($this->_from) : null;
         }
 
@@ -62,7 +62,7 @@ 
 
     public function getTo()
     {
-        if((string)$this->_to !== $this->hasAttribute('to')) {
+        if ((string)$this->_to !== $this->hasAttribute('to')) {
             $this->_to = $this->hasAttribute('to') ? new Jid($this->_to) : null;
         }
 
@@ -86,7 +86,7 @@ 
 
     public function setFrom($from)
     {
-        if($from instanceof Jid) {
+        if ($from instanceof Jid) {
             $this->_from = $from instanceof Jid ? $from : new Jid($from);
         }
 
@@ -95,7 +95,7 @@ 
 
     public function setTo($to)
     {
-        if($to instanceof Jid) {
+        if ($to instanceof Jid) {
             $this->_to = $to instanceof Jid ? $to : new Jid($to);
         }
 
@@ -131,7 +131,7 @@ 
     public static function getXmlCollocations() : array
     {
         return [
-            [ Error::class, 'name' => 'error', 'uri' => 'jabber:client' ],
+            [Error::class, 'name' => 'error', 'uri' => 'jabber:client'],
         ];
     }
 }

Xml/XmlParser.php

Spacing +11 added lines, -11 removed lines

@@ -71,13 +71,13 @@ 
         xml_parser_set_option($this->_parser, XML_OPTION_SKIP_WHITE, 1);
         xml_parser_set_option($this->_parser, XML_OPTION_CASE_FOLDING, 0);
 
-        xml_set_element_handler($this->_parser, function ($parser, $name, $attrs) {
+        xml_set_element_handler($this->_parser, function($parser, $name, $attrs) {
             $this->handleElementStart($name, $attrs);
-        }, function () {
+        }, function() {
             $this->handleElementEnd();
         });
 
-        xml_set_character_data_handler($this->_parser, function ($parser, $data) {
+        xml_set_character_data_handler($this->_parser, function($parser, $data) {
             $this->handleTextData($data);
         });
 
@@ -111,8 +111,8 @@ 
             return 'http://www.w3.org/2000/xmlns/';
         }
 
-        if (isset($namespaces[ $prefix ])) {
-            return $namespaces[ $prefix ];
+        if (isset($namespaces[$prefix])) {
+            return $namespaces[$prefix];
         }
 
         return !empty($this->_stack) ? end($this->_stack)->lookupUri($prefix) : null;
@@ -123,10 +123,10 @@ 
         list($attributes, $namespaces) = $this->_attributes($attrs);
         list($tag, $prefix)            = XmlElement::resolve($name);
 
-        $uri   = $this->_lookup($prefix, $namespaces);
+        $uri = $this->_lookup($prefix, $namespaces);
 
         /** @var XmlElement $element */
-        $element = $this->factory->create($uri, $tag, [ $name, $uri ], $this->_getCollocations());
+        $element = $this->factory->create($uri, $tag, [$name, $uri], $this->_getCollocations());
 
         foreach ($namespaces as $prefix => $uri) {
             $element->setNamespace($uri, $prefix);
@@ -140,7 +140,7 @@ 
 
     private function _getCollocations()
     {
-        if(empty($this->_stack)) {
+        if (empty($this->_stack)) {
             return [];
         }
 
@@ -159,7 +159,7 @@ 
         if (count($this->_stack) > 0) {
             end($this->_stack)->append($element);
         }
-        $this->emit('parse.begin', [ $element, count($this->_stack) ]);
+        $this->emit('parse.begin', [$element, count($this->_stack)]);
 
         $this->_stack[] = $element;
     }
@@ -172,10 +172,10 @@ 
 
         $element = array_pop($this->_stack);
         if (count($this->_stack) == 1) {
-            $this->emit('element', [ $element, count($this->_stack) ]);
+            $this->emit('element', [$element, count($this->_stack)]);
         }
 
-        $this->emit('parse.end', [ $element, count($this->_stack) ]);
+        $this->emit('parse.end', [$element, count($this->_stack)]);
     }
 
     private function handleTextData($data)

Utils/Filter.php

Spacing +13 added lines, -13 removed lines

@@ -34,7 +34,7 @@ 
  */
 function equals($value) : \Closure
 {
-    return function ($argument) use ($value) {
+    return function($argument) use ($value) {
         return $argument == $value;
     };
 }
@@ -55,7 +55,7 @@ 
  */
 function same($value) : \Closure
 {
-    return function ($argument) use ($value) {
+    return function($argument) use ($value) {
         return $argument === $value;
     };
 }
@@ -77,7 +77,7 @@ 
  */
 function instance($expected) : \Closure
 {
-    return function ($object) use ($expected) {
+    return function($object) use ($expected) {
         return $expected instanceof \Closure ? $expected(get_class($object)) : $object instanceof $expected;
     };
 }
@@ -103,7 +103,7 @@ 
  */
 function matches($regex, ...$options) : \Closure
 {
-    return function ($value) use ($regex, $options) {
+    return function($value) use ($regex, $options) {
         return preg_match($regex, $value, $null, ...$options) > 0;
     };
 }
@@ -122,7 +122,7 @@ 
  * @return \Closure
  */
 function in(...$options) {
-    return function ($value) use ($options) {
+    return function($value) use ($options) {
         return in_array($value, $options);
     };
 }
@@ -196,7 +196,7 @@ 
  */
 function all(callable ...$functions) : \Closure
 {
-    return function (...$args) use ($functions) {
+    return function(...$args) use ($functions) {
         foreach ($functions as $function) {
             if (!$function(...$args)) {
                 return false;
@@ -225,7 +225,7 @@ 
  */
 function any(callable ...$functions) : \Closure
 {
-    return function (...$args) use ($functions) {
+    return function(...$args) use ($functions) {
         foreach ($functions as $function) {
             if ($function(...$args)) {
                 return true;
@@ -269,7 +269,7 @@ 
  */
 function not(callable $predicate) : \Closure
 {
-    return function (...$arguments) use ($predicate) {
+    return function(...$arguments) use ($predicate) {
         return !$predicate(...$arguments);
     };
 }
@@ -297,13 +297,13 @@ 
  */
 function argument(int $offset, callable $predicate, $length = true) : \Closure
 {
-    if($length === true) {
+    if ($length === true) {
         $length = 1;
-    } elseif($length === false) {
+    } elseif ($length === false) {
         $length = null;
     }
 
-    return function (...$arguments) use ($predicate, $offset, $length) {
+    return function(...$arguments) use ($predicate, $offset, $length) {
         return $predicate(...array_slice($arguments, $offset, $length, false));
     };
 }
@@ -326,9 +326,9 @@ 
  */
 function consecutive(callable ...$predicates)
 {
-    return function (...$arguments) use ($predicates) {
+    return function(...$arguments) use ($predicates) {
         foreach ($arguments as $index => $value) {
-            if(!$predicates[$index]($value)) {
+            if (!$predicates[$index]($value)) {
                 return false;
             }
         }

Xml/XmlStream.php

Spacing +13 added lines, -13 removed lines

@@ -91,35 +91,35 @@ 
         parent::__construct($transport);
         $this->setParser($parser);
 
-        $this->on('close', function () { $this->_isOpened = false; });
-        $this->on('element', function (Error $element) {
+        $this->on('close', function() { $this->_isOpened = false; });
+        $this->on('element', function(Error $element) {
             $this->handleError($element);
         }, with\instance(Error::class));
     }
 
     public function setParser(XmlParser $parser)
     {
-        if($this->_parser) {
-            $this->removeListener('data', [ $this->_parser, 'parse' ]);
+        if ($this->_parser) {
+            $this->removeListener('data', [$this->_parser, 'parse']);
         }
 
         $this->_parser = $parser;
 
-        $this->_parser->on('parse.begin', function (XmlElement $stream) {
+        $this->_parser->on('parse.begin', function(XmlElement $stream) {
             $this->_inbound = $stream;
-            $this->emit('stream.open', [ $stream ]);
+            $this->emit('stream.open', [$stream]);
         }, with\argument(1, with\equals(0)));
 
-        $this->_parser->on('parse.end', function (XmlElement $stream) {
-            $this->emit('stream.close', [ $stream ]);
+        $this->_parser->on('parse.end', function(XmlElement $stream) {
+            $this->emit('stream.close', [$stream]);
             $this->_inbound = null;
         }, with\argument(1, with\equals(0)));
 
-        $this->_parser->on('element', function (...$arguments) {
+        $this->_parser->on('element', function(...$arguments) {
             $this->emit('element', $arguments);
         });
 
-        $this->on('data', [ $this->_parser, 'parse' ]);
+        $this->on('data', [$this->_parser, 'parse']);
     }
 
     /**
@@ -130,11 +130,11 @@ 
      */
     public function write($data)
     {
-        if($data instanceof XmlElement) {
+        if ($data instanceof XmlElement) {
             $this->_outbound->append($data);
         }
 
-        $this->emit('send.'.($data instanceof XmlElement ? 'element' : 'text'), [ $data ]);
+        $this->emit('send.' . ($data instanceof XmlElement ? 'element' : 'text'), [$data]);
 
         return parent::write($data);
     }
@@ -195,7 +195,7 @@ 
 
     private function handleError(Error $element)
     {
-        if ($this->emit('stream.error', [ $element ])) {
+        if ($this->emit('stream.error', [$element])) {
             throw new StreamErrorException($element);
         }
 

Xml/XmlElement.php

Doc Comments +4 added lines, -1 removed lines

@@ -259,7 +259,7 @@ 
      *
      * @param string      $attribute Attribute name, optionally with prefix
      * @param string|null $uri       XML Namespace URI of attribute, prefix will be automatically looked up
-     * @return bool|mixed
+     * @return string
      */
     public function getAttribute(string $attribute, string $uri = null)
     {
@@ -335,6 +335,9 @@ 
         return $this->appendChild($element);
     }
 
+    /**
+     * @param XmlElement $element
+     */
     public function remove($element)
     {
         $this->_children = array_filter($this->_children, not(filter\same($element)));

Spacing +14 added lines, -14 removed lines

@@ -136,7 +136,7 @@ 
      */
     public function getInnerXml()
     {
-        return implode('', array_map(function ($element) {
+        return implode('', array_map(function($element) {
             if (is_string($element)) {
                 return htmlspecialchars($element);
             } elseif ($element instanceof XmlElement) {
@@ -181,7 +181,7 @@ 
         $attributes = $this->attributes();
 
         $result = "<{$this->name}";
-        $result .= ' ' . implode(' ', array_map(function ($key, $value) {
+        $result .= ' ' . implode(' ', array_map(function($key, $value) {
             return $key . '="' . htmlspecialchars($value, ENT_QUOTES) . '"';
         }, array_keys($attributes), array_values($attributes)));
 
@@ -202,7 +202,7 @@ 
      */
     public function lookupPrefix(string $uri = null)
     {
-        return $this->getNamespaces()[ $uri ] ?? false;
+        return $this->getNamespaces()[$uri] ?? false;
     }
 
     /**
@@ -246,12 +246,12 @@ 
     {
         $attribute = $this->_prefix($attribute, $uri);
         if ($value === null) {
-            unset($this->_attributes[ $attribute ]);
+            unset($this->_attributes[$attribute]);
 
             return;
         }
 
-        $this->_attributes[ $attribute ] = $value;
+        $this->_attributes[$attribute] = $value;
     }
 
     /**
@@ -263,7 +263,7 @@ 
      */
     public function getAttribute(string $attribute, string $uri = null)
     {
-        return $this->_attributes[ $this->_prefix($attribute, $uri) ] ?? false;
+        return $this->_attributes[$this->_prefix($attribute, $uri)] ?? false;
     }
 
     /**
@@ -276,7 +276,7 @@ 
      */
     public function hasAttribute(string $attribute, string $uri = null)
     {
-        return isset($this->_attributes[ $this->_prefix($attribute, $uri) ]);
+        return isset($this->_attributes[$this->_prefix($attribute, $uri)]);
     }
 
     /**
@@ -285,7 +285,7 @@ 
      */
     public function getParents()
     {
-        return $this->_parent ? array_merge([ $this->_parent ], $this->_parent->getParents()) : [];
+        return $this->_parent ? array_merge([$this->_parent], $this->_parent->getParents()) : [];
     }
 
     /**
@@ -304,7 +304,7 @@ 
     protected function setParent(XmlElement $parent)
     {
         if (!$this->_prefix && ($prefix = $parent->lookupPrefix($this->namespace)) !== false) {
-            $this->_namespaces[ $this->namespace ] = $prefix;
+            $this->_namespaces[$this->namespace] = $prefix;
             $this->_prefix                         = $prefix;
         }
 
@@ -327,7 +327,7 @@ 
             return false;
         }
 
-        if(is_array($element)) {
+        if (is_array($element)) {
             array_walk($element, [$this, 'appendChild']);
             return $element;
         }
@@ -338,7 +338,7 @@ 
     public function remove($element)
     {
         $this->_children = array_filter($this->_children, not(filter\same($element)));
-        if($element instanceof XmlElement) {
+        if ($element instanceof XmlElement) {
             $element->_parent = null;
         }
     }
@@ -388,7 +388,7 @@ 
             $prefix = $this->_prefix;
         }
 
-        $this->_namespaces[ $uri ] = $prefix;
+        $this->_namespaces[$uri] = $prefix;
     }
 
     public function getName()
@@ -436,7 +436,7 @@ 
      */
     public function element(string $name, string $uri = null, int $index = 0)
     {
-        return array_values($this->elements($name, $uri))[ $index ] ?? false;
+        return array_values($this->elements($name, $uri))[$index] ?? false;
     }
 
     /**
@@ -517,7 +517,7 @@ 
     private function attributes(): array
     {
         $namespaces = $this->getNamespaces(false);
-        $namespaces = array_map(function ($prefix, $uri) {
+        $namespaces = array_map(function($prefix, $uri) {
             return [$prefix ? "xmlns:{$prefix}" : 'xmlns', $uri];
         }, array_values($namespaces), array_keys($namespaces));
 

XmppClient.php

Doc Comments +1 added lines, -1 removed lines

@@ -200,7 +200,7 @@
      * Registers module in client's dependency container.
      *
      * @param ComponentInterface $module    Module to be registered
-     * @param bool|string|array  $alias     Module alias, class name by default.
+     * @param string|boolean  $alias     Module alias, class name by default.
      *                                      `true` for aliasing interfaces and parents too,
      *                                      `false` for aliasing as class name only
      *                                      array for multiple aliases,

Spacing +8 added lines, -8 removed lines

@@ -132,12 +132,12 @@ 
 
         $this->applyOptions($options);
 
-        $this->on('element', function (Features $element) {
+        $this->on('element', function(Features $element) {
             $this->_features = $element;
             $this->emit('features', [$element]);
         }, Features::class);
 
-        $this->on('close', function (Features $element) {
+        $this->on('close', function(Features $element) {
             $this->state = 'disconnected';
         }, Features::class);
     }
@@ -189,7 +189,7 @@ 
         $this->state = 'bound';
 
         $queue = new \SplQueue();
-        $this->emit('init', [ $queue ]);
+        $this->emit('init', [$queue]);
 
         \React\Promise\all(iterator_to_array($queue))->then(function() {
             $this->state = 'ready';
@@ -213,10 +213,10 @@ 
             $this->_container->set(get_class($module), $module);
 
             $this->_addToContainer($module, array_merge(class_implements($module), array_slice(class_parents($module), 1)));
-        } elseif(is_array($alias)) {
+        } elseif (is_array($alias)) {
             $this->_addToContainer($module, $alias);
         } else {
-            $this->_addToContainer($module, [ $alias === false ? get_class($module) : $alias ]);
+            $this->_addToContainer($module, [$alias === false ? get_class($module) : $alias]);
         }
     }
 
@@ -239,7 +239,7 @@ 
         $deferred = new Deferred();
 
         $this->once('element', function(Stanza $stanza) use ($deferred) {
-            if($stanza->type === "error") {
+            if ($stanza->type === "error") {
                 $deferred->reject($stanza);
             } else {
                 $deferred->resolve($stanza);
@@ -275,7 +275,7 @@ 
     //region Parser
     public function setParser(XmlParser $parser)
     {
-        if($this->state !== "disconnected") {
+        if ($this->state !== "disconnected") {
             throw new \BadMethodCallException('Parser can be changed only when client is disconnected.');
         }
 
@@ -303,7 +303,7 @@ 
             ));
         }
 
-        $this->_connector->on('connect', function ($stream) {
+        $this->_connector->on('connect', function($stream) {
             return $this->handleConnect($stream);
         });
     }

Xml/XmlElementFactory.php

Spacing +2 added lines, -2 removed lines

@@ -33,7 +33,7 @@ 
         }
 
         foreach ($lookup['<predicate>'] as list($class, $predicate)) {
-            if($predicate($tag, $namespace)) {
+            if ($predicate($tag, $namespace)) {
                 return $class;
             }
         }
@@ -64,7 +64,7 @@ 
     {
         $result = ['<predicate>' => []];
         foreach ($dictionary as $element) {
-            if($element['name'] instanceof \Closure || $element['uri'] instanceof \Closure) {
+            if ($element['name'] instanceof \Closure || $element['uri'] instanceof \Closure) {
                 $result['<predicate>'][] = [$element[0], \Kadet\Xmpp\Utils\filter\consecutive(
                     \Kadet\Xmpp\Utils\filter\predicate($element['name']),
                     \Kadet\Xmpp\Utils\filter\predicate($element['uri'])