Kadet\Xmpp\Stanza\Stanza

Complexity

Total Complexity

22

Size/Duplication

Total Lines	117
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes	3
Bugs	0	Features	1

14 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getFrom()	0	8	3
A	getTo()	0	8	3
A	getType()	0	4	1
A	getId()	0	4	1
A	getError()	0	4	1
A	setFrom()	0	8	3
A	setTo()	0	8	3
A	setType()	0	4	1
A	setId()	0	4	1
A	regenerateId()	0	4	1
A	response()	0	10	1
A	init()	0	5	1
A	getXmlCollocations()	0	6	1

<?php
/**
 * Nucleus - XMPP Library for PHP
 *
 * Copyright (C) 2016, Some rights reserved.
 *
 * @author Kacper "Kadet" Donat <kacper@kadet.net>
 *
 * Contact with author:
 * Xmpp: me@kadet.net
 * E-mail: contact@kadet.net
 *
 * From Kadet with love.
 */

namespace Kadet\Xmpp\Stanza;


use Kadet\Xmpp\Jid;
use Kadet\Xmpp\Xml\XmlElement;
use Kadet\Xmpp\Xml\XmlFactoryCollocations;

/**
 * Class Stanza
 * @package Kadet\Xmpp\Stanza
 *
 * @property Jid|null $from  Jid representing "from" stanza attribute
 * @property Jid|null $to    Jid representing "to" stanza attribute
 * @property string   $type  Stanza type
 * @property string   $id    Unique stanza id
 * @property Error    $error Error details
 */
class Stanza extends XmlElement implements XmlFactoryCollocations
{
    private $_from = false;
    private $_to   = false;

    /**
     * Stanza constructor.
     * @param string   $kind    Stanza kind. According to XMPP RFC, one of "iq", "message", "presence"
     * @param array    $options {
     *     @var Jid    $from    Jid representing "from" stanza attribute
     *     @var Jid    $to      Jid representing "to" stanza attribute
     *     @var string $id      Unique id, will be generated if omitted
     *     @var string $type    Stanza type
     * }
     */
    public function __construct(string $kind, array $options = [])
    {
        $this->regenerateId($kind);
        parent::__construct($kind, 'jabber:client', $options);
    }

    public function getFrom()
    {
        if($this->_from === false) {
            $this->_from = $this->hasAttribute('from') ? new Jid($this->_from) : null;

$this->_from is of type boolean, but the function expects a string.

It seems like $this->hasAttribute('from') ? new \Kadet\Xmpp\Jid($this->_from) : null can also be of type object<Kadet\Xmpp\Jid>. However, the property $_from is declared as type boolean. Maybe add an additional type check?

        }

        return $this->_from;
    }

    public function getTo()
    {
        if($this->_to === false) {
            $this->_to = $this->hasAttribute('to') ? new Jid($this->_to) : null;

$this->_to is of type boolean, but the function expects a string.

It seems like $this->hasAttribute('to') ? new \Kadet\Xmpp\Jid($this->_to) : null can also be of type object<Kadet\Xmpp\Jid>. However, the property $_to is declared as type boolean. Maybe add an additional type check?

        }

        return $this->_to;
    }

    public function getType()
    {
        return $this->getAttribute('type');
    }

    public function getId()
    {
        return $this->getAttribute('id');
    }

    public function getError()
    {
        return $this->element('error');
    }

    public function setFrom($from)
    {
        if($from instanceof Jid) {
            $this->_from = $from instanceof Jid ? $from : new Jid($from);

It seems like $from instanceof \Kadet\Xmpp\Jid ? $from : new \Kadet\Xmpp\Jid($from) of type object<Kadet\Xmpp\Jid> is incompatible with the declared type boolean of property $_from.

        }

        $this->setAttribute('from', (string)$from);
    }

    public function setTo($to)
    {
        if($to instanceof Jid) {
            $this->_to = $to instanceof Jid ? $to : new Jid($to);

It seems like $to instanceof \Kadet\Xmpp\Jid ? $to : new \Kadet\Xmpp\Jid($to) of type object<Kadet\Xmpp\Jid> is incompatible with the declared type boolean of property $_to.

        }

        $this->setAttribute('to', (string)$to);
    }

    public function setType(string $type)
    {
        $this->setAttribute('type', $type);
    }

    public function setId(string $id)
    {
        $this->setAttribute('id', $id);
    }

    public function regenerateId(string $prefix = null)
    {
        $this->id = uniqid($prefix, true);
    }

    public function response()
    {
        $response = static::plain($this->name, $this->namespace);

        $response->to   = $this->from;
        $response->from = $this->to;
        $response->id   = $this->id;

        return $response;
    }

    /**
     * Initializes element with given name and URI
     *
     * @param string $name Element name, including prefix if needed
     * @param string $uri  Namespace URI of element
     */
    protected function init(string $name, string $uri = null)
    {
        parent::init($name, $uri);
        $this->regenerateId();
    }

    public static function getXmlCollocations() : array
    {
        return [
            [ Error::class, 'name' => 'error', 'uri' => 'jabber:client' ],
        ];
    }
}