BindingException - Code Metrics - Inspection of "add StanzaException class" - kadet1090/nucleus - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5f3a6c...fcd09b )

by Kacper

created 2016-08-21 21:16 UTC

BindingException A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

Importance

Changes

Metric	Value
dl	0
loc	32
ccs	0
cts	10
cp	0
rs	10
c	0
b	0
f	0
wmc	4
lcom	0
cbo	3

2 Methods

Rating	Name	Duplication	Size	Complexity
A	fromError()	0	8	2
A	_conditionDescription()	0	11	2

<?php
/**
 * Nucleus - XMPP Library for PHP
 *
 * Copyright (C) 2016, Some rights reserved.
 *
 * @author Kacper "Kadet" Donat <[email protected]>
 *
 * Contact with author:
 * Xmpp: [email protected]
 * E-mail: [email protected]
 *
 * From Kadet with love.
 */

namespace Kadet\Xmpp\Exception\Protocol;


use Exception;
use Kadet\Xmpp\Jid;
use Kadet\Xmpp\Stanza\Error;

class BindingException extends StanzaException
{
    /**
     * Construct the exception. Note: The message is NOT binary safe.
     *
     * @param Jid       $jid
     * @param Error     $error
     * @param Exception $previous [optional] The previous exception used for the exception chaining. Since 5.3.0
     * @return static
     * @since    5.1.0
     */
    public static function fromError(Jid $jid, Error $error, Exception $previous = null)
    {
        return new static($error, \Kadet\Xmpp\Utils\helper\format("Cannot bind {resource} for {bare}. {condition}", [
            'resource'  => $jid->resource ?: "no resource",
            'bare'      => (string)$jid->bare(),
            'condition' => static::_conditionDescription($error)
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
        ]), 0, $previous);
    }

    private static function _conditionDescription(Error $error)
    {
        if(!empty($error->text)) {
            return $error->text;
        }

        return [
            'bad-request' => 'Bad Request: "{resource}" is not valid XMPP resource identifier.',
            'conflict'    => 'Conflict: {bare}/{resource} is already in use.'
        ][$error->condition] ?? 'Unknown reason: '.$error->condition;
    }
}


1			<?php
2			/**
3			* Nucleus - XMPP Library for PHP
4			*
5			* Copyright (C) 2016, Some rights reserved.
6			*
7			* @author Kacper "Kadet" Donat <[email protected]>
8			*
9			* Contact with author:
10			* Xmpp: [email protected]
11			* E-mail: [email protected]
12			*
13			* From Kadet with love.
14			*/
15
16			namespace Kadet\Xmpp\Exception\Protocol;
17
18
19			use Exception;
20			use Kadet\Xmpp\Jid;
21			use Kadet\Xmpp\Stanza\Error;
22
23			class BindingException extends StanzaException
24			{
25			/**
26			* Construct the exception. Note: The message is NOT binary safe.
27			*
28			* @param Jid $jid
29			* @param Error $error
30			* @param Exception $previous [optional] The previous exception used for the exception chaining. Since 5.3.0
31			* @return static
32			* @since 5.1.0
33			*/
34			public static function fromError(Jid $jid, Error $error, Exception $previous = null)
35			{
36			return new static($error, \Kadet\Xmpp\Utils\helper\format("Cannot bind {resource} for {bare}. {condition}", [
37			'resource' => $jid->resource ?: "no resource",
38			'bare' => (string)$jid->bare(),
39			'condition' => static::_conditionDescription($error)
			0 ignored issues – show Bug introduced 2016-08-21 21:22 UTC by Report Bug Copy Issue Report Since `_conditionDescription()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `_conditionDescription()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
40			]), 0, $previous);
41			}
42
43			private static function _conditionDescription(Error $error)
44			{
45			if(!empty($error->text)) {
46			return $error->text;
47			}
48
49			return [
50			'bad-request' => 'Bad Request: "{resource}" is not valid XMPP resource identifier.',
51			'conflict' => 'Conflict: {bare}/{resource} is already in use.'
52			][$error->condition] ?? 'Unknown reason: '.$error->condition;
53			}
54			}
55

kadet1090 / nucleus

Push — master ( 5f3a6c...fcd09b )

BindingException A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like