Complex classes like XmlElement often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use XmlElement, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 40 | class XmlElement |
||
| 41 | { |
||
| 42 | use Accessors; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * Settings for tiding up XML output |
||
| 46 | * |
||
| 47 | * @var array |
||
| 48 | */ |
||
| 49 | public static $tidy = [ |
||
| 50 | 'indent' => true, |
||
| 51 | 'input-xml' => true, |
||
| 52 | 'output-xml' => true, |
||
| 53 | 'drop-empty-paras' => false, |
||
| 54 | 'wrap' => 0 |
||
| 55 | ]; |
||
| 56 | |||
| 57 | /** @var string */ |
||
| 58 | private $_localName; |
||
| 59 | /** @var null|string|false */ |
||
| 60 | private $_prefix = null; |
||
| 61 | |||
| 62 | /** @var array */ |
||
| 63 | private $_namespaces = []; |
||
| 64 | /** @var array */ |
||
| 65 | private $_attributes = []; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @var XmlElement |
||
| 69 | */ |
||
| 70 | private $_parent; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * @var XmlElement[] |
||
| 74 | */ |
||
| 75 | private $_children = []; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * Initializes element with given name and URI |
||
| 79 | * |
||
| 80 | * @param string $name Element name, including prefix if needed |
||
| 81 | * @param string $uri Namespace URI of element |
||
| 82 | */ |
||
| 83 | 19 | protected function init(string $name, string $uri = null) |
|
| 94 | |||
| 95 | /** |
||
| 96 | * XmlElement constructor |
||
| 97 | * |
||
| 98 | * @param string $name Element name, including prefix if needed |
||
| 99 | * @param string $uri Namespace URI of element |
||
| 100 | */ |
||
| 101 | 15 | public function __construct(string $name, string $uri = null) |
|
| 105 | |||
| 106 | /** |
||
| 107 | * Elements named constructor, same for every subclass. |
||
| 108 | * It's used for factory creation. |
||
| 109 | * |
||
| 110 | * @param string $name Element name, including prefix if needed |
||
| 111 | * @param string $uri Namespace URI of element |
||
| 112 | * |
||
| 113 | * @return XmlElement |
||
| 114 | */ |
||
| 115 | 4 | public static function plain(string $name, string $uri = null) |
|
| 123 | |||
| 124 | /** |
||
| 125 | * @see $innerXml |
||
| 126 | * @return string |
||
| 127 | */ |
||
| 128 | 2 | public function getInnerXml() |
|
| 140 | |||
| 141 | /** |
||
| 142 | * Returns XML representation of element |
||
| 143 | * |
||
| 144 | * @param bool $clean Result will be cleaned if set to true |
||
| 145 | * |
||
| 146 | * @return string |
||
| 147 | */ |
||
| 148 | 2 | public function xml(bool $clean = true): string |
|
| 169 | |||
| 170 | /** |
||
| 171 | * Looks up prefix associated with given URI |
||
| 172 | * |
||
| 173 | * @param string|null $uri |
||
| 174 | * @return string|false |
||
| 175 | */ |
||
| 176 | 10 | public function lookupPrefix(string $uri = null) |
|
| 180 | |||
| 181 | /** |
||
| 182 | * Looks up URI associated with given prefix |
||
| 183 | * |
||
| 184 | * @param string|null $prefix |
||
| 185 | * @return string|false |
||
| 186 | */ |
||
| 187 | 14 | public function lookupUri(string $prefix = null) |
|
| 191 | |||
| 192 | /** |
||
| 193 | * Returns element's namespaces |
||
| 194 | * |
||
| 195 | * @param bool $parent Include namespaces from parent? |
||
| 196 | * @return array |
||
| 197 | */ |
||
| 198 | 16 | public function getNamespaces($parent = true): array |
|
| 210 | |||
| 211 | /** |
||
| 212 | * Sets XML attribute of element |
||
| 213 | * |
||
| 214 | * @param string $attribute Attribute name, optionally with prefix |
||
| 215 | * @param mixed $value Attribute value |
||
| 216 | * @param string|null $uri XML Namespace URI of attribute, prefix will be automatically looked up |
||
| 217 | */ |
||
| 218 | 4 | public function setAttribute(string $attribute, $value, string $uri = null) |
|
| 222 | |||
| 223 | /** |
||
| 224 | * Returns value of specified attribute. |
||
| 225 | * |
||
| 226 | * @param string $attribute Attribute name, optionally with prefix |
||
| 227 | * @param string|null $uri XML Namespace URI of attribute, prefix will be automatically looked up |
||
| 228 | * @return bool|mixed |
||
| 229 | */ |
||
| 230 | 2 | public function getAttribute(string $attribute, string $uri = null) |
|
| 234 | |||
| 235 | /** |
||
| 236 | * Checks if attribute exists |
||
| 237 | * |
||
| 238 | * @param string $attribute Attribute name, optionally with prefix |
||
| 239 | * @param string|null $uri XML Namespace URI of attribute, prefix will be automatically looked up |
||
| 240 | * |
||
| 241 | * @return bool |
||
| 242 | */ |
||
| 243 | 2 | public function hasAttribute(string $attribute, string $uri = null) |
|
| 247 | |||
| 248 | /** |
||
| 249 | * Returns element's parent |
||
| 250 | * @return XmlElement|null |
||
| 251 | */ |
||
| 252 | 1 | public function getParent() |
|
| 256 | |||
| 257 | /** |
||
| 258 | * Sets element's parent |
||
| 259 | * @param XmlElement $parent |
||
| 260 | */ |
||
| 261 | 9 | protected function setParent(XmlElement $parent) |
|
| 273 | |||
| 274 | /** |
||
| 275 | * Appends child to element |
||
| 276 | * |
||
| 277 | * @param XmlElement|string $element |
||
| 278 | * |
||
| 279 | * @return XmlElement|string Same as $element |
||
| 280 | */ |
||
| 281 | 11 | public function append($element) |
|
| 296 | |||
| 297 | /** |
||
| 298 | * Returns namespace URI associated with element |
||
| 299 | * |
||
| 300 | * @return false|string |
||
| 301 | */ |
||
| 302 | 14 | public function getNamespace() |
|
| 306 | |||
| 307 | /** |
||
| 308 | * Adds namespace to element, and associates it with prefix. |
||
| 309 | * |
||
| 310 | * @param string $uri Namespace URI |
||
| 311 | * @param string|bool|null $prefix Prefix which will be used for namespace, false for using element's prefix |
||
| 312 | * and null for no prefix |
||
| 313 | */ |
||
| 314 | 13 | public function setNamespace(string $uri, $prefix = false) |
|
| 322 | |||
| 323 | 6 | public function getName() |
|
| 327 | |||
| 328 | 5 | public function getChildren() |
|
| 332 | |||
| 333 | 14 | public function getPrefix() |
|
| 337 | |||
| 338 | 9 | public function getLocalName() |
|
| 342 | |||
| 343 | 6 | public function getAttributes() |
|
| 347 | |||
| 348 | /** |
||
| 349 | * Returns one element at specified index (for default the first one). |
||
| 350 | * |
||
| 351 | * @param string $name Requested element tag name |
||
| 352 | * @param string $uri Requested element namespace |
||
| 353 | * @param int $index Index of element to retrieve |
||
| 354 | * |
||
| 355 | * @return XmlElement|false Retrieved element |
||
| 356 | */ |
||
| 357 | 1 | public function element(string $name, string $uri = null, int $index = 0) |
|
| 361 | |||
| 362 | /** |
||
| 363 | * Retrieves array of matching elements |
||
| 364 | * |
||
| 365 | * @param string $name Requested element tag name |
||
| 366 | * @param string|null $uri Requested element namespace |
||
| 367 | * |
||
| 368 | * @return XmlElement[] Found Elements |
||
| 369 | */ |
||
| 370 | 2 | public function elements($name, $uri = null) : array |
|
| 379 | |||
| 380 | /** |
||
| 381 | * Filters element with given predicate |
||
| 382 | * |
||
| 383 | * @param callable|string $predicate Predicate or class name |
||
| 384 | * |
||
| 385 | * @return XmlElement[] |
||
| 386 | */ |
||
| 387 | 2 | public function all($predicate) |
|
| 391 | |||
| 392 | /** |
||
| 393 | * Iterates over matching elements |
||
| 394 | * |
||
| 395 | * @param callable|string $predicate Predicate or class name |
||
| 396 | * |
||
| 397 | * @return XmlElement|false |
||
| 398 | */ |
||
| 399 | 1 | public function find($predicate) |
|
| 409 | |||
| 410 | /** |
||
| 411 | * @param string|null $query |
||
| 412 | * @return XPathQuery |
||
| 413 | */ |
||
| 414 | 1 | public function query(string $query = null) |
|
| 418 | |||
| 419 | /** |
||
| 420 | * Helper for retrieving all arguments (including namespaces) |
||
| 421 | * |
||
| 422 | * @return array |
||
| 423 | */ |
||
| 424 | 2 | private function attributes(): array |
|
| 436 | |||
| 437 | /** |
||
| 438 | * Prefixes $name with attribute associated with $uri |
||
| 439 | * |
||
| 440 | * @param string $name Name to prefix |
||
| 441 | * @param string $uri Namespace URI |
||
| 442 | * |
||
| 443 | * @return string |
||
| 444 | */ |
||
| 445 | 4 | protected function _prefix(string $name, string $uri = null): string |
|
| 457 | |||
| 458 | 1 | public function __toString() |
|
| 462 | |||
| 463 | /** |
||
| 464 | * Splits name into local-name and prefix |
||
| 465 | * |
||
| 466 | * @param $name |
||
| 467 | * @return array [$name, $prefix] |
||
| 468 | */ |
||
| 469 | 19 | public static function resolve($name) |
|
| 479 | } |
||
| 480 |