Inspection of "Removed always false condition" - kadet1090/KeyLighter - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — 0.8-dev (82421f)

by Kacper

created 2016-04-09 21:46 UTC

Status

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * Highlighter
- *
- * Copyright (C) 2016, Some right reserved.
- *
- * @author Kacper "Kadet" Donat <[email protected]>
- *
- * Contact with author:
- * Xmpp:   [email protected]
- * E-mail: [email protected]
- *
- * From Kadet with love.
- */
+     * Highlighter
+     *
+     * Copyright (C) 2016, Some right reserved.
+     *
+     * @author Kacper "Kadet" Donat <[email protected]>
+     *
+     * Contact with author:
+     * Xmpp:   [email protected]
+     * E-mail: [email protected]
+     *
+     * From Kadet with love.
+     */
 
 namespace Kadet\Highlighter\Formatter;
 

Please login to merge, or discard this patch.

Formatter/FormatterInterface.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * Highlighter
- *
- * Copyright (C) 2016, Some right reserved.
- *
- * @author Kacper "Kadet" Donat <[email protected]>
- *
- * Contact with author:
- * Xmpp: [email protected]
- * E-mail: [email protected]
- *
- * From Kadet with love.
- */
+     * Highlighter
+     *
+     * Copyright (C) 2016, Some right reserved.
+     *
+     * @author Kacper "Kadet" Donat <[email protected]>
+     *
+     * Contact with author:
+     * Xmpp: [email protected]
+     * E-mail: [email protected]
+     *
+     * From Kadet with love.
+     */
 
 namespace Kadet\Highlighter\Language;
 

Please login to merge, or discard this patch.

Language/Php.php 1 patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -1,16 +1,16 @@
 block discarded – undo
 <?php
 /**
- * Highlighter
- *
- * Copyright (C) 2016, Some right reserved.
- * @author Kacper "Kadet" Donat <[email protected]>
- *
- * Contact with author:
- * Xmpp: [email protected]
- * E-mail: [email protected]
- *
- * From Kadet with love.
- */
+     * Highlighter
+     *
+     * Copyright (C) 2016, Some right reserved.
+     * @author Kacper "Kadet" Donat <[email protected]>
+     *
+     * Contact with author:
+     * Xmpp: [email protected]
+     * E-mail: [email protected]
+     *
+     * From Kadet with love.
+     */
 
 namespace Kadet\Highlighter\Language;
 

Please login to merge, or discard this patch.

Utils/Helper.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * Highlighter
- *1
- * Copyright (C) 2016, Some right reserved.
- *
- * @author Kacper "Kadet" Donat <[email protected]>
- *
- * Contact with author:
- * Xmpp: [email protected]
- * E-mail: [email protected]
- *
- * From Kadet with love.
- */
+     * Highlighter
+     *1
+     * Copyright (C) 2016, Some right reserved.
+     *
+     * @author Kacper "Kadet" Donat <[email protected]>
+     *
+     * Contact with author:
+     * Xmpp: [email protected]
+     * E-mail: [email protected]
+     *
+     * From Kadet with love.
+     */
 
 namespace Kadet\Highlighter\Matcher;
 

Please login to merge, or discard this patch.

Matcher/WholeMatcher.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * Highlighter
- *1
- * Copyright (C) 2016, Some right reserved.
- *
- * @author Kacper "Kadet" Donat <[email protected]>
- *
- * Contact with author:
- * Xmpp: [email protected]
- * E-mail: [email protected]
- *
- * From Kadet with love.
- */
+     * Highlighter
+     *1
+     * Copyright (C) 2016, Some right reserved.
+     *
+     * @author Kacper "Kadet" Donat <[email protected]>
+     *
+     * Contact with author:
+     * Xmpp: [email protected]
+     * E-mail: [email protected]
+     *
+     * From Kadet with love.
+     */
 
 namespace Kadet\Highlighter\Matcher;
 

Please login to merge, or discard this patch.

Parser/OpenRule.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * Highlighter
- *1
- * Copyright (C) 2016, Some right reserved.
- *
- * @author Kacper "Kadet" Donat <[email protected]>
- *
- * Contact with author:
- * Xmpp: [email protected]
- * E-mail: [email protected]
- *
- * From Kadet with love.
- */
+     * Highlighter
+     *1
+     * Copyright (C) 2016, Some right reserved.
+     *
+     * @author Kacper "Kadet" Donat <[email protected]>
+     *
+     * Contact with author:
+     * Xmpp: [email protected]
+     * E-mail: [email protected]
+     *
+     * From Kadet with love.
+     */
 
 namespace Kadet\Highlighter\Matcher;
 

Please login to merge, or discard this patch.

Parser/CloseRule.php 1 patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * Highlighter
- *1
- * Copyright (C) 2016, Some right reserved.
- *
- * @author Kacper "Kadet" Donat <[email protected]>
- *
- * Contact with author:
- * Xmpp: [email protected]
- * E-mail: [email protected]
- *
- * From Kadet with love.
- */
+     * Highlighter
+     *1
+     * Copyright (C) 2016, Some right reserved.
+     *
+     * @author Kacper "Kadet" Donat <[email protected]>
+     *
+     * Contact with author:
+     * Xmpp: [email protected]
+     * E-mail: [email protected]
+     *
+     * From Kadet with love.
+     */
 
 namespace Kadet\Highlighter\Matcher;
 

Please login to merge, or discard this patch.

Parser/Token/ContextualToken.php 2 patches

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * Highlighter
- *1
- * Copyright (C) 2016, Some right reserved.
- *
- * @author Kacper "Kadet" Donat <[email protected]>
- *
- * Contact with author:
- * Xmpp: [email protected]
- * E-mail: [email protected]
- *
- * From Kadet with love.
- */
+     * Highlighter
+     *1
+     * Copyright (C) 2016, Some right reserved.
+     *
+     * @author Kacper "Kadet" Donat <[email protected]>
+     *
+     * Contact with author:
+     * Xmpp: [email protected]
+     * E-mail: [email protected]
+     *
+     * From Kadet with love.
+     */
 
 namespace Kadet\Highlighter\Matcher;
 

Please login to merge, or discard this patch.

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -43,7 +43,7 @@
 block discarded – undo
                 $this->_end->_valid = false;
             }
         } else {
-            if (!$this->rule->validator->validate($context, [ $this->name => Validator::CONTEXT_IN ])) {
+            if (!$this->rule->validator->validate($context, [$this->name => Validator::CONTEXT_IN])) {
                 $this->setValid(false);
             } else {
                 $this->_valid       = false;

Please login to merge, or discard this patch.

KeyLighter.php 2 patches

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@
 block discarded – undo
 <?php
 /**
- * Highlighter
- *
- * Copyright (C) 2016, Some right reserved.
- *
- * @author Kacper "Kadet" Donat <[email protected]>
- *
- * Contact with author:
- * Xmpp: [email protected]
- * E-mail: [email protected]
- *
- * From Kadet with love.
- */
+     * Highlighter
+     *
+     * Copyright (C) 2016, Some right reserved.
+     *
+     * @author Kacper "Kadet" Donat <[email protected]>
+     *
+     * Contact with author:
+     * Xmpp: [email protected]
+     * E-mail: [email protected]
+     *
+     * From Kadet with love.
+     */
 
 namespace Kadet\Highlighter\Language;
 

Please login to merge, or discard this patch.

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -64,8 +64,8 @@
 block discarded – undo
     }
 
     /**
-     * @param Language|callable|string $language
-     * @param array[string]            $aliases
+     * @param string $language
+     * @param string[]            $aliases
      */
     public function registerLanguage($language, $aliases)
     {

Please login to merge, or discard this patch.

		@@ -64,8 +64,8 @@
		block discarded – undo
64	64	}
65	65
66	66	/**
67		- * @param Language\|callable\|string $language
68		- * @param array[string] $aliases
	67	+ * @param string $language
	68	+ * @param string[] $aliases
69	69	*/
70	70	public function registerLanguage($language, $aliases)
71	71	{

		@@ -1,17 +1,17 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Highlighter
4		- *
5		- * Copyright (C) 2016, Some right reserved.
6		- *
7		- * @author Kacper "Kadet" Donat <[email protected]>
8		- *
9		- * Contact with author:
10		- * Xmpp: [email protected]
11		- * E-mail: [email protected]
12		- *
13		- * From Kadet with love.
14		- */
	3	+ * Highlighter
	4	+ *
	5	+ * Copyright (C) 2016, Some right reserved.
	6	+ *
	7	+ * @author Kacper "Kadet" Donat <[email protected]>
	8	+ *
	9	+ * Contact with author:
	10	+ * Xmpp: [email protected]
	11	+ * E-mail: [email protected]
	12	+ *
	13	+ * From Kadet with love.
	14	+ */
15	15
16	16	namespace Kadet\Highlighter\Formatter;
17	17

		@@ -1,16 +1,16 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Highlighter
4		- *
5		- * Copyright (C) 2016, Some right reserved.
6		- * @author Kacper "Kadet" Donat <[email protected]>
7		- *
8		- * Contact with author:
9		- * Xmpp: [email protected]
10		- * E-mail: [email protected]
11		- *
12		- * From Kadet with love.
13		- */
	3	+ * Highlighter
	4	+ *
	5	+ * Copyright (C) 2016, Some right reserved.
	6	+ * @author Kacper "Kadet" Donat <[email protected]>
	7	+ *
	8	+ * Contact with author:
	9	+ * Xmpp: [email protected]
	10	+ * E-mail: [email protected]
	11	+ *
	12	+ * From Kadet with love.
	13	+ */
14	14
15	15	namespace Kadet\Highlighter\Language;
16	16

		@@ -43,7 +43,7 @@
		block discarded – undo
43	43	$this->_end->_valid = false;
44	44	}
45	45	} else {
46		- if (!$this->rule->validator->validate($context, [ $this->name => Validator::CONTEXT_IN ])) {
	46	+ if (!$this->rule->validator->validate($context, [$this->name => Validator::CONTEXT_IN])) {
47	47	$this->setValid(false);
48	48	} else {
49	49	$this->_valid = false;

kadet1090 / KeyLighter

Branch — 0.8-dev (82421f)

Status

Category

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +12 added lines, -12 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch