DelegateRegexMatcher::match() - Code Metrics - Inspection of "Removed always false condition" - kadet1090/KeyLighter - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — 0.8-dev (82421f)

by Kacper

created 2016-04-09 21:46 UTC

DelegateRegexMatcher::match() A

↳ Parent: DelegateRegexMatcher

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
ccs	9
cts	9
cp	1
cc	3
eloc	6
nc	3
nop	2
crap	3

<?php
/**
 * Highlighter
 *
 * Copyright (C) 2016, Some right reserved.
 *
 * @author Kacper "Kadet" Donat <[email protected]>
 *
 * Contact with author:
 * Xmpp: [email protected]
 * E-mail: [email protected]
 *
 * From Kadet with love.
 */

namespace Kadet\Highlighter\Matcher;

use Kadet\Highlighter\Parser\TokenFactoryInterface;

class DelegateRegexMatcher implements MatcherInterface
{
    private $regex;
    private $callable;

    /**
     * RegexMatcher constructor.
     *
     * @param          $regex
     * @param callable $callable
     */
    public function __construct($regex, callable $callable)
    {
        $this->regex    = $regex;
        $this->callable = $callable;
    }

    /**
     * Matches all occurrences and returns token list
     *
     * @param string                $source Source to match tokens
     *
     * @param TokenFactoryInterface $factory
     *
     * @return \Generator
     */
    public function match($source, TokenFactoryInterface $factory)
    {
        preg_match_all($this->regex, $source, $matches, PREG_OFFSET_CAPTURE | PREG_SET_ORDER);

        $callable = $this->callable;
        foreach ($matches as $match) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            foreach($callable($match, $factory) as $token) {
                yield $token;
            }
        }
    }
}


1		<?php
2		/**
3		* Highlighter
4		*
5		* Copyright (C) 2016, Some right reserved.
6		*
7		* @author Kacper "Kadet" Donat <[email protected]>
8		*
9		* Contact with author:
10		* Xmpp: [email protected]
11		* E-mail: [email protected]
12		*
13		* From Kadet with love.
14		*/
15
16		namespace Kadet\Highlighter\Matcher;
17
18		use Kadet\Highlighter\Parser\TokenFactoryInterface;
19
20		class DelegateRegexMatcher implements MatcherInterface
21		{
22		private $regex;
23		private $callable;
24
25		/**
26		* RegexMatcher constructor.
27		*
28		* @param $regex
29		* @param callable $callable
30		*/
31	2	public function __construct($regex, callable $callable)
32		{
33	2	$this->regex = $regex;
34	2	$this->callable = $callable;
35	2	}
36
37		/**
38		* Matches all occurrences and returns token list
39		*
40		* @param string $source Source to match tokens
41		*
42		* @param TokenFactoryInterface $factory
43		*
44		* @return \Generator
45		*/
46	2	public function match($source, TokenFactoryInterface $factory)
47		{
48	2	preg_match_all($this->regex, $source, $matches, PREG_OFFSET_CAPTURE \| PREG_SET_ORDER);
49
50	2	$callable = $this->callable;
51	2	foreach ($matches as $match) {
		1 ignored issue – show Bug introduced 2016-04-06 19:25 UTC by Report Bug Copy Issue Report The expression `$matches` of type `null\|array<integer,array<integer,string>>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
52	2	foreach($callable($match, $factory) as $token) {
53	1	yield $token;
54	2	}
55	2	}
56	2	}
57		}
58

kadet1090 / KeyLighter

Branch — 0.8-dev (82421f)

DelegateRegexMatcher::match() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like