View GitHub Repository KeyLighter

Schedule Inspection
Subscribe
Passed
Branch — fuck-54 (18c095)
by Kacper
03:37
created

Parser/CloseRule.php (1 issue)

← previous file next file →
Labels
Severity
Introduced By

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

Code
1 
<?php
2 
/**
3 
 * Highlighter
4 
 *1
5 
 * Copyright (C) 2015, Some right reserved.
6 
 *
7 
 * @author Kacper "Kadet" Donat <[email protected]>
8 
 *
9 
 * Contact with author:
10 
 * Xmpp: [email protected]
11 
 * E-mail: [email protected]
12 
 *
13 
 * From Kadet with love.
14 
 */
15 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
namespace Kadet\Highlighter\Parser;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
class CloseRule extends Rule

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
{

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
    /**

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
     * @param $source

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
     *

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
     * @return Token[]

            


            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
     */

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                             1                         
                
                
                
    public function match($source)

            


            
                                                        
            
                                    
            
            

                
                    27
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    28
                

                                    
                             1                         
                
                
                
        $this->factory->type = TokenFactory::END;

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
Accessing type on the interface Kadet\Highlighter\Parser\TokenFactoryInterface suggest that you code against a concrete implementation. How about adding an instanceof check?
                                                                                                                                                    

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
If you access a property on an interface, you most likely code against a
concrete implementation of the interface.




Available Fixes


  1. Adding an additional type check:
    

    interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

    

    

    2. 

  2. Changing the type hint:
    

    interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeClass $object) {
    $a = $object->a;
}

    

    

    3. 



                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    29
                

                                    
                             1                         
                
                
                
        return parent::match($source);

            


            
                                                        
            
                                    
            
            

                
                    30
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    31
                

                                    
                                                    
                
                
                
}