Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
25 | class TokenFactory implements TokenFactoryInterface |
||
26 | { |
||
27 | private $_class; |
||
28 | private $_base; |
||
29 | private $_rule; |
||
30 | private $_offset; |
||
31 | private $_type = 0x3; |
||
32 | |||
33 | private $_cache = []; |
||
34 | |||
35 | /** |
||
36 | * Constructor |
||
37 | * |
||
38 | * @param string $class {@see } |
||
39 | */ |
||
40 | 62 | public function __construct($class) |
|
44 | |||
45 | /** |
||
46 | * @param $name |
||
47 | * @param array $params |
||
48 | * |
||
49 | * @return false|Token|null |
||
50 | */ |
||
51 | 46 | public function create($name, $params = [ ]) |
|
73 | |||
74 | 46 | private function link($name, $params) { |
|
106 | |||
107 | 19 | private function getName($name) |
|
115 | |||
116 | /** |
||
117 | * @param string $base |
||
118 | */ |
||
119 | 17 | public function setBase($base) |
|
124 | |||
125 | /** |
||
126 | * @param mixed $rule |
||
127 | */ |
||
128 | 59 | public function setRule($rule) |
|
132 | |||
133 | /** |
||
134 | * @param int $offset |
||
135 | */ |
||
136 | 13 | public function setOffset($offset) |
|
140 | |||
141 | /** |
||
142 | * @param mixed $class |
||
143 | * |
||
144 | * @throws \InvalidArgumentException |
||
145 | */ |
||
146 | 62 | public function setClass($class) |
|
154 | |||
155 | 2 | public function setType($type) |
|
159 | } |
||
160 |