kadet1090 /
KeyLighter
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 92 |
| Code Lines | 56 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 37 | public function setupRules() |
||
| 38 | { |
||
| 39 | $standard = new Validator(['!string', '!comment']); |
||
| 40 | |||
| 41 | $this->rules->addMany([ |
||
| 42 | 'keyword' => new Rule(new WordMatcher([ |
||
| 43 | 'and', 'del', 'from', 'not', 'while', 'as', 'elif', 'global', 'or', 'with', 'assert', 'else', 'if', |
||
| 44 | 'pass', 'yield', 'break', 'except', 'import', 'print', 'class', 'exec', 'in', 'raise', 'continue', |
||
| 45 | 'finally', 'is', 'return', 'def', 'for', 'lambda', 'try', |
||
| 46 | ])), |
||
| 47 | |||
| 48 | 'operator' => new Rule( |
||
| 49 | new RegexMatcher('/([-+%=]=?|!=|\*\*?=?|\/\/?=?|<[<=>]?|>[=>]?|[&|^~])|\b(or|and|not)\b/'), [ |
||
| 50 | 'priority' => -1 |
||
| 51 | ] |
||
| 52 | ), |
||
| 53 | |||
| 54 | 'expression' => new Rule(new RegexMatcher('/\{(\S+)\}/'), [ |
||
| 55 | 'context' => ['string'] |
||
| 56 | ]), |
||
| 57 | |||
| 58 | 'variable' => [ |
||
| 59 | new Rule(new RegexMatcher('/[^\w.]([a-z_]\w*)\.\w/i')), |
||
| 60 | 'property' => new Rule(new RegexMatcher('/(?=(?:\w|\)|\])\s*\.([a-z_]\w*))/i'), [ |
||
| 61 | 'priority' => -2, |
||
| 62 | 'context' => ['*none', '*expression'] |
||
| 63 | ]), |
||
| 64 | ], |
||
| 65 | |||
| 66 | |||
| 67 | 'symbol' => [ |
||
| 68 | new Rule(new RegexMatcher('/import\s+([a-z_][\w.]*)(?:\s*,\s*([a-z_][\w.]*))*/i', [ |
||
| 69 | 1 => Token::NAME, |
||
| 70 | 2 => Token::NAME, |
||
| 71 | ])), |
||
| 72 | 'library' => new Rule(new RegexMatcher('/from\s+([a-z_][\w.]*)\s+import/i', [ |
||
| 73 | 1 => Token::NAME, |
||
| 74 | ])) |
||
| 75 | ], |
||
| 76 | |||
| 77 | 'keyword.escape' => new Rule(new RegexMatcher('/(\\\(?:.|[0-7]{3}|x\x{2}))/'), [ |
||
| 78 | 'context' => Validator::everywhere() |
||
| 79 | ]), |
||
| 80 | |||
| 81 | 'comment' => new Rule(new CommentMatcher(['#'])), |
||
| 82 | 'constant.special' => [ |
||
| 83 | new Rule(new WordMatcher(['True', 'False', 'NotImplemented', 'Ellipsis'], [ |
||
| 84 | 'case-sensitivity' => true |
||
| 85 | ])), |
||
| 86 | new Rule(new RegexMatcher('/\b(__\w+__)\b/')) |
||
| 87 | ], |
||
| 88 | 'call' => new Rule(new RegexMatcher('/([a-z_]\w*)\s*\(/i'), ['priority' => 2]), |
||
| 89 | |||
| 90 | 'meta.newline' => new CloseRule(new RegexMatcher('/()\r?\n/'), [ |
||
| 91 | 'factory' => new TokenFactory(TerminatorToken::class), |
||
| 92 | 'context' => ['!keyword.escape', 'string.single-line'], |
||
| 93 | 'closes' => ['string.single-line.double', 'string.single-line.single'] |
||
| 94 | ]), |
||
| 95 | |||
| 96 | 'number' => new Rule( |
||
| 97 | new RegexMatcher('/(-?(?:0[bo])?(?:(?:\d|0x[\da-f])[\da-f]*\.?\d*|\.\d+)(?:e[+-]?\d+)?j?)\b/') |
||
| 98 | ), |
||
| 99 | |||
| 100 | 'string' => [ |
||
| 101 | 'single-line' => [ |
||
| 102 | 'double' => new Rule(new RegexMatcher('/(?:^|[^"])(")(?=[^"]|$)/'), [ |
||
| 103 | 'factory' => new TokenFactory(ContextualToken::class), |
||
| 104 | 'context' => $standard, |
||
| 105 | ]), |
||
| 106 | 'single' => new Rule(new RegexMatcher('/(?:^|[^\'])(\')(?=[^\']|$)/'), [ |
||
| 107 | 'factory' => new TokenFactory(ContextualToken::class), |
||
| 108 | 'context' => $standard, |
||
| 109 | ]), |
||
| 110 | ], |
||
| 111 | 'multi-line' => [ |
||
| 112 | 'double' => new Rule(new SubStringMatcher('"""'), [ |
||
| 113 | 'factory' => new TokenFactory(ContextualToken::class), |
||
| 114 | 'context' => $standard, |
||
| 115 | 'priority' => 2, |
||
| 116 | ]), |
||
| 117 | 'single' => new Rule(new SubStringMatcher('\'\'\''), [ |
||
| 118 | 'factory' => new TokenFactory(ContextualToken::class), |
||
| 119 | 'context' => $standard, |
||
| 120 | 'priority' => 2, |
||
| 121 | ]), |
||
| 122 | ] |
||
| 123 | ], |
||
| 124 | |||
| 125 | 'symbol.function' => new Rule(new RegexMatcher('/def\s+([a-z_]\w+)\s*\(/i')), |
||
| 126 | 'symbol.class' => new Rule(new RegexMatcher('/class\s+([a-z_]\w+)/i')), |
||
| 127 | ]); |
||
| 128 | } |
||
| 129 | |||
| 140 |
