Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 25 | class Sass extends Scss |
||
| 26 | { |
||
| 27 | |||
| 28 | /** |
||
| 29 | * Tokenization rules |
||
| 30 | */ |
||
| 31 | public function setupRules() |
||
| 32 | { |
||
| 33 | parent::setupRules(); |
||
| 34 | |||
| 35 | $this->rules->remove('meta.declaration'); |
||
| 36 | $this->rules->remove('meta.declaration.media'); |
||
| 37 | |||
| 38 | $this->rules->add('meta.selector', new Rule(new RegexMatcher('/(?=(?:\n+|^)(\h*)([^\h].*)\n+\1\h+)/', [ |
||
| 39 | 2 => Token::NAME |
||
| 40 | ]), [ |
||
| 41 | 'context' => Validator::everywhere(), |
||
| 42 | 'priority' => 3, |
||
| 43 | 'factory' => new TokenFactory(MetaToken::class) |
||
| 44 | ])); |
||
| 45 | |||
| 46 | $this->rules->add('meta.declaration', new Rule(new RegexMatcher('/\n((?:\h+.*?(?>\n|$)+)+)/'), [ |
||
| 47 | 'context' => Validator::everywhere(), |
||
| 48 | 'priority' => 2, |
||
| 49 | 'factory' => new TokenFactory(MetaToken::class) |
||
| 50 | ])); |
||
| 51 | |||
| 52 | $this->rules->add('meta.declaration.media', new Rule(new RegexMatcher('/@media(.*?)\n/'), [ |
||
| 53 | 'context' => Validator::everywhere(), |
||
| 54 | 'factory' => new TokenFactory(MetaToken::class) |
||
| 55 | ])); |
||
| 56 | |||
| 57 | $this->rules->add('symbol.selector.tag', new Rule(new RegexMatcher('/\b([a-z-][\w-]*)/'), [ |
||
| 58 | 'context' => ['meta.selector', '!symbol', '!meta.declaration.media'], |
||
| 59 | ])); |
||
| 60 | |||
| 61 | $this->rules->rule('symbol.selector.class')->setContext(['meta.selector']); |
||
| 62 | $this->rules->rule('keyword.at-rule')->setContext(['meta.selector']); |
||
| 63 | $this->rules->rule('symbol.selector.class.pseudo')->setContext(['meta.selector']); |
||
| 64 | $this->rules->rule('symbol.selector.id')->setContext(['meta.selector']); |
||
| 65 | } |
||
| 66 | |||
| 67 | public function getIdentifier() |
||
| 71 | |||
| 72 | View Code Duplication | public static function getMetadata() |
|
| 80 | } |
||
| 81 |