LineMessage::__construct() - Code Metrics - Inspection of "Changed LineMessage to `extends TextMessageBuilder..." - kPherox/laravel-notification-line - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 06ea43...041713 )

by Ryota

created 2018-06-26 03:06 UTC

LineMessage::__construct() A

↳ Parent: LineMessage

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.7998
cc	3
nc	4
nop	2

<?php

namespace NotificationChannels\Line;

use LINE\LINEBot\Constant\MessageType;
use LINE\LINEBot\MessageBuilder;
use NotificationChannels\Line\Exceptions\CouldNotSendNotification;

class LineMessage implements MessageBuilder
{
    /** @var string[] */
    private $texts;
    /** @var array */
    private $message = [];

    public function __construct($text, $extraTexts = null)
    {
        $extra = [];
        if (! is_null($extraTexts)) {
            $args = func_get_args();
            $extra = array_slice($args, 1);
        }

        if (count($extra) >= 4) {
            throw CouldNotSendNotification::exceededOfMessages(count($extra) + 1);
        }

        $this->texts = array_merge([$text], $extra);

    }

    /**
     * Builds text message structure.
     */
    public function buildMessage() : array
    {
        if (!empty($this->message)) {
            return $this->message;
        }
        foreach ($this->texts as $text) {
            $this->message[] = [
                'type' => MessageType::TEXT,
                'text' => $text,
            ];
        }
        return $this->message;
    }
}


1			<?php
2
3			namespace NotificationChannels\Line;
4
5			use LINE\LINEBot\Constant\MessageType;
6			use LINE\LINEBot\MessageBuilder;
7			use NotificationChannels\Line\Exceptions\CouldNotSendNotification;
8
9			class LineMessage implements MessageBuilder
10			{
11			/** @var string[] */
12			private $texts;
13			/** @var array */
14			private $message = [];
15
16			public function __construct($text, $extraTexts = null)
17			{
18			$extra = [];
19			if (! is_null($extraTexts)) {
20			$args = func_get_args();
21			$extra = array_slice($args, 1);
22			}
23
24			if (count($extra) >= 4) {
25			throw CouldNotSendNotification::exceededOfMessages(count($extra) + 1);
26			}
27
28			$this->texts = array_merge([$text], $extra);
			0 ignored issues – show Documentation Bug introduced 2018-06-26 01:13 UTC by Report Bug Copy Issue Report It seems like `array_merge(array($text), $extra)` of type `array` is incompatible with the declared type `array<integer,string>` of property `$texts`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
29			}
30
31			/**
32			* Builds text message structure.
33			*/
34			public function buildMessage() : array
35			{
36			if (!empty($this->message)) {
37			return $this->message;
38			}
39			foreach ($this->texts as $text) {
40			$this->message[] = [
41			'type' => MessageType::TEXT,
42			'text' => $text,
43			];
44			}
45			return $this->message;
46			}
47			}
48

kPherox / laravel-notification-line

Push — master ( 06ea43...041713 )

LineMessage::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like