LineMessage::__construct() - Code Metrics - Inspection of "Changed LineMessage to extend TextMessageBuilder" - kPherox/laravel-notification-line - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c63e30...778a07 )

by Ryota

created 2018-06-26 01:08 UTC

LineMessage::__construct() A

↳ Parent: LineMessage

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	16
rs	9.7333
cc	3
nc	4
nop	2

<?php

namespace NotificationChannels\Line;

use NotificationChannels\Line\Exceptions\CouldNotSendNotification;
use LINE\LINEBot\MessageBuilder\TextMessageBuilder;

class LineMessage implements TextMessageBuilder
{
    /** @var string[] */
    private $texts;
    /** @var array */
    private $message = [];


    public function __construct($text, $extraTexts = null)
    {
        $extra = [];
        if (!is_null($extraTexts)) {
            $args = func_get_args();
            $extra = array_slice($args, 1);
        }

        if (count($extra) >= 4) {
            throw CouldNotSendNotification::exceededOfMessages(count($extra) + 1);
        }

        $this->texts = array_merge([$text], $extra);


        $this->contents = $contents;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1			<?php
2
3			namespace NotificationChannels\Line;
4
5			use NotificationChannels\Line\Exceptions\CouldNotSendNotification;
6			use LINE\LINEBot\MessageBuilder\TextMessageBuilder;
7
8			class LineMessage implements TextMessageBuilder
9			{
10			/** @var string[] */
11			private $texts;
12			/** @var array */
13			private $message = [];
			0 ignored issues – show Unused Code introduced 2018-06-26 01:13 UTC by Report Bug Copy Issue Report The property `$message` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
14
15			public function __construct($text, $extraTexts = null)
16			{
17			$extra = [];
18			if (!is_null($extraTexts)) {
19			$args = func_get_args();
20			$extra = array_slice($args, 1);
21			}
22
23			if (count($extra) >= 4) {
24			throw CouldNotSendNotification::exceededOfMessages(count($extra) + 1);
25			}
26
27			$this->texts = array_merge([$text], $extra);
			0 ignored issues – show Documentation Bug introduced 2018-06-26 01:13 UTC by Report Bug Copy Issue Report It seems like `array_merge(array($text), $extra)` of type `array` is incompatible with the declared type `array<integer,string>` of property `$texts`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
28
29			$this->contents = $contents;
			0 ignored issues – show Bug introduced 2018-06-26 01:13 UTC by Report Bug Copy Issue Report The property `contents` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2018-06-26 01:13 UTC by Report Bug Copy Issue Report The variable `$contents` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
30			}
31			}
32

kPherox / laravel-notification-line

Push — master ( c63e30...778a07 )

LineMessage::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like