domReady.js ➔ ... ➔ scrollCheck - Code Metrics - Inspection of "testing..." - kMediaGbR/silverstripe-recaptcha - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( abe803...75229a )

by Sebastian

created 2019-05-13 17:08 UTC

domReady.js ➔ ... ➔ scrollCheck A

↳ Parent: domReady.js ➔ domReady

Complexity

Conditions	2
Paths	3

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	10
dl	0
loc	15
rs	9.9
c	1
b	0
f	0
cc	2
nc	3
nop	0

function domReady(fn) {
    'use strict';

    var ready = false;

    function detach() {
        if (document.addEventListener) {
            document.removeEventListener('DOMContentLoaded', completed);
            window.removeEventListener('load', completed);
        } else {
            document.detachEvent('onreadystatechange', completed);
            window.detachEvent('onload', completed);
        }
    }

    function completed() {
        if (!ready && (document.addEventListener || event.type === 'load' || document.readyState === 'complete')) {

            ready = true;
            detach();
            fn();
        }
    }

    if (document.readyState === 'complete') {
        fn();
    } else if (document.addEventListener) {
        document.addEventListener('DOMContentLoaded', completed);
        window.addEventListener('load', completed);
    } else {
        document.attachEvent('onreadystatechange', completed);
        window.attachEvent('onload', completed);

        var top = false;


        try {
            top = window.frameElement == null && document.documentElement;

        } catch (e) {}


        if (top && top.doScroll) {
            (function scrollCheck() {
                if (ready) {
                    return;

                }

                try {
                    top.doScroll('left');
                } catch (e) {
                    return setTimeout(scrollCheck, 50);
                }

                ready = true;
                detach();
                fn();

            })();
        }
    }
}


1			function domReady(fn) {
2			'use strict';
3
4			var ready = false;
5
6			function detach() {
7			if (document.addEventListener) {
8			document.removeEventListener('DOMContentLoaded', completed);
9			window.removeEventListener('load', completed);
10			} else {
11			document.detachEvent('onreadystatechange', completed);
12			window.detachEvent('onload', completed);
13			}
14			}
15
16			function completed() {
17			if (!ready && (document.addEventListener \|\| event.type === 'load' \|\| document.readyState === 'complete')) {
			0 ignored issues – show Bug introduced 2019-05-13 17:10 UTC by Report Bug Copy Issue Report The variable `event` seems to be never declared. If this is a global, consider adding a `/** global: event */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
18			ready = true;
19			detach();
20			fn();
21			}
22			}
23
24			if (document.readyState === 'complete') {
25			fn();
26			} else if (document.addEventListener) {
27			document.addEventListener('DOMContentLoaded', completed);
28			window.addEventListener('load', completed);
29			} else {
30			document.attachEvent('onreadystatechange', completed);
31			window.attachEvent('onload', completed);
32
33			var top = false;
			0 ignored issues – show Unused Code introduced 2019-05-13 17:10 UTC by Report Bug Copy Issue Report The assignment to variable `top` seems to be never used. Consider removing it. Loading history...
34
35			try {
36			top = window.frameElement == null && document.documentElement;
			0 ignored issues – show Best Practice introduced 2019-05-13 17:10 UTC by Report Bug Copy Issue Report Comparing `window.frameElement` to `null` using the `==` operator is not safe. Consider using `===` instead. Loading history...
37			} catch (e) {}
			0 ignored issues – show Coding Style Comprehensibility Best Practice introduced 2019-05-13 17:10 UTC by Report Bug Copy Issue Report Empty catch clauses should be used with caution; consider adding a comment why this is needed. Loading history...
38
39			if (top && top.doScroll) {
40			(function scrollCheck() {
41			if (ready) {
42			return;
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-05-13 17:10 UTC by Report Bug Copy Issue Report Are you sure this return statement is not missing an argument? If this is intended, consider adding an explicit `undefined` like `return undefined;`. Loading history...
43			}
44
45			try {
46			top.doScroll('left');
47			} catch (e) {
48			return setTimeout(scrollCheck, 50);
49			}
50
51			ready = true;
52			detach();
53			fn();
			0 ignored issues – show Best Practice introduced 2019-05-13 17:10 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
54			})();
55			}
56			}
57			}
58

kMediaGbR / silverstripe-recaptcha

GitHub Access Token became invalid

Push — master ( abe803...75229a )

domReady.js ➔ ... ➔ scrollCheck A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like