View GitHub Repository awspec

Schedule Inspection
Subscribe
Completed
Push — master ( b0a854...c8816e )
by Ken’ichiro
03:30
created

RdsDbParameterGroup   A

↳ Parent: Project

Complexity

Total Complexity 2

Size/Duplication

Total Lines 19
Duplicated Lines 100 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 19
loc 19
rs 10
wmc 2

2 Methods

Rating   Name   Duplication   Size   Complexity  
A generate_by_parameter_group() 5 5 1
A db_parameter_group_template() 10 10 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1 
module Awspec::Generator
2 
  module Spec
3 View Code Duplication 
    class RdsDbParameterGroup
0 ignored issues
– show
Duplication introduced by
This code seems to be duplicated in your project.
Loading history...
4 
      include Awspec::Helper::Finder
5 
      def generate_by_parameter_group(parameter_group)
6 
        @parameter_group = parameter_group
7 
        res = select_all_rds_db_parameters(@parameter_group)
8 
        ERB.new(db_parameter_group_template, nil, '-').result(binding).gsub(/^\n/, '')
9 
      end
10 

            


            
                                                                        
                            
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
      def db_parameter_group_template

            


            
                                                                        
                            
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
        template = <<-'EOF'

            


            
                                                                        
                            
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
describe rds_db_parameter_group('<%= @parameter_group %>') do

            


            
                                                                        
                            
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
<% res.each do |key, value| %>

            


            
                                                                        
                            
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
  its('<%= key %>') { should eq '<%= value %>' }

            


            
                                                                        
                            
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
<% end %>

            


            
                                                                        
                            
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
end

            


            
                                                                        
                            
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
EOF

            


            
                                                                        
                            
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
        template

            


            
                                                                        
                            
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
      end

            


            
                                                                        
                            
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
    end

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
  end

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                
end

            


            
                                                        
            
                                    
            
            

                
                    24